Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe merge AppendResponse and free Inflights aggressively #500

Open
Fullstop000 opened this issue Aug 26, 2020 · 1 comment
Open

Maybe merge AppendResponse and free Inflights aggressively #500

Fullstop000 opened this issue Aug 26, 2020 · 1 comment
Milestone

Comments

@Fullstop000
Copy link

Fullstop000 commented Aug 26, 2020

The basic idea and a rough benchmark result is posted here etcd-io/etcd#12026
And I've also tested this in raft-rs on a 5 node TiKV cluster. The result shows almost 30% reducing on append_resp messages in a bulk inserting work load.

I'm not sure the thread model of the network transport layer in sofa-raft. If the append response messages are sent asynchronously back to leader batch by batch (just like etcd), maybe we can gain some benefit by merging AppendResponse because I found sofa-raft free the Inflight's in a FIFO style.

@killme2008
Copy link
Contributor

It seems like a good idea, we may try to implement and test it, thanks for your suggestion.

@killme2008 killme2008 added this to the 1.3.5 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants