Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pims.open(list_of_filenames) doesn't work #435

Closed
anntzer opened this issue Jan 24, 2023 · 0 comments
Closed

pims.open(list_of_filenames) doesn't work #435

anntzer opened this issue Jan 24, 2023 · 0 comments

Comments

@anntzer
Copy link
Contributor

anntzer commented Jan 24, 2023

... even though that is documented as supported in the docstring of pims.open. This is because the list_of_filenames is passed to glob.glob, which likewise doesn't support lists.

I suspect this has actually never worked, so the easy way out is to just not document that, but given that ImageSequence does support such inputs, I guess the intent is to also support it in pims.open, which can probably also be done by adding something like if not isinstance(sequence, str): return ImageSequence(sequence, **kwargs) at the top of open() (the proposed typecheck is the same as in ImageSequence._get_files).

Edit: I guess that's basically a dupe of #310, let's keep that discussion over there.

@anntzer anntzer closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant