Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better testing for predictor diagnostics #110

Closed
nkeim opened this issue Jul 4, 2014 · 1 comment
Closed

Better testing for predictor diagnostics #110

nkeim opened this issue Jul 4, 2014 · 1 comment
Assignees
@nkeim

Comments

@nkeim
Copy link
Contributor

nkeim commented Jul 4, 2014

Tests for predict.py should check that the instrumented() class decorator works properly with each of the built-in predictor classes. This should involve a simple linking task, followed by cursory inspection of the output of dump().

Since the diagnostic output depends on the predictor class it was used on, checking the numerical correctness of that information would be difficult.
@nkeim nkeim self-assigned this Jul 4, 2014
@nkeim
Copy link
Contributor Author

nkeim commented Jun 22, 2015

Addressed by #109

@nkeim nkeim closed this as completed Jun 22, 2015
@nkeim nkeim mentioned this issue Jun 22, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkeim nkeim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nkeim