Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF/API: numba decorators only turn on for numba 0.11.* #83

Merged
merged 2 commits into from
Feb 17, 2014

Conversation

danielballan
Copy link
Member

closes #81 and #82

@danielballan
Copy link
Member Author

The purpose of this PR evolved after an in-person conversation between Nathan and me.

If numba 0.11.* is installed, numba-accelerated mode is enabled by default.

If numba is not installed or a version other than 0.11.* is installed, numba is disabled by default. If you try to use engine='numba' or call trackpy.enable_numba(), you will get an informative error message, mentioning which version of numba (if any) trackpy sees and which version it wants.

We will probably never support 0.12, but we will revisit for numba 0.13+ when the project is (we hope) more stable. See links in #82 for discussion on what happened over at numba. Since numba 0.12 is (apparently accidentally) the new default with conda, I added a Travis build to make sure trackpy is falling back to pure Python and working properly with out-of-the-box conda, even though numba 0.11 is recommended in the docs.

@nkeim please merge if this looks good to you.

nkeim added a commit that referenced this pull request Feb 17, 2014
REF/API: numba decorators only turn on for numba 0.11.*
@nkeim nkeim merged commit 5952558 into soft-matter:master Feb 17, 2014
@nkeim
Copy link
Contributor

nkeim commented Feb 17, 2014

Great! This will get us through numba's growing pains. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a pair of Travis builds for numpy 1.8 and numba 0.12
2 participants