Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default retry even in non-idempotent methods when network errors #66

Open
Duncan00 opened this issue Dec 20, 2018 · 0 comments
Open

Default retry even in non-idempotent methods when network errors #66

Duncan00 opened this issue Dec 20, 2018 · 0 comments

Comments

@Duncan00
Copy link

As long as there is a network error, it will do retry, regrading of the HTTP methods:
https://github.com/softonic/axios-retry/blob/master/es/index.js#L63

So even in ETIMEDOUT or ECONNRESET
https://github.com/softonic/axios-retry/blob/master/es/index.js#L14
https://github.com/floatdrop/is-retry-allowed/blob/master/index.js#L4

So it is possible that in a non-idempotent POST request, it will do retry and it will create duplicated entries in server side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant