-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"print" is not defined #8
Comments
Possibly here is a solution: https://groups.google.com/d/msg/mozilla.dev.tech.js-engine.rhino/EJmJJhftc3g/JELu_XEi5TwJ |
Thanks @kastigar I'll have a look tonight. |
I'm getting the same error mentioned above when I try to compile twitter bootstrap but as it's the first time I've tried I can't comment on whether its to do with a change in less-sbt or just what I'm attempting to do! I notice in the release note for less-sbt 0.1.4: updated less compiler support from less-rhino-1.1.3.js to less-rhino-1.1.5.js. But using less-sbt 0.1.4 myself (and in the example output above) it refers to less-rhino-1.1.3.js Is this in any way connected. |
Can one if you guys set up an example test case repo and toss it on github? That would make things a little easier for me. Afterwards I can translate it to an sbt scripted test so I can avoid regression test failures when I switch between versions. Are you both getting this error using twitters bootstrap. I don't get the error in any of my less projects. It's very likely something I can hack in the compiler js it self. I ran into a similar issue (though the error was no so revealing!) with the coffeescript plugin after I updated. The compiler js was using a property that is a keyword in future versions of ecmascript, |
Okay, some progress perhaps... The current The original error relating to print, relates to this code:
but
However, in the end that didn't really help me to identify the underlying problem. Next... So, I changed the code in This resulted in a new error in line
Basically, the check for
And then everything worked fine. Including the complete compile of Twitter Bootcamp 2. |
Aw crap! Not using the newer version of less-rhino. That's clearly my bug. Ill look into this tonight. |
I think I've got the fix. The key was kind of clear after swapping compiler versions and then running the scripted tests. Aren't tests priceless! I got an error in the import test on this line. If you look a few above you'll notice the rhino detection failed! Thank's to @kastigar's link above. I followed the original poster n that list back to the ringojs project (like nodejs but using rhino and the jvm) which linked to a gh issue and with a commit back to a file which provided a tremendous amount of insight. I assume no know knows the rhino library better than the authors themselves than this guy. I think I only need a subset of that to solve the problem but the underlying problem is this: Js libraries that expose a rhino-friendly interface can and will do so exploiting some function calls that are defined within the rhino shell env. My assumption is that the extend of their testing is to fire up the rhino shell jar and test their library. Since I am embedding rhino instead, these functions are not defined in the js evaluation env I was using. How funny is that? Well not that funny if you get these kinds of bug reports. Anyway. I think that closes this issue but I can't be sure until I try to emulate one of either of your test cases. Are you guys just cloning the twitter bootstrap project to get the less source files? I think I will make an sbt scripted test for that since I assume that project is what's driving interest in Thank guys for point this out. I'll going to try and get a few more fixes (and tests) in tonight and I'll do a release, 0.1.5 including this and what ever else I can get done. |
I was able to compile twitter bootstrap in a scripted test so I'm closing this one after a946d95 |
Many thanks for being so responsive and for all the work you've done in making this great tool available to all us freeloaders :) |
Hi!
Since today i can't do less task. I get such error:
I don't know what was changed (i don't remember when i have last recompilation of my less files).
The text was updated successfully, but these errors were encountered: