Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if directory creation was successfull #134

Open
naraesk opened this issue Feb 5, 2020 · 0 comments
Open

check if directory creation was successfull #134

naraesk opened this issue Feb 5, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@naraesk
Copy link
Member

naraesk commented Feb 5, 2020

In Settingsconfiguration.java we create directories using mkdirs(). We should check the return type and print an error message to the log, if the directory could not be created

Findbugs output:

Exceptional return value of java.io.File.mkdirs() ignored in org.getaviz.generator.SettingsConfiguration.loadConfig(String)

Exceptional return value of java.io.File.mkdirs() ignored in org.getaviz.generator.SettingsConfiguration.loadConfig(HttpServletRequest)
@naraesk naraesk added enhancement New feature or request good first issue Good for newcomers labels Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@naraesk