Replace useRef with useState for useSharedValue #5458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amadeus
force-pushed
the
shared-value-hook-improvement
branch
from
3a642cd
to
46a8b54
Compare
|
@amadeus Thanks a lot for submitting this PR! |
The general idea here is that we can avoid the makeMutable call on every single render. This change is also compatible with hot reloading.
amadeus
force-pushed
the
shared-value-hook-improvement
branch
from
46a8b54
to
5304613
Compare
piaskowyk
approved these changes
Dec 6, 2023
|
Yay Thanks! |
gaearon
reviewed
Dec 7, 2023
| useEffect(() => { | ||
| return () => { | ||
| cancelAnimation(ref.current); | ||
| cancelAnimation(mutable); |
There was a problem hiding this comment.
Kind of a drive-by comment but in general effects that only do cleanup usually indicate that something else is wrong. Effects should be symmetrical.
There was a problem hiding this comment.
I’d be curious for your thoughts on how something like this should work? Assuming you have an animation in progress that needs to be cleaned up on unmount
Latropos
pushed a commit
that referenced
this pull request
Dec 12, 2023
## Summary The general idea here is that we can avoid the `makeMutable` call on every single render. This change is also compatible with hot reloading. We (at Discord) have been running this patch on top of our own reanimated now for a few weeks and haven't noticed any side effects of the change. There has been a bit of additional discussion I've seen surrounding this issue here: #3199 ## Test plan N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The general idea here is that we can avoid the
makeMutablecall on every single render. This change is also compatible with hot reloading.We (at Discord) have been running this patch on top of our own reanimated now for a few weeks and haven't noticed any side effects of the change.
There has been a bit of additional discussion I've seen surrounding this issue here: #3199
Test plan
N/A