fix: build issues on visionOS #5980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@okwasniewski Thanks for the PR! I've noticed that you've added an import in |
|
Thanks for checking the PR @tomekzaw ! You are right this import should be added for every configuration not only simulators. I've moved the import 👍🏻 |
bartlomiejbloniarz
approved these changes
May 6, 2024
Merged
via the queue into
software-mansion:main
with commit May 6, 2024
7bc2944
11 of 12 checks passed
GSTJ
pushed a commit
to GSTJ/react-native-magic-modal
that referenced
this pull request
May 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-reanimated](https://togithub.com/software-mansion/react-native-reanimated) | [`~3.10.1` -> `~3.11.0`](https://renovatebot.com/diffs/npm/react-native-reanimated/3.10.1/3.11.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-reanimated (react-native-reanimated)</summary> ### [`v3.11.0`](https://togithub.com/software-mansion/react-native-reanimated/releases/tag/3.11.0) [Compare Source](https://togithub.com/software-mansion/react-native-reanimated/compare/3.10.1...3.11.0) #### What's Changed - Fix EXC_BAD_ACCESS crash on iOS in `[REAAnimationsManager clearSharedTransitionConfigForTag:]` by [@​tomekzaw](https://togithub.com/tomekzaw) in [software-mansion/react-native-reanimated#5975 - Fix uncaught exception 'NSUnknownKeyException' on app reload on iOS by [@​tomekzaw](https://togithub.com/tomekzaw) in [software-mansion/react-native-reanimated#5976 - Test two ways to use sharedValue in `useAnimatedStyle` by [@​Latropos](https://togithub.com/Latropos) in [software-mansion/react-native-reanimated#5893 - docs: fix grammar by [@​wodin](https://togithub.com/wodin) in [software-mansion/react-native-reanimated#5978 - fix: build issues on visionOS by [@​okwasniewski](https://togithub.com/okwasniewski) in [software-mansion/react-native-reanimated#5980 **Full Changelog**: software-mansion/react-native-reanimated@3.10.0...3.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/GSTJ/react-native-magic-modal). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes build issues for visionOS. The
CACurrentMediaTimeAPI comes from QuartzCore which was not imported in this file. Unfortunately, visionOS is more strict and requires explicit imports, this shouldn't cause any issues on other platforms.Test plan
Build the app for visionOS