-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI issues with yarn #5996
Fix CI issues with yarn #5996
Conversation
I fixed issues with regard to RN template using Yarn 3.6.4 by default. @tomekzaw @piaskowyk Could you take a look at the failing V8 and monorepo CIs? I have the following questions.
Which doesn't make a lot of sense - creating the EDIT: Thanks for discussing it with me offline. |
## About This pull request is a part of the effort of migrating to monorepo structure: - #5992 ## Summary Moving `.github` directory to the root of the project, alongside with fixes that regard new repository structures. This pull request won't fix CIs which are being tackled in - #5996 ## Test plan No CI should fail on a step related to the change of the monorepo structure. ## Steps achieved towards monorepo - [ ] All CI pass - [ ] Precommit scripts work properly - [ ] react-native-reanimated is a separate workspace which uses hoisted node_modules - [ ] app is a separate workspace which uses hoisted node_modules - [ ] paper example is a separate workspace which uses hoisted node_modules - [ ] fabric example is a separate workspace which uses hoisted node_modules - [ ] web example is a separate workspace which uses hoisted node_modules - [ ] macos example is a separate workspace which uses hoisted node_modules - [ ] example is a separate workspace which uses hoisted node_modules - [ ] reanimated eslint plugin is a separate workspace which uses hoisted node_modules - [ ] the npm package builds and works as expected - [ ] reanimated2 directory is removed - [ ] TypeScript, ESLint and Prettier configs are unified and only extended when necessary in workspaces
Summary
Due to changes to React Native app template, it uses Yarn 3.6.4 out of the box now. This version of Yarn cannot resolve packages from GitHub's pull request refs. Therefore we have to resolve it for it and install via a downloaded package. It's not something crazy - Yarn 1 would do exactly those steps.
Test plan
Should not fail on the dependency installing steps with yarn. Ideally, they shouldn't fail at all.