Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues with yarn #5996

Merged
merged 18 commits into from
May 15, 2024
23 changes: 9 additions & 14 deletions .github/workflows/build-monorepo-action.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: Test build in monorepo
env:
YARN_ENABLE_HARDENED_MODE: 0
REACT_NATIVE_TEMPLATE: ${{ inputs.react_native_version && '--version' || '' }} ${{ inputs.react_native_version }}
YARN_ENABLE_IMMUTABLE_INSTALLS: 0
on:
workflow_call:
inputs:
Expand All @@ -14,9 +13,6 @@ on:
is_hoisted:
required: true
type: boolean
react_native_version:
required: false
type: string

jobs:
build:
Expand All @@ -33,17 +29,18 @@ jobs:
java-version: '17'
- name: Create directories
run: mkdir -p monorepo/packages

- name: Setup monorepo
working-directory: monorepo
run: echo '{"name":"rnos-monorepo-tester","version":"1.0.0","license":"MIT","private":true,"workspaces":{"packages":["RootApp","packages/PackageApp", "AppA", "AppB"],"nohoist":["**/react","**/react-dom","**/react-native","**/react-native/**","**/react-native-codegen","**/react-native-dev-menu"]}}' > package.json
- name: Install dependencies
run: yarn install
- name: Create RootApp
working-directory: monorepo
run: npx react-native init RootApp --skip-install ${{ env.REACT_NATIVE_TEMPLATE }}
run: npx react-native@0.73 init RootApp --skip-install --version 0.73
- name: Create PackageApp
working-directory: monorepo/packages
run: npx react-native init PackageApp --skip-install ${{ env.REACT_NATIVE_TEMPLATE }}
- name: Setup monorepo
working-directory: monorepo
run: |
echo '{"name":"rnos-monorepo-tester","version":"1.0.0","license":"MIT","private":true,"workspaces":{"packages":["RootApp","packages/PackageApp", "AppA", "AppB"],"nohoist":["**/react","**/react-dom","**/react-native","**/react-native/**","**/react-native-codegen","**/react-native-dev-menu"]}}' > package.json
yarn
run: npx react-native@0.73 init PackageApp --skip-install --version 0.73

- name: Install dependencies for RootApp
working-directory: monorepo/RootApp
Expand Down Expand Up @@ -72,7 +69,6 @@ jobs:
if: ${{ inputs.platform == 'iOS' }}
working-directory: monorepo/packages/PackageApp/ios
run: pod install

- name: Build iOS app RootApp
if: ${{ inputs.platform == 'iOS' }}
working-directory: monorepo/RootApp
Expand All @@ -81,7 +77,6 @@ jobs:
if: ${{ inputs.platform == 'iOS' }}
working-directory: monorepo/packages/PackageApp
run: yarn react-native run-ios --simulator='iPhone 14' --no-packager

- name: Build Android RootApp
if: ${{ inputs.platform == 'Android' }}
working-directory: monorepo/RootApp/android
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/build-on-windows-nightly.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Test build on Windows nightly
env:
YARN_ENABLE_HARDENED_MODE: 0
YARN_ENABLE_IMMUTABLE_INSTALLS: 0
on:
pull_request:
paths:
Expand All @@ -27,9 +27,12 @@ jobs:
- name: Install dependencies
working-directory: App
run: yarn
- name: Download Reanimated from commit
working-directory: App
run: curl -LJO https://codeload.github.com/software-mansion/react-native-reanimated/tar.gz/${{ github.sha }}
- name: Install Reanimated
working-directory: App
run: yarn add github:software-mansion/react-native-reanimated#${{ github.ref }}
run: yarn add react-native-reanimated@file:./react-native-reanimated-${{ github.sha }}.tar.gz
- name: Build Android App
working-directory: App/android
run: ./gradlew assembleDebug --console=plain
23 changes: 15 additions & 8 deletions .github/workflows/build-v8-nightly.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
name: Test V8 on Android nightly
env:
YARN_ENABLE_HARDENED_MODE: 0
YARN_ENABLE_IMMUTABLE_INSTALLS: 0
on:
pull_request:
paths:
- .github/workflows/build-v8-nightly.yml
- .github/workflows/helper/configureV8.js
schedule:
- cron: '37 19 * * *'
# Disabled until V8 gets support for RN 0.74
# pull_request:
# paths:
# - .github/workflows/build-v8-nightly.yml
# - .github/workflows/helper/configureV8.js
# schedule:
# - cron: '37 19 * * *'
workflow_dispatch:

jobs:
Expand All @@ -32,9 +33,15 @@ jobs:
- name: Install dependencies
working-directory: app
run: yarn install
- name: Download Reanimated from commit
working-directory: app
run: curl -LJO https://codeload.github.com/software-mansion/react-native-reanimated/tar.gz/${{ github.sha }}
- name: Install Reanimated
working-directory: app
run: yarn add react-native-reanimated@file:./react-native-reanimated-${{ github.sha }}.tar.gz
- name: Install test dependencies
working-directory: app
run: yarn add github:software-mansion/react-native-reanimated#${{ github.ref }} react-native-v8 v8-android-jit
run: yarn add react-native-v8 v8-android-jit
- name: Configure V8
run: node reanimated_repo/.github/workflows/helper/configureV8.js
- name: Build Android app
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/check-static-framework-nightly.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Check static framework nightly build
env:
YARN_ENABLE_HARDENED_MODE: 0
YARN_ENABLE_IMMUTABLE_INSTALLS: 0
on:
pull_request:
paths:
Expand All @@ -23,9 +23,12 @@ jobs:
steps:
- name: Create React Native app
run: npx react-native init app
- name: Install dependencies
- name: Download Reanimated from commit
working-directory: app
run: yarn add github:software-mansion/react-native-reanimated
run: curl -LJO https://codeload.github.com/software-mansion/react-native-reanimated/tar.gz/${{ github.sha }}
- name: Install Reanimated
working-directory: app
run: yarn add react-native-reanimated@file:./react-native-reanimated-${{ github.sha }}.tar.gz
- name: Install Paper Pods
if: ${{ matrix.react-native-architecture == 'Paper' }}
working-directory: app/ios
Expand Down