fix: use proper classes for bridgeless #5997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
May 10, 2024
|
I can move this method only to a new file and make sourceSets from it. Do you want it? |
|
Yes, please |
|
Done |
piaskowyk
approved these changes
May 14, 2024
renovate bot
added a commit
to GSTJ/react-native-magic-modal
that referenced
this pull request
Jun 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-reanimated](https://togithub.com/software-mansion/react-native-reanimated) | [`~3.11.0` -> `~3.12.0`](https://renovatebot.com/diffs/npm/react-native-reanimated/3.11.0/3.12.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-reanimated (react-native-reanimated)</summary> ### [`v3.12.0`](https://togithub.com/software-mansion/react-native-reanimated/releases/tag/3.12.0) [Compare Source](https://togithub.com/software-mansion/react-native-reanimated/compare/3.11.0...3.12.0) #### What's Changed - Give more meaningful warning when modifying a Shareable by [@​tjzel](https://togithub.com/tjzel) in [software-mansion/react-native-reanimated#5548 - Make animated components use different tags for events by [@​szydlovsky](https://togithub.com/szydlovsky) in [software-mansion/react-native-reanimated#5960 - Add `warning` and `failing` test decorators by [@​Latropos](https://togithub.com/Latropos) in [software-mansion/react-native-reanimated#5929 - Update useAnimatedKeyboard docs by [@​maciekstosio](https://togithub.com/maciekstosio) in [software-mansion/react-native-reanimated#5866 - Change the docs to mention, that `.springify()` works with `.duration()` by [@​Latropos](https://togithub.com/Latropos) in [software-mansion/react-native-reanimated#5990 - \[Android]\[Keyboard] More consistent inequality check to compute keyboard state by [@​antFrancon](https://togithub.com/antFrancon) in [software-mansion/react-native-reanimated#5874 - fix typo on object key for `targetValues` in custom-animations.mdx by [@​JDMathew](https://togithub.com/JDMathew) in [software-mansion/react-native-reanimated#5994 - Remove outdated code for unsupported React Native versions by [@​tomekzaw](https://togithub.com/tomekzaw) in [software-mansion/react-native-reanimated#5979 - Remove REAInitializer by [@​tomekzaw](https://togithub.com/tomekzaw) in [software-mansion/react-native-reanimated#5681 - Prevent crash on non-existent view updates in Android by [@​thomas-rx](https://togithub.com/thomas-rx) in [software-mansion/react-native-reanimated#5767 - Fix location after shared element transition by [@​piaskowyk](https://togithub.com/piaskowyk) in [software-mansion/react-native-reanimated#6010 - Make `useScrollviewOffset` ref nullable and simplify its code by [@​szydlovsky](https://togithub.com/szydlovsky) in [software-mansion/react-native-reanimated#6009 - fix: use proper classes for bridgeless by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-reanimated#5997 - docs: add [@​swmansion/t-rex-ui](https://togithub.com/swmansion/t-rex-ui) by [@​patrycjakalinska](https://togithub.com/patrycjakalinska) in [software-mansion/react-native-reanimated#6015 - Remove `CellRendererComponent` from Animated.FlatList props by [@​Latropos](https://togithub.com/Latropos) in [software-mansion/react-native-reanimated#5951 - Add `useComposedEventHandler` hook by [@​szydlovsky](https://togithub.com/szydlovsky) in [software-mansion/react-native-reanimated#5890 - Align handling colors with RN by [@​maciekstosio](https://togithub.com/maciekstosio) in [software-mansion/react-native-reanimated#5825 - Add more tests - useSharedValue, useAnimatedStyle , useDerivedValue by [@​Latropos](https://togithub.com/Latropos) in [software-mansion/react-native-reanimated#5981 - Make animation RollInLeft work with modifers by [@​Latropos](https://togithub.com/Latropos) in [software-mansion/react-native-reanimated#6039 - Test predefined entering animation by [@​Latropos](https://togithub.com/Latropos) in [software-mansion/react-native-reanimated#5995 - Tests: cancelAnimation, useFrameCallback, measure, withDecay by [@​Latropos](https://togithub.com/Latropos) in [software-mansion/react-native-reanimated#6016 - docs: fix useAnimatedKeyboard page crash by [@​patrycjakalinska](https://togithub.com/patrycjakalinska) in [software-mansion/react-native-reanimated#6056 - \[Web LA] Remove `existingTransform` by [@​m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-reanimated#6060 #### New Contributors [@​antFrancon](https://togithub.com/antFrancon), [@​JDMathew](https://togithub.com/JDMathew), [@​thomas-rx](https://togithub.com/thomas-rx), [@​exploIF](https://togithub.com/exploIF) #### 🙌 Thank you for your contributions! **Full Changelog**: software-mansion/react-native-reanimated@3.11.0...3.12.0 Package build: https://github.com/software-mansion/react-native-reanimated/actions/runs/9287839734 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/GSTJ/react-native-magic-modal). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Thanks to @lukmccall we discovered that on bridgeless mode invoking
getReactInstanceManagercreates another instance of application. This PR makes it behave correctly there.Test plan
Run application and see that without this code, on bridgeless, there is no additional button in dev menu since it is created and the button is added in another instance.