Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: throw error when failed to find fragment for react root view #1562

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Aug 18, 2022

Description

Changes introduced in #1553 in case of FragmentManager.findFragment method throwing an exception could lead to some hard to debug behaviour. Now in case something goes wrong, we will get clear error message.

Changes

Code responsible for resolving FragmentManager when React Native is loaded of fragment now throws uncaught exception.

Test code and steps to reproduce

See #1553 and #1506

Checklist

@kkafar kkafar marked this pull request as ready for review August 19, 2022 06:56
@kkafar kkafar merged commit 7b69f8c into main Aug 19, 2022
@kkafar kkafar deleted the @kkafar/throw-exception-fragment-not-found branch August 19, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant