Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump library native Android deps & config #1891

Merged
merged 17 commits into from
Sep 26, 2023

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Sep 14, 2023

Description

Won't merge it RN as recent versions of these libraries require sdk >= 33 while current RN setup (clean app) requires >= 31.

While the statement above holds true new context emerged: since August 2023 all Android apps have to target sdk >= 33 (link)

Thus this should not be a problem.

Changes

  • Bumped default Kotlin version to 1.8.22 in example apps
  • Bumped default Kotlin version to 1.8.0 in lib (this aligns it with RN 0.73 template)
  • Bumped default target & compile target to 34 (notice that this is the default value used by the library, this can be overriden by user in application build.gradle)
  • Bumped series of lib depenencies (Android ones) to decently recent versions.

Test code and steps to reproduce

Ci works

Checklist

  • Ensured that CI passes

@kkafar kkafar merged commit a87885b into main Sep 26, 2023
7 checks passed
@kkafar kkafar deleted the @kkafar/bump-library-kotlin-and-deps branch September 26, 2023 08:53
@kkafar kkafar mentioned this pull request Sep 30, 2023
1 task
kkafar added a commit that referenced this pull request Oct 23, 2023
## Description

So I've recently bumped versions of few native library dependencies in
#1891, but
it also bumped some transitive dependencies that conflicted with lower
versions that are required by packages such as `gesture-handler`,
`reanimated`, `safe-area-context` etc.
I'm downgrading the versions as much I as can while also keeping
possible high `material` version.

## Test code and steps to reproduce

I downgraded kotlin to `1.6.21` in TestsExample && tested the build.

## Checklist

- [ ] Ensured that CI passes
renovate bot added a commit to valora-inc/wallet that referenced this pull request Nov 2, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-screens](https://togithub.com/software-mansion/react-native-screens)
| [`^3.25.0` ->
`^3.26.0`](https://renovatebot.com/diffs/npm/react-native-screens/3.25.0/3.26.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-screens/3.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-screens/3.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-screens/3.25.0/3.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-screens/3.25.0/3.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-screens
(react-native-screens)</summary>

###
[`v3.26.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.26.0)

[Compare
Source](https://togithub.com/software-mansion/react-native-screens/compare/3.25.0...3.26.0)

Minor release adding new useAnimatedHeaderHeight and
useReanimatedHeaderHeight hooks, providing fixes for search bar and
introducing internal changes. *Please note that new hooks introduced in
this release are fully functional on Paper, on Fabric there are few edge
cases we are still working on*.

#### What's Changed

#### 🐛 Bug fixes

- Change implementation of `headerConfig` prop on Android by
[@&#8203;tboba](https://togithub.com/tboba) in
[software-mansion/react-native-screens#1883
- Change elements visibility on search bar open by
[@&#8203;tboba](https://togithub.com/tboba) in
[software-mansion/react-native-screens#1903
- Fix positioning of large header and search bar by
[@&#8203;tboba](https://togithub.com/tboba) in
[software-mansion/react-native-screens#1895
- Change implementation of calculating status bar, refactor methods used
on header height change by [@&#8203;tboba](https://togithub.com/tboba)
in
[software-mansion/react-native-screens#1917
- Fix calculating header height when changing status/action bar
visibility by [@&#8203;tboba](https://togithub.com/tboba) in
[software-mansion/react-native-screens#1922
- Allow Reanimated Screen to check large header by
[@&#8203;tboba](https://togithub.com/tboba) in
[software-mansion/react-native-screens#1915
- Fix issue when emptying nav stack on Windows by
[@&#8203;chrisglein](https://togithub.com/chrisglein) in
[software-mansion/react-native-screens#1890
- Update podspec to use install_modules_dependencies by
[@&#8203;cipolleschi](https://togithub.com/cipolleschi) in
[software-mansion/react-native-screens#1920
- Remove MaxPerm args from JVM invocation by
[@&#8203;kkafar](https://togithub.com/kkafar) in
[software-mansion/react-native-screens#1888

#### 👍 Improvements

- Calculate values of useHeaderHeight natively by
[@&#8203;tboba](https://togithub.com/tboba) in
[software-mansion/react-native-screens#1802
- Allow for different fragment types inside ScreenContainer by
[@&#8203;kkafar](https://togithub.com/kkafar) in
[software-mansion/react-native-screens#1887
- Add focused states on page transitions by
[@&#8203;tboba](https://togithub.com/tboba) in
[software-mansion/react-native-screens#1894

#### 🔢 Miscellaneous

- **Create FUNDING.yml by
[@&#8203;aleqsio](https://togithub.com/aleqsio) in
[software-mansion/react-native-screens#1886
- Migrate from deprecated `RCTEventEmitter` by
[@&#8203;kkafar](https://togithub.com/kkafar) in
[software-mansion/react-native-screens#1867
- Use `require` syntax for resolution of all native components by
[@&#8203;kkafar](https://togithub.com/kkafar) in
[software-mansion/react-native-screens#1909
- Run Android e2e with JDK 17 by
[@&#8203;kkafar](https://togithub.com/kkafar) in
[software-mansion/react-native-screens#1892
- Put timelimit on execution of each workflow by
[@&#8203;kkafar](https://togithub.com/kkafar) in
[software-mansion/react-native-screens#1893
- Trigger e2e tests on JS-only changes by
[@&#8203;kkafar](https://togithub.com/kkafar) in
[software-mansion/react-native-screens#1910
- Update deprecated expo install instructions to `npx expo install` by
[@&#8203;GabrieldosSantosOliveira](https://togithub.com/GabrieldosSantosOliveira)
in
[software-mansion/react-native-screens#1899
- Bump activesupport from 6.1.7.3 to 7.0.7.2 in /TestsExample by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[software-mansion/react-native-screens#1877
- Update deps & RN in example apps after release by
[@&#8203;kkafar](https://togithub.com/kkafar) in
[software-mansion/react-native-screens#1878
- Migrate `Example` app & e2e tests to RN 0.72.4 by
[@&#8203;kkafar](https://togithub.com/kkafar) in
[software-mansion/react-native-screens#1880
- Bump library deps to recent versions (including RN) by
[@&#8203;kkafar](https://togithub.com/kkafar) in
[software-mansion/react-native-screens#1881
- Bump library native Android deps & config by
[@&#8203;kkafar](https://togithub.com/kkafar) in
[software-mansion/react-native-screens#1891

#### New Contributors

- [@&#8203;chrisglein](https://togithub.com/chrisglein) made their first
contribution in
[software-mansion/react-native-screens#1890
-
[@&#8203;GabrieldosSantosOliveira](https://togithub.com/GabrieldosSantosOliveira)
made their first contribution in
[software-mansion/react-native-screens#1899
- [@&#8203;cipolleschi](https://togithub.com/cipolleschi) made their
first contribution in
[software-mansion/react-native-screens#1920

**Full Changelog**:
software-mansion/react-native-screens@3.25.0...3.26.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
Co-authored-by: Silas Boyd-Wickizer <silasbw@gmail.com>
Co-authored-by: Silas Boyd-Wickizer <silas@valora.xyz>
mccoyplayer pushed a commit to mccoyplayer/reactScreen that referenced this pull request Feb 9, 2024
## Description

So I've recently bumped versions of few native library dependencies in
software-mansion/react-native-screens#1891, but
it also bumped some transitive dependencies that conflicted with lower
versions that are required by packages such as `gesture-handler`,
`reanimated`, `safe-area-context` etc.
I'm downgrading the versions as much I as can while also keeping
possible high `material` version.

## Test code and steps to reproduce

I downgraded kotlin to `1.6.21` in TestsExample && tested the build.

## Checklist

- [ ] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant