fix(Android): Change elements visibility on search bar open

[tboba]

Description

Currently, when user opens the search bar all of the subviews on the toolbar are being pushed to the left.
Instead, we want to hide them or even remove them so that they won't be visible during the layout.
This PR fixes that problem by secretly hiding the toolbar elements, changing their visibility to GONE.

Fixes #1450.

Changes

• Added a fix that is being controlled by handleOpen and handleClose methods in SearchBarView.

Screenshots / GIFs

Before

Before.mov

After

After.mov

Test code and steps to reproduce

In our example app open SearchBar.tsx and add headerRight: () => <Button title="Test"/> to the navigation.setOptions({declaration. Then launch the app and openSearch bar` example.

Checklist

• Ensured that CI passes

[WoLewicki]

Is there a possibility that this won't be fired, for example is we navigated when the search bar was open?

[tboba]

@WoLewicki I thought about that already and I'm unable to reproduce the scenario where the user comes back from the search bar and in the same action comes to the previous screen. Is it even possible? 🤔

Screen.Recording.2023-09-29.at.13.21.50.mov

To test this I've changed the logic of handleClose to change the visibility of elements to INVISIBLE - that's why the element on the current screen hides.

[tboba]

So, I figured out how to do that (I'm calling navigation.navigate('Main') on onClose) and it's doing fine!

Screen.Recording.2023-09-29.at.13.53.02.mov

[WoLewicki]

I think a better example would be to navigate forward and see what happens when you go back.

[tboba]

Do you mean navigation forward without opening the search bar? If so, then nothing would happen - state of the header subviews is only being changed on open and close searchBar events. If you mean that I should navigate forward, open the search bar and try to close it with trying to go back with back button, then (as seen above):

1. The keyboard will close,
2. The search bar will close,
3. User will return to previous screen.

So it shouldn't hide, as it's not possible to return to the previous screen without closing the search bar, I guess.

[tboba]

@WoLewicki So I've checked the scenario that you've suggested and looks like everything still works - I can't manage to have search bar closed when I'm going to the next screen and coming to the previous one.

8mb.video-bqT-PgqBQjkb.mp4

I'm still thinking if changing the visibility of the element could still break at some point. Do you think we should correct the change just to make sure that we will avoid side-effects?

[WoLewicki]

I think it would be some weird edge case and we can leave it as it is for now, and if the issues arise in the future, we will fix it then.

[WoLewicki]

I left one comment, please answer it. Other than that, LGTM 🚀

[kkafar]

Hey, GJ overall.
Left single comment.

[kkafar]

🟢