feat(iOS): Add `slide_from_left` transition #2057

kirillzyusko · 2024-03-05T17:16:51Z

Description

Before slide_from_left transition was resolved to default transition on iOS. Now this transition will make screen to appear from left side to right.

Changes

updated docs;
added RNSScreenStackAnimationSlideFromLeft to enum value;
added animateSlideFromLeftWithTransitionContext method;
added support for reverse gestures (from right to left to close a screen);

Screenshots / GIFs

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-05.at.17.44.39.mp4

Test code and steps to reproduce

Open Animations screen
select slide_from_left animation
open "New screen"
if you want to test gesture for dismissing the screen, you'll need to specify <Stack.Screen name="Screen" options={{ customAnimationOnSwipe: true }}>

Checklist

Included code example that can be used to test this change
Updated TS types
Updated documentation:
Ensured that CI passes

kirillzyusko · 2024-03-06T09:20:38Z

@tboba I see android build can not be created due to heap size - I don't know if increasing heap size in gradle properties will help or we should simply switch to macos-14 machine that offers more space and resources by default?

Anyway this failure is not because of my changes, since I modified only iOS part 😅

tboba · 2024-03-06T09:23:35Z

@kirillzyusko Yep, you're right - in Screens we have some E2E test case that randomly fails, because of the event when user clicks back button 😅
Thanks for the contribution! Let me quickly check those changes.

tboba

Just left some small comments there. Great job!

ios/RNSConvert.mm

tboba · 2024-03-06T09:44:00Z

ios/RNSScreenStack.mm

+          (topScreen.stackAnimation == RNSScreenStackAnimationSlideFromLeft &&
+           ((RNSScreenEdgeGestureRecognizer *)gestureRecognizer).edges == UIRectEdgeRight) ||


Why is this needed? I can't see any issues on RTL mode with and without this case 🤔

@tboba this is needed to activate the gesture from the right side if "slide_from_left" transition is used.

But I guess this condition needs to be slightly modified to support gesture from left side if RTL is active, right?

Yeah, probably it needs to be modified, since on RTL, the default behavior to dismiss the screen is to swipe from the right side, but unfortunately I can't make the reversed slide work 🤔 For some reason, I can still dismiss that screen from the left side. Does it work for you?

8mb.video-TVO-VuQVHAmi.mp4

Yeah, probably it needs to be modified, since on RTL, the default behavior to dismiss the screen is to swipe from the right side, but unfortunately I can't make the reversed slide work 🤔

@tboba I think in normal mode (not RTL) if "slide_from_left" is specified, then the gesture to dismiss should be "right_to_left".

If RTL is active, then we reverse everything - so "slide_from_left" will actually move screen from right to left (as default iOS transition) and the gesture for dismissing should be from left corner (saying shorter - if RTL + "slide_from_left" is specified, then it should work as usual/default iOS transition, because it's kind of double inversion).

Is my understanding correct?

On your video - did you specify customAnimationOnSwipe property? Because without this property you're right - the gesture to close should start from left corner and should have default transition (even if custom transition was specified).

On your video - did you specify customAnimationOnSwipe property?

I'm asking because this condition can be executed only if customAnimationOnSwipe specified.

// Now we're dealing with RNSScreenEdgeGestureRecognizer (or _UIParallaxTransitionPanGestureRecognizer) if (topScreen.customAnimationOnSwipe && [RNSScreenStackAnimator isCustomAnimation:topScreen.stackAnimation]) {

@tboba I re-worked this condition according to my comment - feel free to test it 🙌

I also added named variables to simplify condition and made it more readable 😊

Great, I'll try to test them today! Thanks 🙌

If RTL is active, then we reverse everything - so "slide_from_left" will actually move screen from right to left (as default iOS transition) and the gesture for dismissing should be from left corner (saying shorter - if RTL + "slide_from_left" is specified, then it should work as usual/default iOS transition, because it's kind of double inversion).

Yep, you're right - currently, the default animation comes from the right side to the left and is rotated when user is in RTL mode - I think in slide_to_left transition it should be opposite!
I also forgot about the customAnimationOnSwipe prop 😅 I'll check it out 👍

kirillzyusko · 2024-03-07T08:08:00Z

@tboba tests are failing because ANR popup is shown:

I think if you want to make your tests more reliable you should follow this guide https://wix.github.io/Detox/docs/19.x/introduction/android/#8-test-butler-support-optional

I added it my RNKC package and Android tests are more stable now than iOS 😂 Let me know if you need my help - I can try to submit a PR with a fix 👀

tboba · 2024-03-08T09:24:46Z

@kirillzyusko Yeah, sure! I didn't know about a Test Butler yet, so if you think this may help our CIs, and you have some free time, then why not 🙌

kirillzyusko · 2024-03-08T11:13:40Z

@tboba cool, will handle it in separate PR then 👀

tboba · 2024-03-18T14:15:19Z

@kirillzyusko Since PR with CI is already merged, could you merge main to this PR? 🙏

…ition

kirillzyusko · 2024-03-18T14:24:31Z

Since PR with CI is already merged, could you merge main to this PR? 🙏

@tboba just rebased it 👀

tboba

LGTM! Great work 🎉

## Description Before `slide_from_left` transition was resolved to default transition on iOS. Now this transition will make screen to appear from left side to right. ## Changes - updated docs; - added `RNSScreenStackAnimationSlideFromLeft` to enum value; - added `animateSlideFromLeftWithTransitionContext` method; - added support for reverse gestures (from right to left to close a screen); ## Screenshots / GIFs https://github.com/software-mansion/react-native-screens/assets/22820318/e0a71147-0aea-47ef-9d4b-319d7fd8dd81 ## Test code and steps to reproduce - Open `Animations` screen - select `slide_from_left` animation - open "New screen" - if you want to test gesture for dismissing the screen, you'll need to specify `<Stack.Screen name="Screen" options={{ customAnimationOnSwipe: true }}>` ## Checklist - [x] Included code example that can be used to test this change - [x] Updated TS types - [x] Updated documentation:  - [x] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [x] Ensured that CI passes

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-screens](https://togithub.com/software-mansion/react-native-screens) | [`^3.29.0` -> `^3.30.1`](https://renovatebot.com/diffs/npm/react-native-screens/3.29.0/3.30.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-screens/3.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-screens/3.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-screens/3.29.0/3.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-screens/3.29.0/3.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-screens (react-native-screens)</summary> ### [`v3.30.1`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.30.1) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.30.0...3.30.1) Patch release addressing an issue with building a package due to the missing submodule from `postinstall` command. #### 🔢 Miscellaneous - Remove postinstall step from package.json by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2081 **Full Changelog**: software-mansion/react-native-screens@3.30.0...3.30.1 ### [`v3.30.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.30.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.29.0...3.30.0) Minor release including custom screen transitions, adding support for VisionOS, supporting `slide_from_left` animation on iOS and fixing other aspects (including wrong targets for touchable components on Fabric). Thanks for following along! 💙 **Note**: Please note that support for React Native versions lower than 0.68 have been **dropped**. Older versions may still continue to work with this and newer releases of react-native-screens, but bugs from deprecated versions will not be considered for repair. #### What's Changed #### 👍 Improvements - **Custom screen transitions** - In 3.30.0, we've introduced a support for custom transition animations while making a "go back" gesture. Made by [@piaskowyk](https://togithub.com/piaskowyk) and [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-screens#1913 - **Support for VisionOS is here!** - From now, react-native-screens offers bundled support for VisionOS platform. Made by [@okwasniewski](https://togithub.com/okwasniewski) in [software-mansion/react-native-screens#2025 - **`slide_from_left` transition on iOS** - You can use `slide_from_left` animation that will be used for pushing or popping a new screen. Made by [@kirillzyusko](https://togithub.com/kirillzyusko) in [software-mansion/react-native-screens#2057 - Add `cancelSearch` command on SearchBar by [@Jasonzj](https://togithub.com/Jasonzj) in [software-mansion/react-native-screens#1987 - Fixed Android screen stack animation by [@janicduplessis](https://togithub.com/janicduplessis) in [software-mansion/react-native-screens#2019 #### 🐛 Bug fixes - Not working hitslop for headerRight/Left views by [@kkafar](https://togithub.com/kkafar) in [software-mansion/react-native-screens#1995 - App freeze when navigating back from any modal nested in contained modal by [@kkafar](https://togithub.com/kkafar) in [software-mansion/react-native-screens#1996 - Incorrect safe area on transparent modals using landscape orientation by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2008 - Invalid orientation of contained modals by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2011 - Modify the decorFitsSystemWindow parameter in setNavigationBarHidden by [@jiyong1](https://togithub.com/jiyong1) in [software-mansion/react-native-screens#1988 - Avoid race condition related to state on the new arch by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-screens#2024 - Check for multiple screens while changing screen orientation by [@uzegonemad](https://togithub.com/uzegonemad) in [software-mansion/react-native-screens#2035 - Fix setting incorrect measure with native header by [@WoLewicki](https://togithub.com/WoLewicki) and [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2028 - Add notifying for header height change, fix header height values by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2075 - Change context while running `runOnUiQueueThread` on 0.73 with Bridgeless by [@cortinico](https://togithub.com/cortinico) in [software-mansion/react-native-screens#2022 - Use reactApplicationContext in onScreenChanged by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-screens#2046 - Remove calculating status bar height in useAnimatedHeaderHeight when header is not shown by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2033 - Handle setting `display` for `_viewConfig` attribute by [@WoLewicki](https://togithub.com/WoLewicki) and [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2071 - Fix crash with searchResultsController in RNSSearchBar by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2004 - Add constraints for velocity in `goBackGesture` screen transition by [@piaskowyk](https://togithub.com/piaskowyk) in [software-mansion/react-native-screens#2061 - Add view check for getting StackView in `goBackGesture` by [@piaskowyk](https://togithub.com/piaskowyk) in [software-mansion/react-native-screens#2060 - Change default value of context of ScreenGestureDetector, add warning for goBackGesture by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2013 - Move GHContext from gesture-handler to native-stack by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2017 - Change default gesture from Tap to Fling, fix failing CI by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2023 #### 🔢 Miscellaneous - **Drop React Native 0.64 - 0.67 since 3.30.0** by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2036 - Remove mixed CJS/ESM, refactorize index.native.tsx by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#1982 - Add react-navigation as submodule & use it in test applications by [@kkafar](https://togithub.com/kkafar) and [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#1993 - Unify member-field naming convention in Kotlin by [@kkafar](https://togithub.com/kkafar) in [software-mansion/react-native-screens#1999 - Update compatibility table with supported RN versions with Fabric by [@kkafar](https://togithub.com/kkafar) in [software-mansion/react-native-screens#2001 - Change name of `headerBackButtonClicked` event by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-screens#2015 - Stabilize Android E2E tests by [@kirillzyusko](https://togithub.com/kirillzyusko) in [software-mansion/react-native-screens#2062 - Update Podfiles in Example projects, update RN in FabricExample to 0.73 by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#1989 - Update React Native to 0.73.4, change Cocoapods version by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2032 - Configure yarn version in package.json by [@bakkerjoeri](https://togithub.com/bakkerjoeri) in [software-mansion/react-native-screens#2077 - Bump ip from 1.1.8 to 1.1.9 by [@dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-screens#2038 - Bump ip from 1.1.8 to 1.1.9 in example apps by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2044 #### New Contributors - [@jiyong1](https://togithub.com/jiyong1) made their first contribution in [software-mansion/react-native-screens#1988 - [@Jasonzj](https://togithub.com/Jasonzj) made their first contribution in [software-mansion/react-native-screens#1987 - [@j-piasecki](https://togithub.com/j-piasecki) made their first contribution in [software-mansion/react-native-screens#2024 - [@cortinico](https://togithub.com/cortinico) made their first contribution in [software-mansion/react-native-screens#2022 - [@okwasniewski](https://togithub.com/okwasniewski) made their first contribution in [software-mansion/react-native-screens#2025 - [@uzegonemad](https://togithub.com/uzegonemad) made their first contribution in [software-mansion/react-native-screens#2035 - [@bakkerjoeri](https://togithub.com/bakkerjoeri) made their first contribution in [software-mansion/react-native-screens#2077 #### 🙌 Thank you for your contributions! **Full Changelog**: software-mansion/react-native-screens@3.29.0...3.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>

…inc#5239) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-screens](https://togithub.com/software-mansion/react-native-screens) | [`^3.29.0` -> `^3.30.1`](https://renovatebot.com/diffs/npm/react-native-screens/3.29.0/3.30.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-screens/3.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-screens/3.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-screens/3.29.0/3.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-screens/3.29.0/3.30.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-screens (react-native-screens)</summary> ### [`v3.30.1`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.30.1) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.30.0...3.30.1) Patch release addressing an issue with building a package due to the missing submodule from `postinstall` command. #### 🔢 Miscellaneous - Remove postinstall step from package.json by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2081 **Full Changelog**: software-mansion/react-native-screens@3.30.0...3.30.1 ### [`v3.30.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.30.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.29.0...3.30.0) Minor release including custom screen transitions, adding support for VisionOS, supporting `slide_from_left` animation on iOS and fixing other aspects (including wrong targets for touchable components on Fabric). Thanks for following along! 💙 **Note**: Please note that support for React Native versions lower than 0.68 have been **dropped**. Older versions may still continue to work with this and newer releases of react-native-screens, but bugs from deprecated versions will not be considered for repair. #### What's Changed #### 👍 Improvements - **Custom screen transitions** - In 3.30.0, we've introduced a support for custom transition animations while making a "go back" gesture. Made by [@piaskowyk](https://togithub.com/piaskowyk) and [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-screens#1913 - **Support for VisionOS is here!** - From now, react-native-screens offers bundled support for VisionOS platform. Made by [@okwasniewski](https://togithub.com/okwasniewski) in [software-mansion/react-native-screens#2025 - **`slide_from_left` transition on iOS** - You can use `slide_from_left` animation that will be used for pushing or popping a new screen. Made by [@kirillzyusko](https://togithub.com/kirillzyusko) in [software-mansion/react-native-screens#2057 - Add `cancelSearch` command on SearchBar by [@Jasonzj](https://togithub.com/Jasonzj) in [software-mansion/react-native-screens#1987 - Fixed Android screen stack animation by [@janicduplessis](https://togithub.com/janicduplessis) in [software-mansion/react-native-screens#2019 #### 🐛 Bug fixes - Not working hitslop for headerRight/Left views by [@kkafar](https://togithub.com/kkafar) in [software-mansion/react-native-screens#1995 - App freeze when navigating back from any modal nested in contained modal by [@kkafar](https://togithub.com/kkafar) in [software-mansion/react-native-screens#1996 - Incorrect safe area on transparent modals using landscape orientation by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2008 - Invalid orientation of contained modals by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2011 - Modify the decorFitsSystemWindow parameter in setNavigationBarHidden by [@jiyong1](https://togithub.com/jiyong1) in [software-mansion/react-native-screens#1988 - Avoid race condition related to state on the new arch by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-screens#2024 - Check for multiple screens while changing screen orientation by [@uzegonemad](https://togithub.com/uzegonemad) in [software-mansion/react-native-screens#2035 - Fix setting incorrect measure with native header by [@WoLewicki](https://togithub.com/WoLewicki) and [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2028 - Add notifying for header height change, fix header height values by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2075 - Change context while running `runOnUiQueueThread` on 0.73 with Bridgeless by [@cortinico](https://togithub.com/cortinico) in [software-mansion/react-native-screens#2022 - Use reactApplicationContext in onScreenChanged by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-screens#2046 - Remove calculating status bar height in useAnimatedHeaderHeight when header is not shown by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2033 - Handle setting `display` for `_viewConfig` attribute by [@WoLewicki](https://togithub.com/WoLewicki) and [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2071 - Fix crash with searchResultsController in RNSSearchBar by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2004 - Add constraints for velocity in `goBackGesture` screen transition by [@piaskowyk](https://togithub.com/piaskowyk) in [software-mansion/react-native-screens#2061 - Add view check for getting StackView in `goBackGesture` by [@piaskowyk](https://togithub.com/piaskowyk) in [software-mansion/react-native-screens#2060 - Change default value of context of ScreenGestureDetector, add warning for goBackGesture by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2013 - Move GHContext from gesture-handler to native-stack by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2017 - Change default gesture from Tap to Fling, fix failing CI by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2023 #### 🔢 Miscellaneous - **Drop React Native 0.64 - 0.67 since 3.30.0** by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2036 - Remove mixed CJS/ESM, refactorize index.native.tsx by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#1982 - Add react-navigation as submodule & use it in test applications by [@kkafar](https://togithub.com/kkafar) and [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#1993 - Unify member-field naming convention in Kotlin by [@kkafar](https://togithub.com/kkafar) in [software-mansion/react-native-screens#1999 - Update compatibility table with supported RN versions with Fabric by [@kkafar](https://togithub.com/kkafar) in [software-mansion/react-native-screens#2001 - Change name of `headerBackButtonClicked` event by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-screens#2015 - Stabilize Android E2E tests by [@kirillzyusko](https://togithub.com/kirillzyusko) in [software-mansion/react-native-screens#2062 - Update Podfiles in Example projects, update RN in FabricExample to 0.73 by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#1989 - Update React Native to 0.73.4, change Cocoapods version by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2032 - Configure yarn version in package.json by [@bakkerjoeri](https://togithub.com/bakkerjoeri) in [software-mansion/react-native-screens#2077 - Bump ip from 1.1.8 to 1.1.9 by [@dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-screens#2038 - Bump ip from 1.1.8 to 1.1.9 in example apps by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2044 #### New Contributors - [@jiyong1](https://togithub.com/jiyong1) made their first contribution in [software-mansion/react-native-screens#1988 - [@Jasonzj](https://togithub.com/Jasonzj) made their first contribution in [software-mansion/react-native-screens#1987 - [@j-piasecki](https://togithub.com/j-piasecki) made their first contribution in [software-mansion/react-native-screens#2024 - [@cortinico](https://togithub.com/cortinico) made their first contribution in [software-mansion/react-native-screens#2022 - [@okwasniewski](https://togithub.com/okwasniewski) made their first contribution in [software-mansion/react-native-screens#2025 - [@uzegonemad](https://togithub.com/uzegonemad) made their first contribution in [software-mansion/react-native-screens#2035 - [@bakkerjoeri](https://togithub.com/bakkerjoeri) made their first contribution in [software-mansion/react-native-screens#2077 #### 🙌 Thank you for your contributions! **Full Changelog**: software-mansion/react-native-screens@3.29.0...3.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>

tboba changed the title ~~feat: slide_from_left on iOS~~ feat(iOS): Add slide_from_left transition Mar 6, 2024

tboba requested changes Mar 6, 2024

View reviewed changes

kirillzyusko mentioned this pull request Mar 12, 2024

[HOLD RN0.74] [WIP] perf: native-stack (v2) Expensify/App#37891

Open

48 tasks

kirillzyusko added 4 commits March 18, 2024 15:23

feat: slide_from_left on iOS

ddefa93

docs: update info that slide_from_left is not Android specific anymore

34cc36b

fix: changes after code review

0b9e0ab

fix: keep RTL in consideration for gestures and slide_from_left trans…

ce5dc7d

…ition

kirillzyusko force-pushed the feat/slide-from-left-on-ios branch from 1deddf8 to ce5dc7d Compare March 18, 2024 14:23

tboba approved these changes Mar 22, 2024

View reviewed changes

tboba merged commit d737d72 into software-mansion:main Mar 22, 2024
6 checks passed

This was referenced May 19, 2024

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.31.1 shonore/Fickle#1382

Open

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.31.1 shonore/Fickle#1387

Open

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.31.1 shonore/Fickle#1392

Open

ColeCoffman mentioned this pull request May 21, 2024

[Snyk] Upgrade react-native-screens from 3.10.2 to 3.31.1 ColeCoffman/JBApp#89

Open

This was referenced May 22, 2024

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.31.1 shonore/Fickle#1397

Open

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.31.1 shonore/Fickle#1402

Open

DAVAS110 mentioned this pull request May 24, 2024

[Snyk] Upgrade react-native-screens from 3.20.0 to 3.31.1 DAVAS110/MyPlant#40

Open

developer-ayan mentioned this pull request May 24, 2024

[Snyk] Upgrade react-native-screens from 3.8.0 to 3.31.1 developer-ayan/Heka-With-Animtion-Graph#199

Open

shonore mentioned this pull request May 25, 2024

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.31.1 shonore/Fickle#1407

Open

ColeCoffman mentioned this pull request May 25, 2024

[Snyk] Upgrade react-native-screens from 3.10.2 to 3.31.1 ColeCoffman/JBApp#94

Open

2lambda123 mentioned this pull request May 25, 2024

[Snyk] Upgrade react-native-screens from 3.10.2 to 3.31.1 2lambda123/abp#87

Merged

This was referenced Jun 10, 2024

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.31.1 shonore/Fickle#1487

Open

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.31.1 shonore/Fickle#1492

Open

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.31.1 shonore/Fickle#1497

Open

KarthikeshS mentioned this pull request Jun 13, 2024

[Snyk] Upgrade react-native-screens from 3.8.0 to 3.31.1 KarthikeshS/own-app#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(iOS): Add `slide_from_left` transition #2057

feat(iOS): Add `slide_from_left` transition #2057

kirillzyusko commented Mar 5, 2024 •

edited

kirillzyusko commented Mar 6, 2024

tboba commented Mar 6, 2024

tboba left a comment

tboba Mar 6, 2024

kirillzyusko Mar 6, 2024

tboba Mar 6, 2024

kirillzyusko Mar 6, 2024

kirillzyusko Mar 6, 2024

kirillzyusko Mar 6, 2024

tboba Mar 6, 2024 •

edited

kirillzyusko commented Mar 7, 2024

tboba commented Mar 8, 2024

kirillzyusko commented Mar 8, 2024

tboba commented Mar 18, 2024

kirillzyusko commented Mar 18, 2024

tboba left a comment

		(topScreen.stackAnimation == RNSScreenStackAnimationSlideFromLeft &&
		((RNSScreenEdgeGestureRecognizer *)gestureRecognizer).edges == UIRectEdgeRight) \|\|

feat(iOS): Add slide_from_left transition #2057

feat(iOS): Add slide_from_left transition #2057

Conversation

kirillzyusko commented Mar 5, 2024 • edited

Description

Changes

Screenshots / GIFs

Test code and steps to reproduce

Checklist

kirillzyusko commented Mar 6, 2024

tboba commented Mar 6, 2024

tboba left a comment

Choose a reason for hiding this comment

tboba Mar 6, 2024

Choose a reason for hiding this comment

kirillzyusko Mar 6, 2024

Choose a reason for hiding this comment

tboba Mar 6, 2024

Choose a reason for hiding this comment

kirillzyusko Mar 6, 2024

Choose a reason for hiding this comment

kirillzyusko Mar 6, 2024

Choose a reason for hiding this comment

kirillzyusko Mar 6, 2024

Choose a reason for hiding this comment

tboba Mar 6, 2024 • edited

Choose a reason for hiding this comment

kirillzyusko commented Mar 7, 2024

tboba commented Mar 8, 2024

kirillzyusko commented Mar 8, 2024

tboba commented Mar 18, 2024

kirillzyusko commented Mar 18, 2024

tboba left a comment

Choose a reason for hiding this comment

feat(iOS): Add `slide_from_left` transition #2057

feat(iOS): Add `slide_from_left` transition #2057

kirillzyusko commented Mar 5, 2024 •

edited

tboba Mar 6, 2024 •

edited