fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. #2191

taenri · 2023-12-05T22:38:01Z

Summary

On Windows, RNSVG.dll is getting flagged by AppLocker on many of our user's devices because it is missing proper publisher/versioning information in its metadata. This forces users to manually add this DLL to AppLocker's allow-list during some update/installation scenarios.

The RNSVG.sln file also currently fails to build from Visual Studio directly, because the fmt project is not explicitly included from the react-native-windows Node package.

Test Plan

For testing, I opened RNSVG.sln in Visual Studio on Windows (with Node packages installed and other build prerequisites) and built it for Debug|x64.

Without my change, building the solution fails to build directly from Visual Studio (since it fails to link fmt.lib when building the Microsoft.ReactNative project). Even when building from the terminal using MSBuild, RNSVG.dll properties do not contain proper publisher/versioning details.

With my change, building the solution in Visual Studio succeeds and RNSVG.dll contains the correct publisher/versioning details in its properties. These can be viewed via File Explorer.

Note that the version constants defined in the versionoverrides.rc file will ideally need to be updated whenever the version tracked in package.json is updated. Further changes will be required to make versionoverrides.rc account for the package.json version automatically. This change is good enough to satisfy AppLocker requirements for now though.

Compatibility

OS	Implemented
iOS	❌
Android	❌
Windows	✅
MacOS	❌

Checklist

I have tested this on a device and a simulator
I added documentation in README.md
I updated the typed files (typescript)
I added a test for the API in the __tests__ folder

…roject.

WoLewicki · 2024-01-03T14:47:49Z

@marlenecota wdyt about this one?

marlenecota · 2024-01-12T00:58:33Z

@WoLewicki - looks good! thanks

taenri · 2024-01-24T18:23:36Z

@WoLewicki - Just curious, about when can we expect the next version update to be published?

WoLewicki · 2024-01-24T21:12:37Z

I haven't planned the release soon, but you can always get those changes with a patch-package to be able to use them in current version 🚀

taenri · 2024-01-24T22:03:29Z

I haven't planned the release soon, but you can always get those changes with a patch-package to be able to use them in current version 🚀

Wow, I have never heard of this before. Looks awesome, thanks for the tip!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://togithub.com/react-native-community/react-native-svg) | [`^13.14.0` -> `^15.2.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.14.0/15.2.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-svg/15.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-svg/15.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-svg/13.14.0/15.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-svg/13.14.0/15.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg (react-native-svg)</summary> ### [`v15.2.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.2.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.1.0...v15.2.0) Minor release adding support for RN 0.74 on New Architecture and introducing some bug fixes. Thank you for your contributions! #### What's Changed - feat: add needed changes for RN 0.74 by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2231 - Fix CMakeLists for Android by [@tjzel](https://togithub.com/tjzel) in [software-mansion/react-native-svg#2249 - Adds support to compile react-native-svg against WinAppSDK by [@rozele](https://togithub.com/rozele) in [software-mansion/react-native-svg#2255 - feat: bump RN to 0.74 in FabricExample and remove rea hacks by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2262 - feat: bump RN to 0.74 in Example by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2263 #### New Contributors - [@tjzel](https://togithub.com/tjzel) made their first contribution in [software-mansion/react-native-svg#2249 **Full Changelog**: software-mansion/react-native-svg@v15.1.0...v15.2.0 ### [`v15.1.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.1.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.0.0...v15.1.0) Minor release including proper support for `react-native-reanimated` to the library on new architecture by using `dynamic` values for codegen. ##### What's Changed - feat: use dynamics instead of strings for props that can be either string or number by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2238 **Full Changelog**: software-mansion/react-native-svg@v15.0.0...v15.1.0 ### [`v15.0.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.0.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v14.1.0...v15.0.0) Major release introducing support for visionOS 🎉, some bug fixes and a BREAKING CHANGE due to [software-mansion/react-native-svg#2232. If your app already supports `iOS` >= `12.4` then you can safely upgrade the version, otherwise, you have to bump it first. #### What's Changed - feat: add visionOS support by [@okwasniewski](https://togithub.com/okwasniewski) in [software-mansion/react-native-svg#2190 - fix: Correct types for transformsArrayToProps by [@crazyfraggle](https://togithub.com/crazyfraggle) in [software-mansion/react-native-svg#2193 - chore: bump examples to 0.73.1 by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2201 - Fix type exports and enable `isolatedModules` setting to catch it in `tsc` by [@renchap](https://togithub.com/renchap) in [software-mansion/react-native-svg#2197 - Fix crash when SVG is unloaded by XAML by [@rozele](https://togithub.com/rozele) in [software-mansion/react-native-svg#2195 - fix(SvgCssUri): support rendering fallback instead of crashing the app when loading invalid content from remote svg file by [@quangkcao](https://togithub.com/quangkcao) in [software-mansion/react-native-svg#2196 - fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. by [@taenri](https://togithub.com/taenri) in [software-mansion/react-native-svg#2191 - Update ios-build-test.yml by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2207 - fix: visionOS support by [@tomekzaw](https://togithub.com/tomekzaw) in [software-mansion/react-native-svg#2218 - fixed [@Deprecated](https://togithub.com/Deprecated) warning in React Native 0.73: 'com.facebook.react.common.StandardCharsets' is deprecated and marked for removal by [@coder-xiaomo](https://togithub.com/coder-xiaomo) in [software-mansion/react-native-svg#2208 - fix: typo on require statement (`WithLocalSvg`) by [@voidsatisfaction](https://togithub.com/voidsatisfaction) in [software-mansion/react-native-svg#2223 - fix: Add missing nan value checks for bounds size by [@MatiPl01](https://togithub.com/MatiPl01) in [software-mansion/react-native-svg#2220 - chore(deps): bump ip from 1.1.8 to 1.1.9 in /Example by [@dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-svg#2228 - feat: bump minimal ios version to 12.4 by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2232 #### New Contributors - [@okwasniewski](https://togithub.com/okwasniewski) made their first contribution in [software-mansion/react-native-svg#2190 - [@crazyfraggle](https://togithub.com/crazyfraggle) made their first contribution in [software-mansion/react-native-svg#2193 - [@quangkcao](https://togithub.com/quangkcao) made their first contribution in [software-mansion/react-native-svg#2196 - [@taenri](https://togithub.com/taenri) made their first contribution in [software-mansion/react-native-svg#2191 - [@coder-xiaomo](https://togithub.com/coder-xiaomo) made their first contribution in [software-mansion/react-native-svg#2208 - [@voidsatisfaction](https://togithub.com/voidsatisfaction) made their first contribution in [software-mansion/react-native-svg#2223 - [@MatiPl01](https://togithub.com/MatiPl01) made their first contribution in [software-mansion/react-native-svg#2220 **Full Changelog**: software-mansion/react-native-svg@v14.1.0...v15.0.0 ### [`v14.1.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v14.1.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v14.0.0...v14.1.0) Minor release adding support for RN 0.73 and fixing some bugs 🎉 Thank you for all your contributions! #### What's Changed - fix: remove unused header causing problems by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2175 - fix `SvgCssUri` fallback by [@myou11](https://togithub.com/myou11) in [software-mansion/react-native-svg#2171 - Minor fix to prevent crash when Loaded fires twice by [@rozele](https://togithub.com/rozele) in [software-mansion/react-native-svg#2180 - feat: add support for RN 73 by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2181 #### New Contributors - [@myou11](https://togithub.com/myou11) made their first contribution in [software-mansion/react-native-svg#2171 - [@rozele](https://togithub.com/rozele) made their first contribution in [software-mansion/react-native-svg#2180 **Full Changelog**: software-mansion/react-native-svg@v14.0.0...v14.1.0 ### [`v14.0.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v14.0.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.14.0...v14.0.0) Major release introducing some minor improvements and a ***BREAKING CHANGE***. From now on, you should import SvgCss, SvgCssUri, SvgWithCss, SvgWithCssUri, inlineStyles, LocalSvg, WithLocalSvg, loadLocalRawResource, from `react-native-svg/css` package instead. See [#2168](https://togithub.com/react-native-community/react-native-svg/issues/2168) for more information. #### What's Changed - enable buildConfig generation to better support AGP8 by [@pvegh](https://togithub.com/pvegh) in [software-mansion/react-native-svg#2143 - perf: avoid unnecessary shared_ptr copies in Fabric components by [@javache](https://togithub.com/javache) in [software-mansion/react-native-svg#2164 - fix: props are no longer unnecesarily copied in new architecture by [@javache](https://togithub.com/javache) in [software-mansion/react-native-svg#2163 - chore(deps): bump [@babel/traverse](https://togithub.com/babel/traverse) from 7.22.8 to 7.23.2 in /Example by [@dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-svg#2158 - Build `renderer/components/rnsvg` with `-std=c++20` by [@NickGerleman](https://togithub.com/NickGerleman) in [software-mansion/react-native-svg#2141 - chore: bump examples to rn 0.72.6 by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2166 - \[Windows] Port to Direct2D to remove win2d dependency by [@marlenecota](https://togithub.com/marlenecota) in [software-mansion/react-native-svg#2052 - feat: move css to different package for size reduction by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2168 #### New Contributors - [@pvegh](https://togithub.com/pvegh) made their first contribution in [software-mansion/react-native-svg#2143 - [@javache](https://togithub.com/javache) made their first contribution in [software-mansion/react-native-svg#2164 - [@NickGerleman](https://togithub.com/NickGerleman) made their first contribution in [software-mansion/react-native-svg#2141 **Full Changelog**: software-mansion/react-native-svg@v13.14.0...v14.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>

taenri added 2 commits December 5, 2023 16:30

Add basic versioning/publishing metadata resources to RNSVG windows p…

f1de7e2

…roject.

Fix React Native NodeJS project dependencies for RNSVG solution.

146cd28

taenri changed the title ~~Ensure RNSVG.dll is built with proper publisher/versioning information to satisfy AppLocker requirements.~~ Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. Dec 6, 2023

taenri changed the title ~~Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file.~~ fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. Dec 6, 2023

marlenecota approved these changes Jan 12, 2024

View reviewed changes

taenri closed this Jan 12, 2024

taenri reopened this Jan 12, 2024

WoLewicki merged commit a33cb31 into software-mansion:main Jan 15, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. #2191

fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. #2191

taenri commented Dec 5, 2023 •

edited

WoLewicki commented Jan 3, 2024

marlenecota commented Jan 12, 2024

taenri commented Jan 24, 2024

WoLewicki commented Jan 24, 2024

taenri commented Jan 24, 2024

fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. #2191

fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. #2191

Conversation

taenri commented Dec 5, 2023 • edited

Summary

Test Plan

Compatibility

Checklist

WoLewicki commented Jan 3, 2024

marlenecota commented Jan 12, 2024

taenri commented Jan 24, 2024

WoLewicki commented Jan 24, 2024

taenri commented Jan 24, 2024

taenri commented Dec 5, 2023 •

edited