Fix crash when SVG is unloaded by XAML #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAML may unload the root SVG panel, which will trigger a recursive unload. For GroupView, this unload will clear the child collection. However, active operations on the SVG from the React Native UIManager may still be in flight, in which case we may attempt to remove a child that has already been cleared by the root unload.
marlenecota
approved these changes
Dec 18, 2023
github-merge-queue bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
Apr 30, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://togithub.com/react-native-community/react-native-svg) | [`^13.14.0` -> `^15.2.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.14.0/15.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg (react-native-svg)</summary> ### [`v15.2.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.2.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.1.0...v15.2.0) Minor release adding support for RN 0.74 on New Architecture and introducing some bug fixes. Thank you for your contributions! #### What's Changed - feat: add needed changes for RN 0.74 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2231 - Fix CMakeLists for Android by [@​tjzel](https://togithub.com/tjzel) in [software-mansion/react-native-svg#2249 - Adds support to compile react-native-svg against WinAppSDK by [@​rozele](https://togithub.com/rozele) in [software-mansion/react-native-svg#2255 - feat: bump RN to 0.74 in FabricExample and remove rea hacks by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2262 - feat: bump RN to 0.74 in Example by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2263 #### New Contributors - [@​tjzel](https://togithub.com/tjzel) made their first contribution in [software-mansion/react-native-svg#2249 **Full Changelog**: software-mansion/react-native-svg@v15.1.0...v15.2.0 ### [`v15.1.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.1.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.0.0...v15.1.0) Minor release including proper support for `react-native-reanimated` to the library on new architecture by using `dynamic` values for codegen. ##### What's Changed - feat: use dynamics instead of strings for props that can be either string or number by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2238 **Full Changelog**: software-mansion/react-native-svg@v15.0.0...v15.1.0 ### [`v15.0.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.0.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v14.1.0...v15.0.0) Major release introducing support for visionOS 🎉, some bug fixes and a BREAKING CHANGE due to [software-mansion/react-native-svg#2232. If your app already supports `iOS` >= `12.4` then you can safely upgrade the version, otherwise, you have to bump it first. #### What's Changed - feat: add visionOS support by [@​okwasniewski](https://togithub.com/okwasniewski) in [software-mansion/react-native-svg#2190 - fix: Correct types for transformsArrayToProps by [@​crazyfraggle](https://togithub.com/crazyfraggle) in [software-mansion/react-native-svg#2193 - chore: bump examples to 0.73.1 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2201 - Fix type exports and enable `isolatedModules` setting to catch it in `tsc` by [@​renchap](https://togithub.com/renchap) in [software-mansion/react-native-svg#2197 - Fix crash when SVG is unloaded by XAML by [@​rozele](https://togithub.com/rozele) in [software-mansion/react-native-svg#2195 - fix(SvgCssUri): support rendering fallback instead of crashing the app when loading invalid content from remote svg file by [@​quangkcao](https://togithub.com/quangkcao) in [software-mansion/react-native-svg#2196 - fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. by [@​taenri](https://togithub.com/taenri) in [software-mansion/react-native-svg#2191 - Update ios-build-test.yml by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2207 - fix: visionOS support by [@​tomekzaw](https://togithub.com/tomekzaw) in [software-mansion/react-native-svg#2218 - fixed [@​Deprecated](https://togithub.com/Deprecated) warning in React Native 0.73: 'com.facebook.react.common.StandardCharsets' is deprecated and marked for removal by [@​coder-xiaomo](https://togithub.com/coder-xiaomo) in [software-mansion/react-native-svg#2208 - fix: typo on require statement (`WithLocalSvg`) by [@​voidsatisfaction](https://togithub.com/voidsatisfaction) in [software-mansion/react-native-svg#2223 - fix: Add missing nan value checks for bounds size by [@​MatiPl01](https://togithub.com/MatiPl01) in [software-mansion/react-native-svg#2220 - chore(deps): bump ip from 1.1.8 to 1.1.9 in /Example by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-svg#2228 - feat: bump minimal ios version to 12.4 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2232 #### New Contributors - [@​okwasniewski](https://togithub.com/okwasniewski) made their first contribution in [software-mansion/react-native-svg#2190 - [@​crazyfraggle](https://togithub.com/crazyfraggle) made their first contribution in [software-mansion/react-native-svg#2193 - [@​quangkcao](https://togithub.com/quangkcao) made their first contribution in [software-mansion/react-native-svg#2196 - [@​taenri](https://togithub.com/taenri) made their first contribution in [software-mansion/react-native-svg#2191 - [@​coder-xiaomo](https://togithub.com/coder-xiaomo) made their first contribution in [software-mansion/react-native-svg#2208 - [@​voidsatisfaction](https://togithub.com/voidsatisfaction) made their first contribution in [software-mansion/react-native-svg#2223 - [@​MatiPl01](https://togithub.com/MatiPl01) made their first contribution in [software-mansion/react-native-svg#2220 **Full Changelog**: software-mansion/react-native-svg@v14.1.0...v15.0.0 ### [`v14.1.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v14.1.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v14.0.0...v14.1.0) Minor release adding support for RN 0.73 and fixing some bugs 🎉 Thank you for all your contributions! #### What's Changed - fix: remove unused header causing problems by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2175 - fix `SvgCssUri` fallback by [@​myou11](https://togithub.com/myou11) in [software-mansion/react-native-svg#2171 - Minor fix to prevent crash when Loaded fires twice by [@​rozele](https://togithub.com/rozele) in [software-mansion/react-native-svg#2180 - feat: add support for RN 73 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2181 #### New Contributors - [@​myou11](https://togithub.com/myou11) made their first contribution in [software-mansion/react-native-svg#2171 - [@​rozele](https://togithub.com/rozele) made their first contribution in [software-mansion/react-native-svg#2180 **Full Changelog**: software-mansion/react-native-svg@v14.0.0...v14.1.0 ### [`v14.0.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v14.0.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.14.0...v14.0.0) Major release introducing some minor improvements and a ***BREAKING CHANGE***. From now on, you should import SvgCss, SvgCssUri, SvgWithCss, SvgWithCssUri, inlineStyles, LocalSvg, WithLocalSvg, loadLocalRawResource, from `react-native-svg/css` package instead. See [#​2168](https://togithub.com/react-native-community/react-native-svg/issues/2168) for more information. #### What's Changed - enable buildConfig generation to better support AGP8 by [@​pvegh](https://togithub.com/pvegh) in [software-mansion/react-native-svg#2143 - perf: avoid unnecessary shared_ptr copies in Fabric components by [@​javache](https://togithub.com/javache) in [software-mansion/react-native-svg#2164 - fix: props are no longer unnecesarily copied in new architecture by [@​javache](https://togithub.com/javache) in [software-mansion/react-native-svg#2163 - chore(deps): bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.22.8 to 7.23.2 in /Example by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-svg#2158 - Build `renderer/components/rnsvg` with `-std=c++20` by [@​NickGerleman](https://togithub.com/NickGerleman) in [software-mansion/react-native-svg#2141 - chore: bump examples to rn 0.72.6 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2166 - \[Windows] Port to Direct2D to remove win2d dependency by [@​marlenecota](https://togithub.com/marlenecota) in [software-mansion/react-native-svg#2052 - feat: move css to different package for size reduction by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2168 #### New Contributors - [@​pvegh](https://togithub.com/pvegh) made their first contribution in [software-mansion/react-native-svg#2143 - [@​javache](https://togithub.com/javache) made their first contribution in [software-mansion/react-native-svg#2164 - [@​NickGerleman](https://togithub.com/NickGerleman) made their first contribution in [software-mansion/react-native-svg#2141 **Full Changelog**: software-mansion/react-native-svg@v13.14.0...v14.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://togithub.com/react-native-community/react-native-svg) | [`^13.14.0` -> `^15.2.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.14.0/15.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg (react-native-svg)</summary> ### [`v15.2.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.2.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.1.0...v15.2.0) Minor release adding support for RN 0.74 on New Architecture and introducing some bug fixes. Thank you for your contributions! #### What's Changed - feat: add needed changes for RN 0.74 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2231 - Fix CMakeLists for Android by [@​tjzel](https://togithub.com/tjzel) in [software-mansion/react-native-svg#2249 - Adds support to compile react-native-svg against WinAppSDK by [@​rozele](https://togithub.com/rozele) in [software-mansion/react-native-svg#2255 - feat: bump RN to 0.74 in FabricExample and remove rea hacks by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2262 - feat: bump RN to 0.74 in Example by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2263 #### New Contributors - [@​tjzel](https://togithub.com/tjzel) made their first contribution in [software-mansion/react-native-svg#2249 **Full Changelog**: software-mansion/react-native-svg@v15.1.0...v15.2.0 ### [`v15.1.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.1.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.0.0...v15.1.0) Minor release including proper support for `react-native-reanimated` to the library on new architecture by using `dynamic` values for codegen. ##### What's Changed - feat: use dynamics instead of strings for props that can be either string or number by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2238 **Full Changelog**: software-mansion/react-native-svg@v15.0.0...v15.1.0 ### [`v15.0.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.0.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v14.1.0...v15.0.0) Major release introducing support for visionOS 🎉, some bug fixes and a BREAKING CHANGE due to [software-mansion/react-native-svg#2232. If your app already supports `iOS` >= `12.4` then you can safely upgrade the version, otherwise, you have to bump it first. #### What's Changed - feat: add visionOS support by [@​okwasniewski](https://togithub.com/okwasniewski) in [software-mansion/react-native-svg#2190 - fix: Correct types for transformsArrayToProps by [@​crazyfraggle](https://togithub.com/crazyfraggle) in [software-mansion/react-native-svg#2193 - chore: bump examples to 0.73.1 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2201 - Fix type exports and enable `isolatedModules` setting to catch it in `tsc` by [@​renchap](https://togithub.com/renchap) in [software-mansion/react-native-svg#2197 - Fix crash when SVG is unloaded by XAML by [@​rozele](https://togithub.com/rozele) in [software-mansion/react-native-svg#2195 - fix(SvgCssUri): support rendering fallback instead of crashing the app when loading invalid content from remote svg file by [@​quangkcao](https://togithub.com/quangkcao) in [software-mansion/react-native-svg#2196 - fix: Ensure RNSVG.dll is built with proper publisher/versioning information via new resource file. by [@​taenri](https://togithub.com/taenri) in [software-mansion/react-native-svg#2191 - Update ios-build-test.yml by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2207 - fix: visionOS support by [@​tomekzaw](https://togithub.com/tomekzaw) in [software-mansion/react-native-svg#2218 - fixed [@​Deprecated](https://togithub.com/Deprecated) warning in React Native 0.73: 'com.facebook.react.common.StandardCharsets' is deprecated and marked for removal by [@​coder-xiaomo](https://togithub.com/coder-xiaomo) in [software-mansion/react-native-svg#2208 - fix: typo on require statement (`WithLocalSvg`) by [@​voidsatisfaction](https://togithub.com/voidsatisfaction) in [software-mansion/react-native-svg#2223 - fix: Add missing nan value checks for bounds size by [@​MatiPl01](https://togithub.com/MatiPl01) in [software-mansion/react-native-svg#2220 - chore(deps): bump ip from 1.1.8 to 1.1.9 in /Example by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-svg#2228 - feat: bump minimal ios version to 12.4 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2232 #### New Contributors - [@​okwasniewski](https://togithub.com/okwasniewski) made their first contribution in [software-mansion/react-native-svg#2190 - [@​crazyfraggle](https://togithub.com/crazyfraggle) made their first contribution in [software-mansion/react-native-svg#2193 - [@​quangkcao](https://togithub.com/quangkcao) made their first contribution in [software-mansion/react-native-svg#2196 - [@​taenri](https://togithub.com/taenri) made their first contribution in [software-mansion/react-native-svg#2191 - [@​coder-xiaomo](https://togithub.com/coder-xiaomo) made their first contribution in [software-mansion/react-native-svg#2208 - [@​voidsatisfaction](https://togithub.com/voidsatisfaction) made their first contribution in [software-mansion/react-native-svg#2223 - [@​MatiPl01](https://togithub.com/MatiPl01) made their first contribution in [software-mansion/react-native-svg#2220 **Full Changelog**: software-mansion/react-native-svg@v14.1.0...v15.0.0 ### [`v14.1.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v14.1.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v14.0.0...v14.1.0) Minor release adding support for RN 0.73 and fixing some bugs 🎉 Thank you for all your contributions! #### What's Changed - fix: remove unused header causing problems by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2175 - fix `SvgCssUri` fallback by [@​myou11](https://togithub.com/myou11) in [software-mansion/react-native-svg#2171 - Minor fix to prevent crash when Loaded fires twice by [@​rozele](https://togithub.com/rozele) in [software-mansion/react-native-svg#2180 - feat: add support for RN 73 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2181 #### New Contributors - [@​myou11](https://togithub.com/myou11) made their first contribution in [software-mansion/react-native-svg#2171 - [@​rozele](https://togithub.com/rozele) made their first contribution in [software-mansion/react-native-svg#2180 **Full Changelog**: software-mansion/react-native-svg@v14.0.0...v14.1.0 ### [`v14.0.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v14.0.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.14.0...v14.0.0) Major release introducing some minor improvements and a ***BREAKING CHANGE***. From now on, you should import SvgCss, SvgCssUri, SvgWithCss, SvgWithCssUri, inlineStyles, LocalSvg, WithLocalSvg, loadLocalRawResource, from `react-native-svg/css` package instead. See [#​2168](https://togithub.com/react-native-community/react-native-svg/issues/2168) for more information. #### What's Changed - enable buildConfig generation to better support AGP8 by [@​pvegh](https://togithub.com/pvegh) in [software-mansion/react-native-svg#2143 - perf: avoid unnecessary shared_ptr copies in Fabric components by [@​javache](https://togithub.com/javache) in [software-mansion/react-native-svg#2164 - fix: props are no longer unnecesarily copied in new architecture by [@​javache](https://togithub.com/javache) in [software-mansion/react-native-svg#2163 - chore(deps): bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.22.8 to 7.23.2 in /Example by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-svg#2158 - Build `renderer/components/rnsvg` with `-std=c++20` by [@​NickGerleman](https://togithub.com/NickGerleman) in [software-mansion/react-native-svg#2141 - chore: bump examples to rn 0.72.6 by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2166 - \[Windows] Port to Direct2D to remove win2d dependency by [@​marlenecota](https://togithub.com/marlenecota) in [software-mansion/react-native-svg#2052 - feat: move css to different package for size reduction by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-svg#2168 #### New Contributors - [@​pvegh](https://togithub.com/pvegh) made their first contribution in [software-mansion/react-native-svg#2143 - [@​javache](https://togithub.com/javache) made their first contribution in [software-mansion/react-native-svg#2164 - [@​NickGerleman](https://togithub.com/NickGerleman) made their first contribution in [software-mansion/react-native-svg#2141 **Full Changelog**: software-mansion/react-native-svg@v13.14.0...v14.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
XAML may unload the root SVG panel, which will trigger a recursive unload. For GroupView, this unload will clear the child collection. However, active operations on the SVG from the React Native UIManager may still be in flight, in which case we may attempt to remove a child that has already been cleared by the root unload.
Test Plan
This wouldn't repro in any of the existing examples, but the crash no longer occurs in our app.
Compatibility
Checklist
README.md__tests__folder