Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use json output format in cargo if set in scarb_ui #1151

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Use json output format in cargo if set in scarb_ui #1151

merged 1 commit into from
Feb 24, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Feb 16, 2024 •
edited
Loading

This was referenced Feb 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@maciektr maciektr marked this pull request as ready for review February 16, 2024 10:39
mkaput
mkaput requested changes Feb 16, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a test

@maciektr maciektr force-pushed the spr/main/fd15f5ab branch 2 times, most recently from 8a17975 to e3097d2 Compare February 16, 2024 13:57
@maciektr maciektr changed the base branch from spr/main/aeeb309e to main February 19, 2024 13:00
@maciektr maciektr mentioned this pull request Feb 19, 2024
Merged
@maciektr maciektr changed the base branch from main to spr/main/aeeb309e February 19, 2024 13:00
@maciektr maciektr requested a review from mkaput February 19, 2024 14:37
@maciektr maciektr mentioned this pull request Feb 19, 2024
Merged
@maciektr maciektr mentioned this pull request Feb 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 22, 2024
@maciektr
Procedural macro compilation (#1110)
bffd585 
Resolves #1129

commit-id:aebc6424

---

**Stack**:
- #1161
- #1159
- #1157
- #1143
- #1151
- #1150
- #1148
- #1100
- #1155
- #1110 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr maciektr force-pushed the spr/main/fd15f5ab branch 2 times, most recently from a3af055 to c01c957 Compare February 22, 2024 23:54
@maciektr maciektr force-pushed the spr/main/aeeb309e branch 2 times, most recently from 83212d7 to deb8204 Compare February 23, 2024 11:13
@maciektr maciektr changed the base branch from spr/main/aeeb309e to main February 23, 2024 15:19
@maciektr maciektr changed the base branch from main to spr/main/aeeb309e February 23, 2024 15:19
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2024
@maciektr
Add test case for procedural macro compilation (#1100)
fcdae26 
commit-id:e457ae12

---

**Stack**:
- #1161
- #1159
- #1157
- #1143
- #1151
- #1150
- #1148
- #1155
- #1100 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr maciektr changed the base branch from spr/main/aeeb309e to main February 23, 2024 20:18
@maciektr maciektr changed the base branch from main to spr/main/aeeb309e February 23, 2024 20:18
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2024
@maciektr
Implement check command for cairo plugins (#1148)
c4cde23 
commit-id:1299f0be

---

**Stack**:
- #1161
- #1159
- #1157
- #1143
- #1151
- #1150
- #1155
- #1148 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr maciektr changed the base branch from spr/main/aeeb309e to main February 23, 2024 21:57
@maciektr maciektr changed the base branch from main to spr/main/aeeb309e February 23, 2024 21:57
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2024
@maciektr
Run cargo fetch on workspace resolve (#1150)
e7bf5da 
commit-id:aeeb309e

---

**Stack**:
- #1161
- #1159
- #1157
- #1143
- #1155
- #1151
- #1150 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/aeeb309e to main February 23, 2024 22:21
@maciektr maciektr added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit e220885 Feb 24, 2024
42 checks passed
@maciektr maciektr deleted the spr/main/fd15f5ab branch February 24, 2024 00:34
@BrewTestBot BrewTestBot mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@tomek0123456789 tomek0123456789 Awaiting requested review from tomek0123456789

@szymmis szymmis Awaiting requested review from szymmis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maciektr @mkaput