Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement procedural macro diagnostics #1159

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Implement procedural macro diagnostics #1159

merged 1 commit into from
Mar 12, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Feb 19, 2024 •
edited
Loading

commit-id:f06e9653

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Feb 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 21, 2024
@maciektr
Implement procedural macro host generate_code for attribute macro (#…
336751b 
…1091)

Resolves #1127

commit-id:e59370d2

---

**Stack**:
- #1159
- #1157
- #1143
- #1151
- #1150
- #1148
- #1100
- #1155
- #1110
- #1093
- #1091 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr maciektr force-pushed the spr/main/f06e9653 branch 2 times, most recently from 55817c2 to 86e3604 Compare February 21, 2024 14:12
github-merge-queue bot pushed a commit that referenced this pull request Feb 21, 2024
@maciektr
Implement loading shared libraries for proc macro plugins (#1093)
21e6d18 
Resolves #1128

commit-id:a3155bbf

---

**Stack**:
- #1159
- #1157
- #1143
- #1151
- #1150
- #1148
- #1100
- #1155
- #1110
- #1093 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr maciektr force-pushed the spr/main/54582a03 branch 2 times, most recently from 5b547d7 to 4abcf74 Compare February 21, 2024 18:37
@maciektr maciektr force-pushed the spr/main/f06e9653 branch 2 times, most recently from 906109b to f779175 Compare February 21, 2024 22:59
@maciektr maciektr mentioned this pull request Mar 5, 2024
Merged
@maciektr maciektr changed the base branch from main to spr/main/e557eb16 March 5, 2024 23:11
@maciektr maciektr requested review from mkaput and MaksymilianDemitraszek and removed request for tomek0123456789 March 5, 2024 23:13
MaksymilianDemitraszek
MaksymilianDemitraszek reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@MaksymilianDemitraszek MaksymilianDemitraszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, I am not fully in the loop yet so keep in mind those might be dumb.

plugins/cairo-lang-macro/src/lib.rs Show resolved Hide resolved
plugins/cairo-lang-macro/src/lib.rs Show resolved Hide resolved
plugins/cairo-lang-macro-stable/src/ffi.rs Show resolved Hide resolved
plugins/cairo-lang-macro-stable/src/ffi.rs Show resolved Hide resolved
plugins/cairo-lang-macro-stable/src/ffi.rs Outdated Show resolved Hide resolved
mkaput
mkaput requested changes Mar 7, 2024
View reviewed changes
plugins/cairo-lang-macro-stable/src/ffi.rs Show resolved Hide resolved
plugins/cairo-lang-macro-stable/src/ffi.rs Outdated Show resolved Hide resolved
github-merge-queue bot pushed a commit that referenced this pull request Mar 7, 2024
@maciektr
Fix memory managment around the FFI-barrier (#1174)
7cb6bed 
commit-id:e557eb16

---

**Stack**:
- #1166
- #1165
- #1161
- #1159
- #1174 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/e557eb16 to main March 7, 2024 13:41
mkaput
mkaput requested changes Mar 7, 2024
View reviewed changes
plugins/cairo-lang-macro-stable/src/lib.rs Outdated Show resolved Hide resolved
@maciektr maciektr requested a review from mkaput March 11, 2024 12:57
mkaput
mkaput requested changes Mar 12, 2024
View reviewed changes
plugins/cairo-lang-macro-stable/src/lib.rs Outdated Show resolved Hide resolved
plugins/cairo-lang-macro-stable/src/lib.rs Outdated Show resolved Hide resolved
plugins/cairo-lang-macro-stable/src/lib.rs Outdated Show resolved Hide resolved
@maciektr maciektr requested a review from mkaput March 12, 2024 08:32
@maciektr maciektr enabled auto-merge March 12, 2024 09:04
@maciektr maciektr added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit 08d1e92 Mar 12, 2024
42 checks passed
@maciektr maciektr deleted the spr/main/f06e9653 branch March 12, 2024 09:33
@BrewTestBot BrewTestBot mentioned this pull request Mar 13, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaksymilianDemitraszek MaksymilianDemitraszek MaksymilianDemitraszek left review comments

@mkaput mkaput mkaput approved these changes

@szymmis szymmis Awaiting requested review from szymmis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciektr @mkaput @MaksymilianDemitraszek