Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add side-effecting callback to retry attempts #56

Closed
rucek opened this issue Dec 4, 2023 · 0 comments
Closed

Add side-effecting callback to retry attempts #56

rucek opened this issue Dec 4, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request retries

Comments

@rucek
Copy link
Contributor

rucek commented Dec 4, 2023

When the retry mechanism performs another attempt to run the operation, it might be useful to execute a side effect - like logging or updating metrics.

Some things to consider:

  • how much context should such a callback have (e.g. which attempt is this)
  • should the callback be executed before or after the attempt? In the latter case it could include the result, which - particularly in case of error - might be useful for logging/metrics. Or perhaps both such callbacks should be available, so that we can hook into the retry lifecycle even more?
@rucek rucek added enhancement New feature or request retries labels Dec 4, 2023
@DybekK DybekK self-assigned this Mar 15, 2024
@adamw adamw closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request retries
Projects
None yet
Development

No branches or pull requests

3 participants