-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moderpython simplification + Attribute NS #21
Conversation
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
618cf6c
to
0213c8c
Compare
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
c211641
to
96f91a9
Compare
@guillaume-alliander What is the state of this PR? Can it be merged before #20 or is there some dependency? Please assign this to me when you would like one of us to have a look. If you would like to discuss the roadmap or maintainer role with us, feel free to reach out to @dinkelbachjan and me via mail or slack. |
I would like to have confirmation from @chicco785 but this one should be merged before #20 I believe. |
yes, i will rebase my changes on top of this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick look, it seems fine to me.
96f91a9
to
532454a
Compare
Kudos, SonarCloud Quality Gate passed!
|
Mostly split
Base.py
in a bunch of smaller, more specific classes, and add attributes NS.