Moderpython simplification + Attribute NS #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
guillaume-alliander
force-pushed
the
custom_profiles
branch
from
618cf6c
to
0213c8c
Compare
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
guillaume-alliander
changed the title
guillaume-alliander
force-pushed
the
custom_profiles
branch
from
c211641
to
96f91a9
Compare
|
@guillaume-alliander What is the state of this PR? Can it be merged before #20 or is there some dependency? Please assign this to me when you would like one of us to have a look. If you would like to discuss the roadmap or maintainer role with us, feel free to reach out to @dinkelbachjan and me via mail or slack. |
|
I would like to have confirmation from @chicco785 but this one should be merged before #20 I believe. |
yes, i will rebase my changes on top of this PR |
chicco785
approved these changes
Nov 14, 2023
guillaume-alliander
force-pushed
the
custom_profiles
branch
from
96f91a9
to
532454a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
m-mirz
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly split
Base.pyin a bunch of smaller, more specific classes, and add attributes NS.