Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice: grpc-go will stop sending RPCs before HTTP/2 SETTINGS frame is received #64

Open
dfawley opened this Issue Oct 26, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@dfawley
Copy link

dfawley commented Oct 26, 2018

This is a notice that grpc-go intends to change in a way that we know will break the way cmux currently works by default. This will bring grpc-go in line with grpc-java's behavior, and C/wrapped languages will be following suit as well. Details and justification for the change can be found in grpc/grpc#17006. grpc-go's migration plan is proposed in grpc/grpc-go#2406. Please feel free to comment in the appropriate PR/issue for questions or concerns about this. Apologies in advance for the breaking change.

jadekler added a commit to jadekler/grpc-go that referenced this issue Dec 20, 2018

transport: remove RequireHandshakeHybrid support
This removes RequireHandshakeHybrid support and changes the default behavior
to RequireHandshakeOn. Dial calls will now block and wait for a successful
handshake before proceeding. Users relying on the old hybrid behavior (cmux
users) should consult soheilhy/cmux#64.

Also, several tests have been updated to take this into consideration by
sending settings frames.

jadekler added a commit to jadekler/grpc-go that referenced this issue Dec 20, 2018

transport: remove RequireHandshakeHybrid support
This removes RequireHandshakeHybrid support and changes the default behavior
to RequireHandshakeOn. Dial calls will now block and wait for a successful
handshake before proceeding. Users relying on the old hybrid behavior (cmux
users) should consult soheilhy/cmux#64.

Also, several tests have been updated to take this into consideration by
sending settings frames.

jadekler added a commit to jadekler/grpc-go that referenced this issue Dec 21, 2018

transport: remove RequireHandshakeHybrid support
This removes RequireHandshakeHybrid support and changes the default behavior
to RequireHandshakeOn. Dial calls will now block and wait for a successful
handshake before proceeding. Users relying on the old hybrid behavior (cmux
users) should consult soheilhy/cmux#64.

Also, several tests have been updated to take this into consideration by
sending settings frames.

chrislusf added a commit to chrislusf/seaweedfs that referenced this issue Jan 18, 2019

jadekler added a commit to jadekler/grpc-go that referenced this issue Feb 8, 2019

transport: remove RequireHandshakeHybrid support
This removes RequireHandshakeHybrid support and changes the default behavior
to RequireHandshakeOn. Dial calls will now block and wait for a successful
handshake before proceeding. Users relying on the old hybrid behavior (cmux
users) should consult soheilhy/cmux#64.

Also, several tests have been updated to take this into consideration by
sending settings frames.

jadekler added a commit to jadekler/grpc-go that referenced this issue Feb 8, 2019

transport: remove RequireHandshakeHybrid support
This removes RequireHandshakeHybrid support and changes the default behavior
to RequireHandshakeOn. Dial calls will now block and wait for a successful
handshake before proceeding. Users relying on the old hybrid behavior (cmux
users) should consult soheilhy/cmux#64.

Also, several tests have been updated to take this into consideration by
sending settings frames.
@Iulian7

This comment has been minimized.

Copy link

Iulian7 commented Feb 8, 2019

Any ideas how to match grpc-go requests then?

@dfawley

This comment has been minimized.

Copy link
Author

dfawley commented Feb 8, 2019

@lulian7 - IIUC you should be able to use the workaround suggested here for Java gRPC clients: https://github.com/soheilhy/cmux#limitations

@Iulian7

This comment has been minimized.

Copy link

Iulian7 commented Feb 8, 2019

@dfawley Works. I missed that.

jadekler added a commit to jadekler/grpc-go that referenced this issue Feb 12, 2019

transport: remove RequireHandshakeHybrid support
This removes RequireHandshakeHybrid support and changes the default behavior
to RequireHandshakeOn. Dial calls will now block and wait for a successful
handshake before proceeding. Users relying on the old hybrid behavior (cmux
users) should consult soheilhy/cmux#64.

Also, several tests have been updated to take this into consideration by
sending settings frames.

jadekler added a commit to jadekler/grpc-go that referenced this issue Feb 20, 2019

transport: remove RequireHandshakeHybrid support
This removes RequireHandshakeHybrid support and changes the default behavior
to RequireHandshakeOn. Dial calls will now block and wait for a successful
handshake before proceeding. Users relying on the old hybrid behavior (cmux
users) should consult soheilhy/cmux#64.

Also, several tests have been updated to take this into consideration by
sending settings frames.

jadekler added a commit to grpc/grpc-go that referenced this issue Feb 27, 2019

transport: remove RequireHandshakeHybrid support (#2529)
This removes RequireHandshakeHybrid support and changes the default behavior
to RequireHandshakeOn. Dial calls will now block and wait for a successful
handshake before proceeding. Users relying on the old hybrid behavior (cmux
users) should consult soheilhy/cmux#64.

Also, several tests have been updated to take this into consideration by
sending settings frames.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.