Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severe performance regression when using ServeHTTP #586

Open
tamird opened this issue Mar 4, 2016 · 20 comments
Open

Severe performance regression when using ServeHTTP #586

tamird opened this issue Mar 4, 2016 · 20 comments

Comments

@tamird
Copy link
Contributor

@tamird tamird commented Mar 4, 2016

Extracting from discussion in #549. See https://github.com/cockroachdb/rpc-bench; relevant parts as of this writing:

name                 time/op
GRPCServe_1K-4         72.6µs ±10%
GRPCServe_64K-4         785µs ± 8%
GRPCServeHTTP_1K-4      178µs ± 2%
GRPCServeHTTP_64K-4    1.32ms ± 2%

name                 speed
GRPCServe_1K-4       28.3MB/s ± 9%
GRPCServe_64K-4       167MB/s ± 7%
GRPCServeHTTP_1K-4   11.5MB/s ± 2%
GRPCServeHTTP_64K-4  99.4MB/s ± 2%

name                 alloc/op
GRPCServe_1K-4         15.6kB ± 0%
GRPCServe_64K-4         711kB ± 0%
GRPCServeHTTP_1K-4     88.5kB ± 0%
GRPCServeHTTP_64K-4     801kB ± 0%

name                 allocs/op
GRPCServe_1K-4           96.0 ± 0%
GRPCServe_64K-4           162 ± 0%
GRPCServeHTTP_1K-4        166 ± 0%
GRPCServeHTTP_64K-4       671 ± 0%
tamird added a commit to tamird/cockroach that referenced this issue Mar 9, 2016
See grpc/grpc-go#586

With local calls disabled:
```
name                          old time/op    new time/op    delta
Select1_Cockroach-4             61.8µs ± 3%    64.2µs ± 3%   +3.90%          (p=0.032 n=5+5)
Select2_Cockroach-4             1.01ms ±14%    1.17ms ± 1%  +16.15%          (p=0.008 n=5+5)
Insert1_Cockroach-4              480µs ± 1%     645µs ± 2%  +34.35%          (p=0.008 n=5+5)
Insert10_Cockroach-4             815µs ± 5%    1031µs ± 3%  +26.57%          (p=0.008 n=5+5)
Insert100_Cockroach-4           3.81ms ± 1%    4.45ms ±14%  +16.74%          (p=0.008 n=5+5)
Insert1000_Cockroach-4          34.3ms ± 1%    36.5ms ± 2%   +6.45%          (p=0.008 n=5+5)
Update1_Cockroach-4              807µs ± 5%    1109µs ± 2%  +37.40%          (p=0.008 n=5+5)
Update10_Cockroach-4            1.47ms ± 6%    1.84ms ± 2%  +25.27%          (p=0.008 n=5+5)
Update100_Cockroach-4           6.93ms ± 1%    7.84ms ± 1%  +13.04%          (p=0.008 n=5+5)
Update1000_Cockroach-4          56.4ms ± 3%    61.3ms ± 2%   +8.61%          (p=0.008 n=5+5)
Delete1_Cockroach-4              725µs ± 4%     975µs ±10%  +34.50%          (p=0.008 n=5+5)
Delete10_Cockroach-4            1.94ms ± 1%    2.27ms ± 2%  +16.88%          (p=0.008 n=5+5)
Delete100_Cockroach-4           14.5ms ± 1%    16.0ms ± 1%  +10.32%          (p=0.008 n=5+5)
Delete1000_Cockroach-4           144ms ± 5%     144ms ± 1%     ~             (p=0.690 n=5+5)
Scan1_Cockroach-4                291µs ± 1%     433µs ± 2%  +48.91%          (p=0.008 n=5+5)
Scan10_Cockroach-4               334µs ± 1%     470µs ± 0%  +40.65%          (p=0.008 n=5+5)
Scan100_Cockroach-4              665µs ± 3%     855µs ± 4%  +28.73%          (p=0.008 n=5+5)
Scan1000_Cockroach-4            3.68ms ± 1%    4.26ms ± 0%  +15.81%          (p=0.008 n=5+5)
Scan10000_Cockroach-4           36.9ms ± 1%    41.9ms ± 2%  +13.54%          (p=0.008 n=5+5)
Scan1000Limit1_Cockroach-4       304µs ± 2%     473µs ±12%  +55.50%          (p=0.008 n=5+5)
Scan1000Limit10_Cockroach-4      347µs ± 1%     496µs ± 3%  +42.81%          (p=0.008 n=5+5)
Scan1000Limit100_Cockroach-4     691µs ± 3%     881µs ± 2%  +27.42%          (p=0.008 n=5+5)

name                          old alloc/op   new alloc/op   delta
Select1_Cockroach-4             3.91kB ± 0%    3.93kB ± 0%   +0.40%          (p=0.008 n=5+5)
Select2_Cockroach-4              101kB ± 0%     123kB ± 0%  +22.09%          (p=0.008 n=5+5)
Insert1_Cockroach-4             27.8kB ± 0%    35.5kB ± 0%  +27.54%          (p=0.008 n=5+5)
Insert10_Cockroach-4            83.2kB ± 0%    93.2kB ± 0%  +11.91%          (p=0.008 n=5+5)
Insert100_Cockroach-4            639kB ± 0%     671kB ± 0%   +4.95%          (p=0.008 n=5+5)
Insert1000_Cockroach-4          5.72MB ± 1%    5.90MB ± 0%   +3.20%          (p=0.008 n=5+5)
Update1_Cockroach-4             43.6kB ± 0%    57.9kB ± 0%  +32.81%          (p=0.008 n=5+5)
Update10_Cockroach-4             132kB ± 0%     153kB ± 0%  +16.13%          (p=0.008 n=5+5)
Update100_Cockroach-4            980kB ± 0%    1053kB ± 0%   +7.49%          (p=0.008 n=5+5)
Update1000_Cockroach-4          8.45MB ± 0%    9.00MB ± 0%   +6.53%          (p=0.008 n=5+5)
Delete1_Cockroach-4             34.8kB ± 0%    42.4kB ± 0%  +21.91%          (p=0.008 n=5+5)
Delete10_Cockroach-4            93.6kB ± 0%   104.7kB ± 0%  +11.87%          (p=0.008 n=5+5)
Delete100_Cockroach-4            689kB ± 0%     727kB ± 0%   +5.56%          (p=0.008 n=5+5)
Delete1000_Cockroach-4          6.15MB ± 0%    6.45MB ± 0%   +4.85%          (p=0.016 n=5+4)
Scan1_Cockroach-4               15.2kB ± 0%    21.7kB ± 0%  +43.30%          (p=0.008 n=5+5)
Scan10_Cockroach-4              21.1kB ± 0%    28.9kB ± 0%  +36.96%          (p=0.008 n=5+5)
Scan100_Cockroach-4             69.1kB ± 0%    88.2kB ± 0%  +27.65%          (p=0.016 n=4+5)
Scan1000_Cockroach-4             522kB ± 0%     643kB ± 0%  +23.26%          (p=0.008 n=5+5)
Scan10000_Cockroach-4           9.48MB ± 0%   10.48MB ± 0%  +10.61%          (p=0.016 n=4+5)
Scan1000Limit1_Cockroach-4      16.1kB ± 0%    22.8kB ± 0%  +41.66%          (p=0.008 n=5+5)
Scan1000Limit10_Cockroach-4     21.8kB ± 0%    29.9kB ± 0%  +36.72%          (p=0.008 n=5+5)
Scan1000Limit100_Cockroach-4    69.8kB ± 0%    88.9kB ± 0%  +27.37%          (p=0.008 n=5+5)

name                          old allocs/op  new allocs/op  delta
Select1_Cockroach-4               97.0 ± 0%      97.0 ± 0%     ~     (all samples are equal)
Select2_Cockroach-4              2.95k ± 0%     3.05k ± 0%   +3.39%          (p=0.008 n=5+5)
Insert1_Cockroach-4                402 ± 0%       504 ± 0%  +25.37%          (p=0.016 n=5+4)
Insert10_Cockroach-4             1.01k ± 0%     1.11k ± 0%  +10.02%          (p=0.008 n=5+5)
Insert100_Cockroach-4            6.73k ± 0%     6.85k ± 0%   +1.78%          (p=0.008 n=5+5)
Insert1000_Cockroach-4           64.3k ± 0%     64.4k ± 0%     ~             (p=0.151 n=5+5)
Update1_Cockroach-4                795 ± 0%       993 ± 0%  +24.93%          (p=0.016 n=4+5)
Update10_Cockroach-4             1.64k ± 0%     1.84k ± 0%  +12.14%          (p=0.008 n=5+5)
Update100_Cockroach-4            9.54k ± 0%     9.73k ± 0%   +2.09%          (p=0.008 n=5+5)
Update1000_Cockroach-4           84.5k ± 0%     85.0k ± 0%   +0.53%          (p=0.016 n=5+5)
Delete1_Cockroach-4                620 ± 0%       720 ± 0%  +16.09%          (p=0.008 n=5+5)
Delete10_Cockroach-4             1.41k ± 0%     1.52k ± 0%   +7.19%          (p=0.016 n=4+5)
Delete100_Cockroach-4            9.04k ± 0%     9.14k ± 0%   +1.11%          (p=0.008 n=5+5)
Delete1000_Cockroach-4           84.7k ± 0%     84.9k ± 0%   +0.17%          (p=0.016 n=5+4)
Scan1_Cockroach-4                  304 ± 0%       402 ± 0%  +32.37%          (p=0.016 n=4+5)
Scan10_Cockroach-4                 405 ± 0%       505 ± 0%  +24.57%          (p=0.016 n=5+4)
Scan100_Cockroach-4              1.31k ± 0%     1.42k ± 0%   +7.60%          (p=0.016 n=4+5)
Scan1000_Cockroach-4             10.3k ± 0%     10.4k ± 0%   +1.16%          (p=0.008 n=5+5)
Scan10000_Cockroach-4             101k ± 0%      101k ± 0%   +0.37%          (p=0.008 n=5+5)
Scan1000Limit1_Cockroach-4         330 ± 0%       428 ± 0%  +29.98%          (p=0.008 n=5+5)
Scan1000Limit10_Cockroach-4        430 ± 0%       529 ± 0%  +23.14%          (p=0.016 n=5+4)
Scan1000Limit100_Cockroach-4     1.34k ± 0%     1.44k ± 0%   +7.47%          (p=0.016 n=4+5)
```

```
name                          old time/op    new time/op    delta
Select1_Cockroach-4             60.1µs ± 0%    63.0µs ± 1%   +4.82%          (p=0.008 n=5+5)
Select2_Cockroach-4              846µs ±18%     847µs ± 2%     ~             (p=0.222 n=5+5)
Insert1_Cockroach-4              383µs ± 2%     376µs ± 3%     ~             (p=0.222 n=5+5)
Insert10_Cockroach-4             689µs ± 9%     703µs ± 4%     ~             (p=0.222 n=5+5)
Insert100_Cockroach-4           3.49ms ± 2%    3.64ms ± 2%   +4.29%          (p=0.008 n=5+5)
Insert1000_Cockroach-4          33.2ms ± 3%    34.1ms ± 1%     ~             (p=0.095 n=5+5)
Update1_Cockroach-4              594µs ± 3%     559µs ± 1%   -6.00%          (p=0.008 n=5+5)
Update10_Cockroach-4            1.15ms ± 4%    1.21ms ± 2%   +5.51%          (p=0.008 n=5+5)
Update100_Cockroach-4           6.17ms ± 2%    6.44ms ± 2%   +4.23%          (p=0.008 n=5+5)
Update1000_Cockroach-4          52.7ms ± 3%    55.5ms ± 3%   +5.45%          (p=0.016 n=5+5)
Delete1_Cockroach-4              625µs ± 1%     611µs ± 2%   -2.34%          (p=0.008 n=5+5)
Delete10_Cockroach-4            1.83ms ± 4%    1.90ms ± 7%     ~             (p=0.151 n=5+5)
Delete100_Cockroach-4           14.8ms ± 2%    16.1ms ± 8%   +8.73%          (p=0.008 n=5+5)
Delete1000_Cockroach-4           140ms ± 5%     141ms ± 1%     ~             (p=0.690 n=5+5)
Scan1_Cockroach-4                207µs ± 2%     172µs ± 5%  -16.86%          (p=0.008 n=5+5)
Scan10_Cockroach-4               242µs ± 4%     230µs ± 8%   -5.18%          (p=0.032 n=5+5)
Scan100_Cockroach-4              500µs ± 2%     540µs ± 2%   +7.92%          (p=0.008 n=5+5)
Scan1000_Cockroach-4            2.98ms ± 1%    3.22ms ± 1%   +8.00%          (p=0.008 n=5+5)
Scan10000_Cockroach-4           30.5ms ± 1%    32.6ms ± 1%   +6.80%          (p=0.008 n=5+5)
Scan1000Limit1_Cockroach-4       218µs ± 1%     204µs ±14%     ~             (p=0.151 n=5+5)
Scan1000Limit10_Cockroach-4      253µs ± 4%     234µs ± 7%     ~             (p=0.056 n=5+5)
Scan1000Limit100_Cockroach-4     524µs ± 4%     568µs ± 5%   +8.47%          (p=0.008 n=5+5)

name                          old alloc/op   new alloc/op   delta
Select1_Cockroach-4             3.91kB ± 0%    3.91kB ± 0%     ~             (p=0.111 n=5+5)
Select2_Cockroach-4             80.7kB ± 0%    81.1kB ± 0%   +0.41%          (p=0.008 n=5+5)
Insert1_Cockroach-4             23.0kB ± 0%    23.4kB ± 0%   +1.59%          (p=0.008 n=5+5)
Insert10_Cockroach-4            67.2kB ± 0%    67.6kB ± 0%   +0.51%          (p=0.008 n=5+5)
Insert100_Cockroach-4            507kB ± 0%     508kB ± 0%   +0.08%          (p=0.032 n=5+5)
Insert1000_Cockroach-4          4.53MB ± 0%    4.58MB ± 1%   +1.06%          (p=0.008 n=5+5)
Update1_Cockroach-4             36.7kB ± 0%    37.5kB ± 0%   +1.97%          (p=0.008 n=5+5)
Update10_Cockroach-4            99.4kB ± 0%   100.1kB ± 0%   +0.76%          (p=0.008 n=5+5)
Update100_Cockroach-4            704kB ± 0%     707kB ± 0%   +0.42%          (p=0.016 n=5+5)
Update1000_Cockroach-4          6.08MB ± 1%    6.10MB ± 1%     ~             (p=0.222 n=5+5)
Delete1_Cockroach-4             29.8kB ± 0%    30.2kB ± 0%   +1.35%          (p=0.008 n=5+5)
Delete10_Cockroach-4            75.7kB ± 0%    76.1kB ± 0%   +0.60%          (p=0.008 n=5+5)
Delete100_Cockroach-4            537kB ± 0%     539kB ± 0%   +0.40%          (p=0.008 n=5+5)
Delete1000_Cockroach-4          4.81MB ± 0%    4.81MB ± 0%     ~             (p=0.190 n=4+5)
Scan1_Cockroach-4               13.3kB ± 0%    13.6kB ± 0%   +2.71%          (p=0.008 n=5+5)
Scan10_Cockroach-4              17.1kB ± 0%    17.5kB ± 0%   +2.23%          (p=0.008 n=5+5)
Scan100_Cockroach-4             49.4kB ± 0%    49.8kB ± 0%   +0.78%          (p=0.008 n=5+5)
Scan1000_Cockroach-4             331kB ± 0%     332kB ± 0%   +0.15%          (p=0.008 n=5+5)
Scan10000_Cockroach-4           5.72MB ± 0%    5.72MB ± 0%   +0.02%          (p=0.008 n=5+5)
Scan1000Limit1_Cockroach-4      14.0kB ± 0%    14.4kB ± 0%   +2.55%          (p=0.008 n=5+5)
Scan1000Limit10_Cockroach-4     17.9kB ± 0%    18.2kB ± 0%   +2.05%          (p=0.008 n=5+5)
Scan1000Limit100_Cockroach-4    50.0kB ± 0%    50.4kB ± 0%   +0.75%          (p=0.008 n=5+5)

name                          old allocs/op  new allocs/op  delta
Select1_Cockroach-4               97.0 ± 0%      97.0 ± 0%     ~     (all samples are equal)
Select2_Cockroach-4              2.70k ± 0%     2.70k ± 0%   +0.16%          (p=0.016 n=5+4)
Insert1_Cockroach-4                357 ± 0%       362 ± 0%   +1.46%          (p=0.008 n=5+5)
Insert10_Cockroach-4               907 ± 0%       912 ± 0%   +0.51%          (p=0.008 n=5+5)
Insert100_Cockroach-4            6.17k ± 0%     6.18k ± 0%   +0.07%          (p=0.016 n=5+5)
Insert1000_Cockroach-4           58.8k ± 0%     59.1k ± 0%   +0.54%          (p=0.008 n=5+5)
Update1_Cockroach-4                719 ± 0%       729 ± 0%   +1.45%          (p=0.016 n=5+4)
Update10_Cockroach-4             1.41k ± 0%     1.42k ± 0%   +0.73%          (p=0.008 n=5+5)
Update100_Cockroach-4            7.93k ± 0%     7.96k ± 0%   +0.42%          (p=0.008 n=5+5)
Update1000_Cockroach-4           70.0k ± 0%     70.1k ± 0%     ~             (p=0.151 n=5+5)
Delete1_Cockroach-4                567 ± 0%       572 ± 0%   +0.88%          (p=0.029 n=4+4)
Delete10_Cockroach-4             1.24k ± 0%     1.24k ± 0%   +0.49%          (p=0.029 n=4+4)
Delete100_Cockroach-4            7.68k ± 0%     7.69k ± 0%   +0.11%          (p=0.008 n=5+5)
Delete1000_Cockroach-4           71.7k ± 0%     71.7k ± 0%     ~             (p=0.317 n=4+5)
Scan1_Cockroach-4                  276 ± 0%       281 ± 0%   +1.81%          (p=0.008 n=5+5)
Scan10_Cockroach-4                 356 ± 0%       361 ± 0%   +1.52%          (p=0.016 n=5+4)
Scan100_Cockroach-4              1.08k ± 0%     1.09k ± 0%   +0.46%          (p=0.016 n=4+5)
Scan1000_Cockroach-4             8.29k ± 0%     8.30k ± 0%   +0.07%          (p=0.008 n=5+5)
Scan10000_Cockroach-4            80.4k ± 0%     80.5k ± 0%   +0.02%          (p=0.008 n=5+5)
Scan1000Limit1_Cockroach-4         298 ± 0%       303 ± 0%   +1.54%          (p=0.016 n=5+4)
Scan1000Limit10_Cockroach-4        378 ± 0%       383 ± 0%   +1.32%          (p=0.029 n=4+4)
Scan1000Limit100_Cockroach-4     1.10k ± 0%     1.11k ± 0%   +0.42%          (p=0.008 n=5+5)
```
tamird added a commit to tamird/cockroach that referenced this issue Mar 9, 2016
See grpc/grpc-go#586

With local calls disabled:
```
name                          old time/op    new time/op    delta
Select1_Cockroach-4             61.8µs ± 3%    64.2µs ± 3%   +3.90%          (p=0.032 n=5+5)
Select2_Cockroach-4             1.01ms ±14%    1.17ms ± 1%  +16.15%          (p=0.008 n=5+5)
Insert1_Cockroach-4              480µs ± 1%     645µs ± 2%  +34.35%          (p=0.008 n=5+5)
Insert10_Cockroach-4             815µs ± 5%    1031µs ± 3%  +26.57%          (p=0.008 n=5+5)
Insert100_Cockroach-4           3.81ms ± 1%    4.45ms ±14%  +16.74%          (p=0.008 n=5+5)
Insert1000_Cockroach-4          34.3ms ± 1%    36.5ms ± 2%   +6.45%          (p=0.008 n=5+5)
Update1_Cockroach-4              807µs ± 5%    1109µs ± 2%  +37.40%          (p=0.008 n=5+5)
Update10_Cockroach-4            1.47ms ± 6%    1.84ms ± 2%  +25.27%          (p=0.008 n=5+5)
Update100_Cockroach-4           6.93ms ± 1%    7.84ms ± 1%  +13.04%          (p=0.008 n=5+5)
Update1000_Cockroach-4          56.4ms ± 3%    61.3ms ± 2%   +8.61%          (p=0.008 n=5+5)
Delete1_Cockroach-4              725µs ± 4%     975µs ±10%  +34.50%          (p=0.008 n=5+5)
Delete10_Cockroach-4            1.94ms ± 1%    2.27ms ± 2%  +16.88%          (p=0.008 n=5+5)
Delete100_Cockroach-4           14.5ms ± 1%    16.0ms ± 1%  +10.32%          (p=0.008 n=5+5)
Delete1000_Cockroach-4           144ms ± 5%     144ms ± 1%     ~             (p=0.690 n=5+5)
Scan1_Cockroach-4                291µs ± 1%     433µs ± 2%  +48.91%          (p=0.008 n=5+5)
Scan10_Cockroach-4               334µs ± 1%     470µs ± 0%  +40.65%          (p=0.008 n=5+5)
Scan100_Cockroach-4              665µs ± 3%     855µs ± 4%  +28.73%          (p=0.008 n=5+5)
Scan1000_Cockroach-4            3.68ms ± 1%    4.26ms ± 0%  +15.81%          (p=0.008 n=5+5)
Scan10000_Cockroach-4           36.9ms ± 1%    41.9ms ± 2%  +13.54%          (p=0.008 n=5+5)
Scan1000Limit1_Cockroach-4       304µs ± 2%     473µs ±12%  +55.50%          (p=0.008 n=5+5)
Scan1000Limit10_Cockroach-4      347µs ± 1%     496µs ± 3%  +42.81%          (p=0.008 n=5+5)
Scan1000Limit100_Cockroach-4     691µs ± 3%     881µs ± 2%  +27.42%          (p=0.008 n=5+5)

name                          old alloc/op   new alloc/op   delta
Select1_Cockroach-4             3.91kB ± 0%    3.93kB ± 0%   +0.40%          (p=0.008 n=5+5)
Select2_Cockroach-4              101kB ± 0%     123kB ± 0%  +22.09%          (p=0.008 n=5+5)
Insert1_Cockroach-4             27.8kB ± 0%    35.5kB ± 0%  +27.54%          (p=0.008 n=5+5)
Insert10_Cockroach-4            83.2kB ± 0%    93.2kB ± 0%  +11.91%          (p=0.008 n=5+5)
Insert100_Cockroach-4            639kB ± 0%     671kB ± 0%   +4.95%          (p=0.008 n=5+5)
Insert1000_Cockroach-4          5.72MB ± 1%    5.90MB ± 0%   +3.20%          (p=0.008 n=5+5)
Update1_Cockroach-4             43.6kB ± 0%    57.9kB ± 0%  +32.81%          (p=0.008 n=5+5)
Update10_Cockroach-4             132kB ± 0%     153kB ± 0%  +16.13%          (p=0.008 n=5+5)
Update100_Cockroach-4            980kB ± 0%    1053kB ± 0%   +7.49%          (p=0.008 n=5+5)
Update1000_Cockroach-4          8.45MB ± 0%    9.00MB ± 0%   +6.53%          (p=0.008 n=5+5)
Delete1_Cockroach-4             34.8kB ± 0%    42.4kB ± 0%  +21.91%          (p=0.008 n=5+5)
Delete10_Cockroach-4            93.6kB ± 0%   104.7kB ± 0%  +11.87%          (p=0.008 n=5+5)
Delete100_Cockroach-4            689kB ± 0%     727kB ± 0%   +5.56%          (p=0.008 n=5+5)
Delete1000_Cockroach-4          6.15MB ± 0%    6.45MB ± 0%   +4.85%          (p=0.016 n=5+4)
Scan1_Cockroach-4               15.2kB ± 0%    21.7kB ± 0%  +43.30%          (p=0.008 n=5+5)
Scan10_Cockroach-4              21.1kB ± 0%    28.9kB ± 0%  +36.96%          (p=0.008 n=5+5)
Scan100_Cockroach-4             69.1kB ± 0%    88.2kB ± 0%  +27.65%          (p=0.016 n=4+5)
Scan1000_Cockroach-4             522kB ± 0%     643kB ± 0%  +23.26%          (p=0.008 n=5+5)
Scan10000_Cockroach-4           9.48MB ± 0%   10.48MB ± 0%  +10.61%          (p=0.016 n=4+5)
Scan1000Limit1_Cockroach-4      16.1kB ± 0%    22.8kB ± 0%  +41.66%          (p=0.008 n=5+5)
Scan1000Limit10_Cockroach-4     21.8kB ± 0%    29.9kB ± 0%  +36.72%          (p=0.008 n=5+5)
Scan1000Limit100_Cockroach-4    69.8kB ± 0%    88.9kB ± 0%  +27.37%          (p=0.008 n=5+5)

name                          old allocs/op  new allocs/op  delta
Select1_Cockroach-4               97.0 ± 0%      97.0 ± 0%     ~     (all samples are equal)
Select2_Cockroach-4              2.95k ± 0%     3.05k ± 0%   +3.39%          (p=0.008 n=5+5)
Insert1_Cockroach-4                402 ± 0%       504 ± 0%  +25.37%          (p=0.016 n=5+4)
Insert10_Cockroach-4             1.01k ± 0%     1.11k ± 0%  +10.02%          (p=0.008 n=5+5)
Insert100_Cockroach-4            6.73k ± 0%     6.85k ± 0%   +1.78%          (p=0.008 n=5+5)
Insert1000_Cockroach-4           64.3k ± 0%     64.4k ± 0%     ~             (p=0.151 n=5+5)
Update1_Cockroach-4                795 ± 0%       993 ± 0%  +24.93%          (p=0.016 n=4+5)
Update10_Cockroach-4             1.64k ± 0%     1.84k ± 0%  +12.14%          (p=0.008 n=5+5)
Update100_Cockroach-4            9.54k ± 0%     9.73k ± 0%   +2.09%          (p=0.008 n=5+5)
Update1000_Cockroach-4           84.5k ± 0%     85.0k ± 0%   +0.53%          (p=0.016 n=5+5)
Delete1_Cockroach-4                620 ± 0%       720 ± 0%  +16.09%          (p=0.008 n=5+5)
Delete10_Cockroach-4             1.41k ± 0%     1.52k ± 0%   +7.19%          (p=0.016 n=4+5)
Delete100_Cockroach-4            9.04k ± 0%     9.14k ± 0%   +1.11%          (p=0.008 n=5+5)
Delete1000_Cockroach-4           84.7k ± 0%     84.9k ± 0%   +0.17%          (p=0.016 n=5+4)
Scan1_Cockroach-4                  304 ± 0%       402 ± 0%  +32.37%          (p=0.016 n=4+5)
Scan10_Cockroach-4                 405 ± 0%       505 ± 0%  +24.57%          (p=0.016 n=5+4)
Scan100_Cockroach-4              1.31k ± 0%     1.42k ± 0%   +7.60%          (p=0.016 n=4+5)
Scan1000_Cockroach-4             10.3k ± 0%     10.4k ± 0%   +1.16%          (p=0.008 n=5+5)
Scan10000_Cockroach-4             101k ± 0%      101k ± 0%   +0.37%          (p=0.008 n=5+5)
Scan1000Limit1_Cockroach-4         330 ± 0%       428 ± 0%  +29.98%          (p=0.008 n=5+5)
Scan1000Limit10_Cockroach-4        430 ± 0%       529 ± 0%  +23.14%          (p=0.016 n=5+4)
Scan1000Limit100_Cockroach-4     1.34k ± 0%     1.44k ± 0%   +7.47%          (p=0.016 n=4+5)
```

With local calls enabled:
```
name                          old time/op    new time/op    delta
Select1_Cockroach-4             60.1µs ± 0%    63.0µs ± 1%   +4.82%          (p=0.008 n=5+5)
Select2_Cockroach-4              846µs ±18%     847µs ± 2%     ~             (p=0.222 n=5+5)
Insert1_Cockroach-4              383µs ± 2%     376µs ± 3%     ~             (p=0.222 n=5+5)
Insert10_Cockroach-4             689µs ± 9%     703µs ± 4%     ~             (p=0.222 n=5+5)
Insert100_Cockroach-4           3.49ms ± 2%    3.64ms ± 2%   +4.29%          (p=0.008 n=5+5)
Insert1000_Cockroach-4          33.2ms ± 3%    34.1ms ± 1%     ~             (p=0.095 n=5+5)
Update1_Cockroach-4              594µs ± 3%     559µs ± 1%   -6.00%          (p=0.008 n=5+5)
Update10_Cockroach-4            1.15ms ± 4%    1.21ms ± 2%   +5.51%          (p=0.008 n=5+5)
Update100_Cockroach-4           6.17ms ± 2%    6.44ms ± 2%   +4.23%          (p=0.008 n=5+5)
Update1000_Cockroach-4          52.7ms ± 3%    55.5ms ± 3%   +5.45%          (p=0.016 n=5+5)
Delete1_Cockroach-4              625µs ± 1%     611µs ± 2%   -2.34%          (p=0.008 n=5+5)
Delete10_Cockroach-4            1.83ms ± 4%    1.90ms ± 7%     ~             (p=0.151 n=5+5)
Delete100_Cockroach-4           14.8ms ± 2%    16.1ms ± 8%   +8.73%          (p=0.008 n=5+5)
Delete1000_Cockroach-4           140ms ± 5%     141ms ± 1%     ~             (p=0.690 n=5+5)
Scan1_Cockroach-4                207µs ± 2%     172µs ± 5%  -16.86%          (p=0.008 n=5+5)
Scan10_Cockroach-4               242µs ± 4%     230µs ± 8%   -5.18%          (p=0.032 n=5+5)
Scan100_Cockroach-4              500µs ± 2%     540µs ± 2%   +7.92%          (p=0.008 n=5+5)
Scan1000_Cockroach-4            2.98ms ± 1%    3.22ms ± 1%   +8.00%          (p=0.008 n=5+5)
Scan10000_Cockroach-4           30.5ms ± 1%    32.6ms ± 1%   +6.80%          (p=0.008 n=5+5)
Scan1000Limit1_Cockroach-4       218µs ± 1%     204µs ±14%     ~             (p=0.151 n=5+5)
Scan1000Limit10_Cockroach-4      253µs ± 4%     234µs ± 7%     ~             (p=0.056 n=5+5)
Scan1000Limit100_Cockroach-4     524µs ± 4%     568µs ± 5%   +8.47%          (p=0.008 n=5+5)

name                          old alloc/op   new alloc/op   delta
Select1_Cockroach-4             3.91kB ± 0%    3.91kB ± 0%     ~             (p=0.111 n=5+5)
Select2_Cockroach-4             80.7kB ± 0%    81.1kB ± 0%   +0.41%          (p=0.008 n=5+5)
Insert1_Cockroach-4             23.0kB ± 0%    23.4kB ± 0%   +1.59%          (p=0.008 n=5+5)
Insert10_Cockroach-4            67.2kB ± 0%    67.6kB ± 0%   +0.51%          (p=0.008 n=5+5)
Insert100_Cockroach-4            507kB ± 0%     508kB ± 0%   +0.08%          (p=0.032 n=5+5)
Insert1000_Cockroach-4          4.53MB ± 0%    4.58MB ± 1%   +1.06%          (p=0.008 n=5+5)
Update1_Cockroach-4             36.7kB ± 0%    37.5kB ± 0%   +1.97%          (p=0.008 n=5+5)
Update10_Cockroach-4            99.4kB ± 0%   100.1kB ± 0%   +0.76%          (p=0.008 n=5+5)
Update100_Cockroach-4            704kB ± 0%     707kB ± 0%   +0.42%          (p=0.016 n=5+5)
Update1000_Cockroach-4          6.08MB ± 1%    6.10MB ± 1%     ~             (p=0.222 n=5+5)
Delete1_Cockroach-4             29.8kB ± 0%    30.2kB ± 0%   +1.35%          (p=0.008 n=5+5)
Delete10_Cockroach-4            75.7kB ± 0%    76.1kB ± 0%   +0.60%          (p=0.008 n=5+5)
Delete100_Cockroach-4            537kB ± 0%     539kB ± 0%   +0.40%          (p=0.008 n=5+5)
Delete1000_Cockroach-4          4.81MB ± 0%    4.81MB ± 0%     ~             (p=0.190 n=4+5)
Scan1_Cockroach-4               13.3kB ± 0%    13.6kB ± 0%   +2.71%          (p=0.008 n=5+5)
Scan10_Cockroach-4              17.1kB ± 0%    17.5kB ± 0%   +2.23%          (p=0.008 n=5+5)
Scan100_Cockroach-4             49.4kB ± 0%    49.8kB ± 0%   +0.78%          (p=0.008 n=5+5)
Scan1000_Cockroach-4             331kB ± 0%     332kB ± 0%   +0.15%          (p=0.008 n=5+5)
Scan10000_Cockroach-4           5.72MB ± 0%    5.72MB ± 0%   +0.02%          (p=0.008 n=5+5)
Scan1000Limit1_Cockroach-4      14.0kB ± 0%    14.4kB ± 0%   +2.55%          (p=0.008 n=5+5)
Scan1000Limit10_Cockroach-4     17.9kB ± 0%    18.2kB ± 0%   +2.05%          (p=0.008 n=5+5)
Scan1000Limit100_Cockroach-4    50.0kB ± 0%    50.4kB ± 0%   +0.75%          (p=0.008 n=5+5)

name                          old allocs/op  new allocs/op  delta
Select1_Cockroach-4               97.0 ± 0%      97.0 ± 0%     ~     (all samples are equal)
Select2_Cockroach-4              2.70k ± 0%     2.70k ± 0%   +0.16%          (p=0.016 n=5+4)
Insert1_Cockroach-4                357 ± 0%       362 ± 0%   +1.46%          (p=0.008 n=5+5)
Insert10_Cockroach-4               907 ± 0%       912 ± 0%   +0.51%          (p=0.008 n=5+5)
Insert100_Cockroach-4            6.17k ± 0%     6.18k ± 0%   +0.07%          (p=0.016 n=5+5)
Insert1000_Cockroach-4           58.8k ± 0%     59.1k ± 0%   +0.54%          (p=0.008 n=5+5)
Update1_Cockroach-4                719 ± 0%       729 ± 0%   +1.45%          (p=0.016 n=5+4)
Update10_Cockroach-4             1.41k ± 0%     1.42k ± 0%   +0.73%          (p=0.008 n=5+5)
Update100_Cockroach-4            7.93k ± 0%     7.96k ± 0%   +0.42%          (p=0.008 n=5+5)
Update1000_Cockroach-4           70.0k ± 0%     70.1k ± 0%     ~             (p=0.151 n=5+5)
Delete1_Cockroach-4                567 ± 0%       572 ± 0%   +0.88%          (p=0.029 n=4+4)
Delete10_Cockroach-4             1.24k ± 0%     1.24k ± 0%   +0.49%          (p=0.029 n=4+4)
Delete100_Cockroach-4            7.68k ± 0%     7.69k ± 0%   +0.11%          (p=0.008 n=5+5)
Delete1000_Cockroach-4           71.7k ± 0%     71.7k ± 0%     ~             (p=0.317 n=4+5)
Scan1_Cockroach-4                  276 ± 0%       281 ± 0%   +1.81%          (p=0.008 n=5+5)
Scan10_Cockroach-4                 356 ± 0%       361 ± 0%   +1.52%          (p=0.016 n=5+4)
Scan100_Cockroach-4              1.08k ± 0%     1.09k ± 0%   +0.46%          (p=0.016 n=4+5)
Scan1000_Cockroach-4             8.29k ± 0%     8.30k ± 0%   +0.07%          (p=0.008 n=5+5)
Scan10000_Cockroach-4            80.4k ± 0%     80.5k ± 0%   +0.02%          (p=0.008 n=5+5)
Scan1000Limit1_Cockroach-4         298 ± 0%       303 ± 0%   +1.54%          (p=0.016 n=5+4)
Scan1000Limit10_Cockroach-4        378 ± 0%       383 ± 0%   +1.32%          (p=0.029 n=4+4)
Scan1000Limit100_Cockroach-4     1.10k ± 0%     1.11k ± 0%   +0.42%          (p=0.008 n=5+5)
```
tamird added a commit to tamird/cockroach that referenced this issue Mar 9, 2016
It turns out that accurately using cmux to sniff grpc connections is
hard. Most h2 clients behave as follows after connecting:

* S(Settings) -> S(WindowUpdate) -> R(SettingsAck) -> S(Headers)

Where S indicates sending and R indicates receiving.

grpc-go's h2 client behaves differently - it does not wait for the
SettingsAck. This allowed the old implementation to detect it based on
the headers it supplied, but broke all other h2 clients as connection
negotiation deadlocked.

This commit can be reverted wholesale when grpc.(*Server).ServeHTTP's
performance problems are addressed upstream.
See grpc/grpc-go#586.

Fixes cockroachdb#5020.
Fixes cockroachdb#5023.
tamird added a commit to tamird/cockroach that referenced this issue Mar 9, 2016
It turns out that accurately using cmux to sniff grpc connections is
hard. Most h2 clients behave as follows after connecting:

* S(Settings) -> S(WindowUpdate) -> R(SettingsAck) -> S(Headers)

Where S indicates sending and R indicates receiving.

grpc-go's h2 client behaves differently - it does not wait for the
SettingsAck. This allowed the old implementation to detect it based on
the headers it supplied, but broke all other h2 clients as connection
negotiation deadlocked.

This commit can be reverted wholesale when grpc.(*Server).ServeHTTP's
performance problems are addressed upstream.
See grpc/grpc-go#586.

Fixes cockroachdb#5020.
Fixes cockroachdb#5023.
tamird added a commit to tamird/cockroach that referenced this issue Mar 10, 2016
It turns out that accurately using cmux to sniff grpc connections is
hard. Most h2 clients behave as follows after connecting:

* S(Settings) -> S(WindowUpdate) -> R(SettingsAck) -> S(Headers)

Where S indicates sending and R indicates receiving.

grpc-go's h2 client behaves differently - it does not wait for the
SettingsAck. This allowed the old implementation to detect it based on
the headers it supplied, but broke all other h2 clients as connection
negotiation deadlocked.

This commit can be reverted wholesale when grpc.(*Server).ServeHTTP's
performance problems are addressed upstream.
See grpc/grpc-go#586.

Fixes cockroachdb#5020.
Fixes cockroachdb#5023.
tamird added a commit to tamird/cockroach that referenced this issue Mar 10, 2016
It turns out that accurately using cmux to sniff grpc connections is
hard. Most h2 clients behave as follows after connecting:

* S(Settings) -> S(WindowUpdate) -> R(SettingsAck) -> S(Headers)

Where S indicates sending and R indicates receiving.

grpc-go's h2 client behaves differently - it does not wait for the
SettingsAck. This allowed the old implementation to detect it based on
the headers it supplied, but broke all other h2 clients as connection
negotiation deadlocked.

This commit can be reverted wholesale when grpc.(*Server).ServeHTTP's
performance problems are addressed upstream.
See grpc/grpc-go#586.

Fixes cockroachdb#5020.
Fixes cockroachdb#5023.
@tamird

This comment has been minimized.

Copy link
Contributor Author

@tamird tamird commented May 4, 2016

@bradfitz any progress on this?

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented May 4, 2016

No, I've been busy with Go 1.7 stuff for the May 1st freeze. Hopefully I can spend a bit of time on this soon, but then I'm out for a month starting in a couple weeks.

@mwitkow

This comment has been minimized.

Copy link
Contributor

@mwitkow mwitkow commented May 16, 2016

@bradfitz is there some way in which we could help? :)

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented May 16, 2016

is there some way in which we could help? :)

Sure. Look at the http2 code and find ways to improve it, while not hurting readability or maintainability.

@mwitkow

This comment has been minimized.

Copy link
Contributor

@mwitkow mwitkow commented May 16, 2016

Any pointers as to how to start? Is there any particular test you pprof to find bottlenecks? :)

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented May 16, 2016

Honestly I forget. That code was mostly written for correctness and not performance. There's probably a lot of low-hanging fruit in there but there might not even be enough benchmarks yet to start using pprof & friends. You'd probably have to write at least a few new ones.

@tamird

This comment has been minimized.

Copy link
Contributor Author

@tamird tamird commented Jul 28, 2016

@iamqizhao this is a serious issue - can we include it for GA?

@iamqizhao

This comment has been minimized.

Copy link
Contributor

@iamqizhao iamqizhao commented Jul 28, 2016

@tamird Sorry. We are approaching GA very closely and so far this is treated as an experimental effort and we do not expect the real usage for this feature at the current stage. This is in Brad's plate and I am going to talk to him after GA to see how to make progress on this.

@tamird

This comment has been minimized.

Copy link
Contributor Author

@tamird tamird commented Mar 13, 2017

This is still a major inconvenience for us. I've updated the performance numbers at https://github.com/cockroachdb/rpc-bench; the relevant ones are:

name                         time/op
GRPCServe_1K-24                40.5µs ± 1%
GRPCServe_64K-24                365µs ± 1%
GRPCServe_Stream_1K-24         22.7µs ± 1%
GRPCServe_Stream_64k-24         298µs ± 1%
GRPCServeHTTP_1K-24             137µs ± 1%
GRPCServeHTTP_64K-24            585µs ± 1%
GRPCServeHTTP_Stream_1K-24     38.7µs ± 1%
GRPCServeHTTP_Stream_64k-24     455µs ± 1%

name                         speed
GRPCServe_1K-24              50.5MB/s ± 1%
GRPCServe_64K-24              359MB/s ± 1%
GRPCServe_Stream_1K-24       90.3MB/s ± 1%
GRPCServe_Stream_64k-24       439MB/s ± 1%
GRPCServeHTTP_1K-24          14.9MB/s ± 1%
GRPCServeHTTP_64K-24          224MB/s ± 1%
GRPCServeHTTP_Stream_1K-24   52.9MB/s ± 1%
GRPCServeHTTP_Stream_64k-24   288MB/s ± 1%

name                         alloc/op
GRPCServe_1K-24                16.3kB ± 0%
GRPCServe_64K-24                711kB ± 0%
GRPCServe_Stream_1K-24         11.6kB ± 0%
GRPCServe_Stream_64k-24         707kB ± 0%
GRPCServeHTTP_1K-24            34.2kB ± 0%
GRPCServeHTTP_64K-24            763kB ± 0%
GRPCServeHTTP_Stream_1K-24     12.4kB ± 0%
GRPCServeHTTP_Stream_64k-24     739kB ± 0%

name                         allocs/op
GRPCServe_1K-24                  97.0 ± 0%
GRPCServe_64K-24                  147 ± 0%
GRPCServe_Stream_1K-24           22.0 ± 0%
GRPCServe_Stream_64k-24          72.0 ± 0%
GRPCServeHTTP_1K-24               169 ± 0%
GRPCServeHTTP_64K-24              275 ± 0%
GRPCServeHTTP_Stream_1K-24       29.0 ± 0%
GRPCServeHTTP_Stream_64k-24       138 ± 0%

So ServeHTTP's throughput is 50%-70% lower than Serve's, and its latency is 60%-350% higher.

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Mar 13, 2017

@tamird, the grpc-go team is undergoing a changing of the guard at the moment so this isn't much of a priority.

And I don't officially work on grpc-go. It's not surprising that ServeHTTP is slower considering it's shoehorned into the existing ServerTransport interface somewhat awkwardly.

I started working on a new design for all of grpc-go in https://github.com/bradfitz/grpc-go but it's not ready yet for wider discussion or testing. It was mostly a proof of concept. But it's something I intend to get back to. @philips et al at CoreOS are also interested.

@Iulian7

This comment has been minimized.

Copy link

@Iulian7 Iulian7 commented May 3, 2017

Is there any update on this?

@hsaliak

This comment has been minimized.

Copy link

@hsaliak hsaliak commented May 16, 2017

@menghanl would you be able to take a look?

@mwitkow

This comment has been minimized.

Copy link
Contributor

@mwitkow mwitkow commented Jun 4, 2017

@dfawley this is the bug I mentioned in person at CoreOS Fest. Would be fantastic if we could reach serving parity on the HandlerTransport to the one with a pure socket listener.

@dfawley

This comment has been minimized.

Copy link
Contributor

@dfawley dfawley commented Jun 5, 2017

I agree, but unfortunately we won't have any time to spend on this for at least another quarter. It will be a pretty sizable effort. It's possible we may get some contributions for this before then, but I wouldn't want to set any expectations at this point.

@glerchundi

This comment has been minimized.

Copy link

@glerchundi glerchundi commented Feb 26, 2018

at least another quarter

Now that one quarter has passed, any chance to make any progress on this?

@dfawley

This comment has been minimized.

Copy link
Contributor

@dfawley dfawley commented Feb 26, 2018

@mwitkow, @tamird, @glerchundi, I have been poking at this periodically and learning more about it since June.

The goal of throwing away the grpc http2 server and using x/net/http2 instead would be a major undertaking, and would require adding significant new features and hooks and (likely) optimizations into x/net/http2 to reach parity with the existing grpc http2 server. The handler-based transport was/is an experiment (and is documented as such), and isn't something fully supported. The core grpc-go team does not currently have the cycles to support this and keep up with our existing commitments -- let alone to completely replace our default transport with it -- but we would be happy to review PRs that improve features or performance of the handler-based transport.

Re: @bradfitz's comment:

It's not surprising that ServeHTTP is slower considering it's shoehorned into the existing
ServerTransport interface somewhat awkwardly.

I agree this is an awkward fit: the handler-based transport is mimicking a full transport for each RPC. As we continue to dig in and clean up some of the code and interfaces between the grpc layer and the transport layer (e.g.s #1745, #1854), it could happen that the handler-based transport becomes a more natural fit, and performance may be improved as a result if that is a factor in its performance differences.

@mofirouz

This comment has been minimized.

Copy link

@mofirouz mofirouz commented Mar 19, 2019

Is this performance still an issue given the use of grpc.ServerHTTP?

I'm weighing on whether we should wrap gRPC's server with net/http server as I need to define / as healthcheck so that it will pass GCLB?

@snowzach

This comment has been minimized.

Copy link

@snowzach snowzach commented Apr 6, 2019

@tamird is this still an issue for you guys?

@tamird

This comment has been minimized.

Copy link
Contributor Author

@tamird tamird commented Apr 6, 2019

I don't work on CockroachDB anymore, but it should be trivial for you to replicate my results using rpc-bench.

I can post new results on Monday if you'd like. Has any work been done in this area? I haven't seen any mention.

srenatus added a commit to chef/automate that referenced this issue May 22, 2019
This was carried over from some ancient grpc-gateway example code[1]; and
we're not exposing the GRPC API that way right now.

Using (*grpc.Server).ServeHTTP has some issues:

1. it's known to be slow, very slow[2]
2. it's seems to be not working with go-grpc >= 1.19 [3]

Furthermore, we're exposing the proper GRPC server (the native go-grpc
one) on a different port. If decide to (finally!) expose our GRPC API,
that's the thing we should expose.

So, since we don't need this multiplexing business, we shouldn't keep
the code around. This is the cleanup.

[1]: https://github.com/philips/grpc-gateway-example/
[2]: grpc/grpc-go#586
[3]: soheilhy/cmux#64 (comment)

Signed-off-by: Stephan Renatus <srenatus@chef.io>
srenatus added a commit to chef/automate that referenced this issue May 22, 2019
This was carried over from some ancient grpc-gateway example code[1]; and
we're not exposing the GRPC API that way right now.

Using (*grpc.Server).ServeHTTP has some issues:

1. it's known to be slow, very slow[2]
2. it's seems to be not working with go-grpc >= 1.19 [3]

Furthermore, we're exposing the proper GRPC server (the native go-grpc
one) on a different port. If decide to (finally!) expose our GRPC API,
that's the thing we should expose.

So, since we don't need this multiplexing business, we shouldn't keep
the code around. This is the cleanup.

[1]: https://github.com/philips/grpc-gateway-example/
[2]: grpc/grpc-go#586
[3]: soheilhy/cmux#64 (comment)

Signed-off-by: Stephan Renatus <srenatus@chef.io>
srenatus added a commit to chef/automate that referenced this issue May 22, 2019
* automate-gateway: cleanup GRPC/HTTP multiplexing cruft

This was carried over from some ancient grpc-gateway example code[1]; and
we're not exposing the GRPC API that way right now.

Using (*grpc.Server).ServeHTTP has some issues:

1. it's known to be slow, very slow[2]
2. it's seems to be not working with go-grpc >= 1.19 [3]

Furthermore, we're exposing the proper GRPC server (the native go-grpc
one) on a different port. If decide to (finally!) expose our GRPC API,
that's the thing we should expose.

So, since we don't need this multiplexing business, we shouldn't keep
the code around. This is the cleanup.

[1]: https://github.com/philips/grpc-gateway-example/
[2]: grpc/grpc-go#586
[3]: soheilhy/cmux#64 (comment)

* [integration] automate-gateway: fix tests to use GRPC port

So apparently these HAD used the multiplexing code I've deleted. Well,
they don't have to. Changed the hardcoded port to automate-gateway's
default grpc port.

Signed-off-by: Stephan Renatus <srenatus@chef.io>
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Sep 6, 2019

This issue is labeled as requiring an update from the reporter, and no update has been received after 7 days. If no update is provided in the next 7 days, this issue will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.