Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

更新了网易云音乐的下载 #2552

Closed
wants to merge 4 commits into from
Closed

更新了网易云音乐的下载 #2552

wants to merge 4 commits into from

Conversation

XenosLu
Copy link

@XenosLu XenosLu commented Jan 4, 2018

更新了网易云音乐的下载,增加了新的依赖pycrypto,用于AES加密。
代码及算法大部分来自https://github.com/Chengyumeng/spider163,该项目使用MIT协议。
在py3.4+win及docker+alpine3.7+py3.6的环境下测试通过。

(PLEASE DELETE ALL THESE AFTER READING)

Thank you for the pull request! you-get is a growing open source project, which would not have been possible without contributors like you.

Here are some simple rules to follow, please recheck them before sending the pull request:

  • If you want to propose two or more unrelated patches, please open separate pull requests for them, instead of one;
  • All pull requests should be based upon the latest develop branch;
  • Name your branch (from which you will send the pull request) properly; use a meaningful name like add-this-shining-feature rather than just develop;
  • All commit messages, as well as comments in code, should be written in understandable English.

As a contributor, you must be aware that

  • You agree to contribute your code to this project, under the terms of the MIT license, so that any person may freely use or redistribute them; of course, you will still reserve the copyright for your own authorship.
  • You may not contribute any code not authored by yourself, unless they are licensed under either public domain or the MIT license, literally.

Not all pull requests can eventually be merged. I consider merged / unmerged patches as equally important for the community: as long as you think a patch would be helpful, someone else might find it helpful, too, therefore they could take your fork and benefit in some way. In any case, I would like to thank you in advance for taking your time to contribute to this project.

Cheers,
Mort

(PLEASE REPLACE ALL ABOVE WITH A DETAILED DESCRIPTION OF YOUR PULL REQUEST)

汉语翻译最后日期:2016年02月26日

(阅读后请删除所有内容)

感谢您的pull request! you-get是稳健成长的开源项目,感谢您的贡献.

以下简单检查项目望您复查:

  • 如果您预计提出两个或更多不相关补丁,请为每个使用不同的pull requests,而不是单一;
  • 所有的pull requests应基于最新的develop分支;
  • 您预计提出pull requests的分支应有有意义名称,例如add-this-shining-feature而不是develop;
  • 所有的提交信息与代码中注释应使用可理解的英语.

作为贡献者,您需要知悉

  • 您同意在MIT协议下贡献代码,以便任何人自由使用或分发;当然,你仍旧保留代码的著作权
  • 你不得贡献非自己编写的代码,除非其属于公有领域或使用MIT协议.

不是所有的pull requests都会被合并,然而我认为合并/不合并的补丁一样重要:如果您认为补丁重要,其他人也有可能这么认为,那么他们可以从你的fork中提取工作并获益。无论如何,感谢您费心对本项目贡献.

祝好,
Mort

(请将本内容完整替换为PULL REQUEST的详细内容)

@soimort-bot
Copy link
Collaborator

Hello @XenosLu,
Thanks for the Pull Request. We ❤️ our contributors!
Please wait for one of our human maintainers to review your patches. This may take a few days to weeks. Also, please understand that although your Pull Request may or may not be eventually merged, we value all contributions equally.

祝您健康!

@wang1365
Copy link

wang1365 commented Jan 4, 2018

You missed adding dependencies in setup.py. But on the other hand, current you-get seems not depend on
any other third library. I guess soimort prefers to keep you-get pure with no external dependency.

@mengmo
Copy link

mengmo commented Jan 4, 2018

@XenosLu see this pycrypto/pycrypto#238

@MxqingDesign
Copy link

MxqingDesign commented Feb 10, 2018

希望能打包exe格式的you-get.exe

@jzh20042003
Copy link

下载youtube视频默认不是最高清晰度 建议修复这个问题 或者像是youtube-dl那样增加一个-f best自动选择最高清晰度 我没法开新问题 所以在这里说

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants