Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vercel deployment #15

Merged
merged 2 commits into from
Aug 1, 2022
Merged

fix vercel deployment #15

merged 2 commits into from
Aug 1, 2022

Conversation

bukatea
Copy link
Contributor

@bukatea bukatea commented Aug 1, 2022

fixes #14

adds documentation in SETUP.md too

@sevazhidkov

@socket-security
Copy link

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
@parcel/watcher@2.0.4 (added) binding.gyp package.json via lerna@5.3.0, nx@14.5.1
nx@14.5.1 (added) postinstall package.json via lerna@5.3.0
@parcel/watcher@2.0.4 (added) install package.json via lerna@5.3.0, nx@14.5.1
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Package Location
@parcel/watcher@2.0.4 (added) package.json via lerna@5.3.0, nx@14.5.1
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 3 new install scripts detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ⚠️ 1 new native module detected

Powered by socket.dev

SETUP.md Outdated

These `__PLACEHOLDER__` values must also change.

- `TRANSFER_MINT` is the base58 encoded public key of an SPL token mint.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, just mint and account? I think TRANSFER_MINT and TRANSFER_ACCOUNT is not longer in use.

@sevazhidkov
Copy link
Collaborator

Thank you so much for the contribution!

Left a tiny docs nit + let's delete .DS_Store from the PR (and, maybe, add it to .gitignore, while we're at it?).

@bukatea
Copy link
Contributor Author

bukatea commented Aug 1, 2022

No problem, always happy to help!

Oops, yeah I thought I didn't commit .DS_Store but I guess I did. I removed them and added to the .gitignore, and addressed the nit (also oops).

@jordaaash jordaaash merged commit 6ccc2ec into anza-xyz:master Aug 1, 2022
@jordaaash
Copy link
Collaborator

Thank you both!

@bukatea bukatea deleted the vercel-fix branch August 1, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vercel deployment on current master branch not working
3 participants