Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rate limiter middleware's default key is
req.ip
but there doesn't appear to be a property calledip
on the request that we pass to it here. The actual object we give it is anIncomingMessage
and the IP is available assocket.remoteAddress
or in the headers.In this PR, we teach the rate limiter middleware to source the IP address from the
x-real-ip
header first, and theremoteAddress
on the socket second.