Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(experimental): errors: accounts package #2186

Merged

Conversation

buffalojoec
Copy link
Collaborator

Adds custom SolanaError throws to the @solana/accounts package.

Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looksgood

packages/accounts/src/decode-account.ts Outdated Show resolved Hide resolved
@steveluscher steveluscher force-pushed the 02-24-refactor_experimental_errors_context_sort_keys branch from 1e59cea to 2e24e77 Compare February 29, 2024 19:28
@steveluscher steveluscher force-pushed the 02-24-refactor_experimental_errors_accounts_package branch from a3b445e to 1bc1537 Compare February 29, 2024 19:28
@steveluscher
Copy link
Collaborator

steveluscher commented Feb 29, 2024

Merge activity

  • Feb 29, 11:33 AM PST: @steveluscher started a stack merge that includes this pull request via Graphite.
  • Feb 29, 11:36 AM PST: Graphite rebased this pull request as part of a merge.
  • Feb 29, 11:36 AM PST: @steveluscher merged this pull request with Graphite.

@steveluscher steveluscher force-pushed the 02-24-refactor_experimental_errors_context_sort_keys branch from 2e24e77 to b4236c4 Compare February 29, 2024 19:33
Base automatically changed from 02-24-refactor_experimental_errors_context_sort_keys to master February 29, 2024 19:35
@steveluscher steveluscher force-pushed the 02-24-refactor_experimental_errors_accounts_package branch from 1bc1537 to 8608dc7 Compare February 29, 2024 19:35
@steveluscher steveluscher merged commit 546263e into master Feb 29, 2024
6 checks passed
@steveluscher steveluscher deleted the 02-24-refactor_experimental_errors_accounts_package branch February 29, 2024 19:36
Copy link
Contributor

github-actions bot commented Mar 2, 2024

🎉 This PR is included in version 1.90.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[experimental] Convert all thrown errors to SolanaError
3 participants