Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(experimental): errors: codecs-core package #2189

Merged
merged 1 commit into from
Feb 29, 2024
Merged

refactor(experimental): errors: codecs-core package #2189

merged 1 commit into from
Feb 29, 2024

Conversation

buffalojoec
Copy link
Collaborator

Adds custom SolanaError throws to the @solana/codecs-core package.

This was referenced Feb 24, 2024
Merged
Merged
Merged
@buffalojoec Graphite App
Copy link
Collaborator Author

buffalojoec commented Feb 24, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Feb 24, 2024
Merged
Merged
Merged
Merged
Merged
@mergify mergify bot added the community label Feb 24, 2024
@buffalojoec buffalojoec force-pushed the 02-24-refactor_experimental_errors_codecs-core_package branch from 034a1cd to 3d57efe Compare February 24, 2024 21:10
lorisleiva
lorisleiva requested changes Feb 25, 2024
View reviewed changes
packages/errors/src/messages.ts Outdated Show resolved Hide resolved
@steveluscher steveluscher linked an issue Feb 26, 2024 that may be closed by this pull request
[experimental] Convert all thrown errors to SolanaError #2118
Closed
@buffalojoec buffalojoec force-pushed the 02-24-refactor_experimental_errors_assertions_package branch from ec6802f to 51680e6 Compare February 27, 2024 07:32
@buffalojoec buffalojoec force-pushed the 02-24-refactor_experimental_errors_codecs-core_package branch from 3d57efe to 7c56328 Compare February 27, 2024 07:32
@buffalojoec buffalojoec changed the base branch from 02-24-refactor_experimental_errors_assertions_package to 02-27-refactor_experimental_codecs_use_bigint_for_range_values_on_u64_and_u128_ February 27, 2024 07:32
This was referenced Feb 27, 2024
Merged
Merged
Merged
@lorisleiva lorisleiva mentioned this pull request Feb 27, 2024
Closed
steveluscher
steveluscher approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

packages/codecs-core/src/reverse-codec.ts Outdated Show resolved Hide resolved
packages/codecs-core/src/reverse-codec.ts Outdated Show resolved Hide resolved
packages/errors/src/message-formatter.ts Outdated Show resolved Hide resolved
@buffalojoec buffalojoec force-pushed the 02-27-refactor_experimental_codecs_use_bigint_for_range_values_on_u64_and_u128_ branch from 6f0e341 to 692c164 Compare February 28, 2024 16:30
@buffalojoec buffalojoec force-pushed the 02-24-refactor_experimental_errors_codecs-core_package branch from 7c56328 to 6cfd2d2 Compare February 28, 2024 16:30
@steveluscher steveluscher mentioned this pull request Feb 28, 2024
Merged
@buffalojoec buffalojoec mentioned this pull request Feb 29, 2024
Merged
This was referenced Feb 29, 2024
Merged
Merged
This was referenced Feb 29, 2024
Merged
Merged
@steveluscher steveluscher force-pushed the 02-27-refactor_experimental_codecs_use_bigint_for_range_values_on_u64_and_u128_ branch from 692c164 to 1a20e1f Compare February 29, 2024 19:28
@steveluscher steveluscher force-pushed the 02-24-refactor_experimental_errors_codecs-core_package branch from 6cfd2d2 to 7dcd11a Compare February 29, 2024 19:28
@steveluscher
Copy link
Collaborator

steveluscher commented Feb 29, 2024 •
edited
Loading

Merge activity

  • Feb 29, 11:33 AM PST: @steveluscher started a stack merge that includes this pull request via Graphite.
  • Feb 29, 11:46 AM PST: Graphite rebased this pull request as part of a merge.
  • Feb 29, 11:47 AM PST: @steveluscher merged this pull request with Graphite.

@steveluscher steveluscher force-pushed the 02-27-refactor_experimental_codecs_use_bigint_for_range_values_on_u64_and_u128_ branch from 1a20e1f to 0ae2707 Compare February 29, 2024 19:43
Base automatically changed from 02-27-refactor_experimental_codecs_use_bigint_for_range_values_on_u64_and_u128_ to master February 29, 2024 19:45
@steveluscher steveluscher force-pushed the 02-24-refactor_experimental_errors_codecs-core_package branch from 7dcd11a to 5cc544e Compare February 29, 2024 19:46
@steveluscher steveluscher merged commit 7712fc3 into master Feb 29, 2024
7 checks passed
@steveluscher steveluscher deleted the 02-24-refactor_experimental_errors_codecs-core_package branch February 29, 2024 19:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 2, 2024

🎉 This PR is included in version 1.90.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveluscher steveluscher steveluscher approved these changes

@lorisleiva lorisleiva Awaiting requested review from lorisleiva

Assignees
No one assigned
Labels
community released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[experimental] Convert all thrown errors to SolanaError
3 participants
@buffalojoec @steveluscher @lorisleiva