refactor(experimental): errors: assertions package
#2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2024
buffalojoec
changed the title
assertions package
buffalojoec
force-pushed
the
02-24-refactor_experimental_errors_assertions_package
branch
from
e7fb883
to
325f801
Compare
buffalojoec
force-pushed
the
02-24-refactor_experimental_errors_addresses_package
branch
from
1b48e25
to
91b4a68
Compare
buffalojoec
force-pushed
the
02-24-refactor_experimental_errors_assertions_package
branch
from
325f801
to
ec6802f
Compare
This was referenced Feb 24, 2024
lorisleiva
requested changes
Feb 25, 2024
buffalojoec
force-pushed
the
02-24-refactor_experimental_errors_addresses_package
branch
from
91b4a68
to
2bf93b9
Compare
buffalojoec
force-pushed
the
02-24-refactor_experimental_errors_assertions_package
branch
from
ec6802f
to
51680e6
Compare
This was referenced Feb 27, 2024
steveluscher
approved these changes
Feb 27, 2024
| 'Cryptographic operations are only allowed in secure browser contexts. Read more ' + | ||
| 'here: https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts', | ||
| ); | ||
| throw new SolanaError(SOLANA_ERROR__SUBTLE_CRYPTO_MISSING); |
There was a problem hiding this comment.
I mean, as a corollary yes, but the actual error is SOLANA_ERROR__CRYPTO_DISALLOWED_IN_INSECURE_CONTEXT or something.
There was a problem hiding this comment.
…like, SubtleCrypto can be missing for other reasons, like the environment is otherwise ‘secure’ but just doesn't support SubtleCrypto.
There was a problem hiding this comment.
I went for SOLANA_ERROR__SUBTLE_CRYPTO_DISALLOWED_IN_INSECURE_CONTEXT in the feedback PR.
I also changes the _MISSING suffixes with _UNIMPLEMENTED as you suggested and added a description for it in the comments.
buffalojoec
force-pushed
the
02-24-refactor_experimental_errors_addresses_package
branch
from
2bf93b9
to
b10a9e8
Compare
buffalojoec
force-pushed
the
02-24-refactor_experimental_errors_assertions_package
branch
from
51680e6
to
37bdedc
Compare
This was referenced Feb 28, 2024
This was referenced Feb 29, 2024
steveluscher
force-pushed
the
02-24-refactor_experimental_errors_addresses_package
branch
from
b10a9e8
to
bb22886
Compare
steveluscher
force-pushed
the
02-24-refactor_experimental_errors_assertions_package
branch
from
37bdedc
to
2ae6db6
Compare
Merge activity
|
steveluscher
force-pushed
the
02-24-refactor_experimental_errors_addresses_package
branch
from
bb22886
to
16ce665
Compare
Base automatically changed from
02-24-refactor_experimental_errors_addresses_package
to
master
February 29, 2024 19:38
steveluscher
force-pushed
the
02-24-refactor_experimental_errors_assertions_package
branch
from
2ae6db6
to
54664fb
Compare
steveluscher
deleted the
02-24-refactor_experimental_errors_assertions_package
branch
steveluscher
pushed a commit
that referenced
this pull request
Feb 29, 2024
…tions (#2200) As mentioned in [this PR comment](#2188 (comment)), if you need to provide some kind of "reason" or "message" to an error, it's usually a smell. Now that we have custom error codes and can perform proper error handling, we can replace this mechanism for piping error messages (effectively "reasons") to fixed codec assertions! This change refactors out `message` from `assertIsFixed`. In a later commit, I'll replace the thrown error with a coded `SolanaError` and add the necessary `catch` statements downstream.
|
🎉 This PR is included in version 1.90.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom
SolanaErrorthrows to the@solana/assertionspackage.