excludes caller's crds values from pull responses #17542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the crds entry belongs to the caller itself, then the caller will always have the more recent version of it, regardless of it being filtered out by the bloom filter or not. The exception is node-instance types which are meant to detect duplicate running instances, and those are exempted.
Codecov Report
@@ Coverage Diff @@
## master #17542 +/- ##
=======================================
Coverage 82.6% 82.6%
=======================================
Files 427 427
Lines 119146 119149 +3
=======================================
+ Hits 98476 98483 +7
+ Misses 20670 20666 -4 |
carllin
approved these changes
May 27, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 4, 2021
If the crds entry belongs to the caller itself, then the caller will always have the more recent version of it, regardless of it being filtered out by the bloom filter or not. The exception is node-instance types which are meant to detect duplicate running instances, and those are exempted. (cherry picked from commit 7cf6e66)
mergify bot
added a commit
that referenced
this pull request
Jun 4, 2021
If the crds entry belongs to the caller itself, then the caller will always have the more recent version of it, regardless of it being filtered out by the bloom filter or not. The exception is node-instance types which are meant to detect duplicate running instances, and those are exempted. (cherry picked from commit 7cf6e66) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Closed
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Sep 27, 2021
solana-labs#17542 excludes caller's crds values from pull responses. Reverting that commit so that when a (staked) node restarts, it can obtain its crds values before restart from other nodes.
Merged
behzadnouri
added a commit
that referenced
this pull request
Sep 27, 2021
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
solana-labs#17542 excludes caller's crds values from pull responses. Reverting that commit so that when a (staked) node restarts, it can obtain its crds values before restart from other nodes.
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit 71239fd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the crds entry belongs to the caller itself, then the caller will
always have the more recent version of it, regardless of it being
filtered out by the bloom filter or not.
The exception is node-instance types which are meant to detect duplicate
running instances, and those are exempted.
Summary of Changes