reverts #17542 #20259
Merged
reverts #17542 #20259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solana-labs#17542 excludes caller's crds values from pull responses. Reverting that commit so that when a (staked) node restarts, it can obtain its crds values before restart from other nodes.
Codecov Report
@@ Coverage Diff @@
## master #20259 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 487 487
Lines 135452 135449 -3
=======================================
+ Hits 112167 112217 +50
+ Misses 23285 23232 -53 |
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
solana-labs#17542 excludes caller's crds values from pull responses. Reverting that commit so that when a (staked) node restarts, it can obtain its crds values before restart from other nodes.
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit 71239fd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#17542
excludes caller's crds values from pull responses.
As a result when a (staked) node restarts, other nodes have crds values
associated with this node, that the node itself does not have.
Summary of Changes
Reverting that commit so that when a (staked) node restarts, it can
obtain its crds values before restart from other nodes.