allows private addresses if not public network #19130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvines any objection to merging this? |
mvines
approved these changes
Aug 10, 2021
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Aug 11, 2021
Following solana-labs#19130 if gce.sh creat is invoked without -P then --allow-private-addr is implied: https://github.com/solana-labs/solana/blob/4cc1b1504/net/common.sh#L68-L73 Therefore tests only need to specify: USE_PUBLIC_IP_ADDRESSES: "false"
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Aug 11, 2021
Following solana-labs#19130 if gce.sh creat is invoked without -P then --allow-private-addr is implied: https://github.com/solana-labs/solana/blob/4cc1b1504/net/common.sh#L68-L73 Therefore tests only need to specify: USE_PUBLIC_IP_ADDRESSES: "false"
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Aug 11, 2021
Following solana-labs#19130 if gce.sh creat is invoked without -P then --allow-private-addr is implied: https://github.com/solana-labs/solana/blob/4cc1b1504/net/common.sh#L68-L73 Therefore tests only need to specify: USE_PUBLIC_IP_ADDRESSES: "false"
behzadnouri
added a commit
that referenced
this pull request
Aug 13, 2021
Following #19130 if gce.sh creat is invoked without -P then --allow-private-addr is implied: https://github.com/solana-labs/solana/blob/4cc1b1504/net/common.sh#L68-L73 Therefore tests only need to specify: USE_PUBLIC_IP_ADDRESSES: "false"
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2021
Following #19130 if gce.sh creat is invoked without -P then --allow-private-addr is implied: https://github.com/solana-labs/solana/blob/4cc1b1504/net/common.sh#L68-L73 Therefore tests only need to specify: USE_PUBLIC_IP_ADDRESSES: "false" (cherry picked from commit 18463aa) # Conflicts: # system-test/partition-testcases/gce-5-node-3-partition.yml # system-test/partition-testcases/gce-partition-once-then-stabilize.yml # system-test/partition-testcases/gce-partition-with-offline.yml
mergify bot
added a commit
that referenced
this pull request
Sep 27, 2021
…20238) * removes use of public ip addresses from system tests Using global IPs causes outbound traffic which costs money: #18728 (comment) (cherry picked from commit bd8f793) * removes redundant allow-private-addr from system tests Following #19130 if gce.sh creat is invoked without -P then --allow-private-addr is implied: https://github.com/solana-labs/solana/blob/4cc1b1504/net/common.sh#L68-L73 Therefore tests only need to specify: USE_PUBLIC_IP_ADDRESSES: "false" (cherry picked from commit 18463aa) # Conflicts: # system-test/partition-testcases/gce-5-node-3-partition.yml # system-test/partition-testcases/gce-partition-once-then-stabilize.yml # system-test/partition-testcases/gce-partition-with-offline.yml * removes backport merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
./net.shneeds--allow-private-addrifgce.sh createwas invoked without-P.Summary of Changes
When loading config file, if not a public network add
--allow-private-addr.