removes use of public ip addresses from perf tests #19184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using global IPs causes outbound traffic which costs money: #18728 (comment)
Also, following #19130 if
gce.sh creat
is invoked without-P
then--allow-private-addr
is implied:https://github.com/solana-labs/solana/blob/4cc1b1504/net/common.sh#L68-L73
Therefore tests only need to specify:
Summary of Changes
USE_PUBLIC_IP_ADDRESSES: "false"
.ALLOW_PRIVATE_ADDR