-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checks for authorized voter early on in the vote-listener pipeline #22169
checks for authorized voter early on in the vote-listener pipeline #22169
Conversation
28e6839
to
9a8d645
Compare
9a8d645
to
a39eaca
Compare
Before votes are verified that they are signed by the authorized voter, they might be dropped in verified-vote-packets code. If there are enough many spam votes from unauthorized voters, this may potentially drop valid votes but keep the false ones. https://github.com/solana-labs/solana/blob/57986f982/core/src/verified_vote_packets.rs#L165-L168
a39eaca
to
e6deb59
Compare
Now that we've moved the authorized voter check earlier, can we delete this later authorized voter check? solana/core/src/cluster_info_vote_listener.rs Lines 841 to 847 in e6deb59
|
yeah, I think we can remove that. |
Codecov Report
@@ Coverage Diff @@
## master #22169 +/- ##
=========================================
- Coverage 81.1% 81.1% -0.1%
=========================================
Files 521 521
Lines 146316 146340 +24
=========================================
+ Hits 118802 118810 +8
- Misses 27514 27530 +16 |
…22169) Before votes are verified that they are signed by the authorized voter, they might be dropped in verified-vote-packets code. If there are enough many spam votes from unauthorized voters, this may potentially drop valid votes but keep the false ones. https://github.com/solana-labs/solana/blob/57986f982/core/src/verified_vote_packets.rs#L165-L168 (cherry picked from commit c0c6038) # Conflicts: # core/src/cluster_info_vote_listener.rs
solana-labs#22169 verifies authorized-voter early on in vote-listener; so VoteTracker no longer needs to maintain and check for epoch authorized voters.
solana-labs#22169 verifies authorized-voter early on in vote-listener pipeline; and so VoteTracker no longer needs to maintain and check for epoch authorized voters.
…ackport #22169) (#22188) * checks for authorized voter early on in the vote-listener pipeline (#22169) Before votes are verified that they are signed by the authorized voter, they might be dropped in verified-vote-packets code. If there are enough many spam votes from unauthorized voters, this may potentially drop valid votes but keep the false ones. https://github.com/solana-labs/solana/blob/57986f982/core/src/verified_vote_packets.rs#L165-L168 (cherry picked from commit c0c6038) # Conflicts: # core/src/cluster_info_vote_listener.rs * removes backport merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
solana-labs#22169 verifies authorized-voter early on in vote-listener pipeline; and so VoteTracker no longer needs to maintain and check for epoch authorized voters.
solana-labs#22169 verifies authorized-voter early on in vote-listener pipeline; and so VoteTracker no longer needs to maintain and check for epoch authorized voters.
solana-labs#22169 verifies authorized-voter early on in vote-listener pipeline; and so VoteTracker no longer needs to maintain and check for epoch authorized voters.
…22169) Before votes are verified that they are signed by the authorized voter, they might be dropped in verified-vote-packets code. If there are enough many spam votes from unauthorized voters, this may potentially drop valid votes but keep the false ones. https://github.com/solana-labs/solana/blob/57986f982/core/src/verified_vote_packets.rs#L165-L168 (cherry picked from commit c0c6038) # Conflicts: # core/src/cluster_info_vote_listener.rs
…ackport #22169) (#22206) * checks for authorized voter early on in the vote-listener pipeline (#22169) Before votes are verified that they are signed by the authorized voter, they might be dropped in verified-vote-packets code. If there are enough many spam votes from unauthorized voters, this may potentially drop valid votes but keep the false ones. https://github.com/solana-labs/solana/blob/57986f982/core/src/verified_vote_packets.rs#L165-L168 (cherry picked from commit c0c6038) # Conflicts: # core/src/cluster_info_vote_listener.rs * removes backport merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
solana-labs#22169 verifies authorized-voter early on in vote-listener pipeline; and so VoteTracker no longer needs to maintain and check for epoch authorized voters.
#22169 verifies authorized-voter early on in vote-listener pipeline; and so VoteTracker no longer needs to maintain and check for epoch authorized voters.
…22248) * removes epoch_authorized_voters from VoteTracker (#22192) #22169 verifies authorized-voter early on in vote-listener pipeline; and so VoteTracker no longer needs to maintain and check for epoch authorized voters. (cherry picked from commit 69d71f8) # Conflicts: # core/src/cluster_info_vote_listener.rs * removes backport merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
…22250) * removes epoch_authorized_voters from VoteTracker (#22192) #22169 verifies authorized-voter early on in vote-listener pipeline; and so VoteTracker no longer needs to maintain and check for epoch authorized voters. (cherry picked from commit 69d71f8) # Conflicts: # core/src/cluster_info_vote_listener.rs * removes backport merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Problem
Before votes are verified that they are signed by the authorized voter,
they might be dropped in verified-vote-packets code. If there are
enough many spam votes from unauthorized voters, this may potentially
drop valid votes but keep the false ones.
https://github.com/solana-labs/solana/blob/57986f982/core/src/verified_vote_packets.rs#L165-L168
Summary of Changes
Check for authorized voter early on in the vote-listener pipeline