Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks for authorized voter early on in the vote-listener pipeline (backport #22169) #22206

Merged
merged 2 commits into from
Dec 31, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 31, 2021

This is an automatic backport of pull request #22169 done by Mergify.
Cherry-pick of c0c6038 has failed:

On branch mergify/bp/v1.9/pr-22169
Your branch is up to date with 'origin/v1.9'.

You are currently cherry-picking commit c0c603865.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   core/src/tpu.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/src/cluster_info_vote_listener.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…22169)

Before votes are verified that they are signed by the authorized voter,
they might be dropped in verified-vote-packets code. If there are
enough many spam votes from unauthorized voters, this may potentially
drop valid votes but keep the false ones.
https://github.com/solana-labs/solana/blob/57986f982/core/src/verified_vote_packets.rs#L165-L168

(cherry picked from commit c0c6038)

# Conflicts:
#	core/src/cluster_info_vote_listener.rs
@mergify mergify bot added the conflicts label Dec 31, 2021
@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Dec 31, 2021
@mergify
Copy link
Contributor Author

mergify bot commented Dec 31, 2021

automerge label removed due to a CI failure

@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Dec 31, 2021
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Dec 31, 2021
@mergify
Copy link
Contributor Author

mergify bot commented Dec 31, 2021

automerge label removed due to a CI failure

@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Dec 31, 2021
@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #22206 (796c557) into v1.9 (c6ab915) will decrease coverage by 0.0%.
The diff coverage is 97.3%.

@@            Coverage Diff            @@
##             v1.9   #22206     +/-   ##
=========================================
- Coverage    81.1%    81.1%   -0.1%     
=========================================
  Files         518      518             
  Lines      144814   144838     +24     
=========================================
+ Hits       117456   117465      +9     
- Misses      27358    27373     +15     

@mergify mergify bot merged commit ca451ea into v1.9 Dec 31, 2021
@mergify mergify bot deleted the mergify/bp/v1.9/pr-22169 branch December 31, 2021 21:46
@brooksprumo brooksprumo mentioned this pull request Jan 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

This PR has been automatically locked since there has not been any activity in past 14 days after it was merged.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes conflicts locked PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant