demotes WeightedShuffle failures to error metrics #24079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since call-sites are calling unwrap anyways, panicking seems too punitive for our use cases.
behzadnouri
force-pushed
the
weighted-shuffle-err-metrics
branch
from
6f974e6
to
b8b47f6
Compare
mergify bot
pushed a commit
that referenced
this pull request
Apr 3, 2022
Since call-sites are calling unwrap anyways, panicking seems too punitive for our use cases. (cherry picked from commit 7cb3b6c)
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
Since call-sites are calling unwrap anyways, panicking seems too punitive for our use cases. (cherry picked from commit 7cb3b6c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since call-sites are calling unwrap anyways, panicking seems too punitive
for our use cases.
Summary of Changes