Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject durable nonce txs that don't use an advanceable nonce #25832

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Reject durable nonce txs that don't use an advanceable nonce #25832

merged 3 commits into from
Jun 8, 2022

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Jun 8, 2022 •
edited
Loading

Problem

Durable nonce transactions that use the latest durable nonce hash will not result in the nonce account's nonce hash being advanced.

Summary of Changes

Add feature to reject durable nonce transactions that use the latest durable nonce hash

Feature Gate Issue: #25836

@jstarry jstarry added v1.9 feature-gate Pull Request adds or modifies a runtime feature gate labels Jun 8, 2022
@jstarry jstarry force-pushed the feat/reject-same-block-nonce-hash branch from 26c8d83 to e351678 Compare June 8, 2022 02:19
@jstarry jstarry changed the title Reject durable nonce txs that use the latest durable nonce hash Reject durable nonce txs that don't use advanceable nonce Jun 8, 2022
@jstarry jstarry force-pushed the feat/reject-same-block-nonce-hash branch from e351678 to 7f13e4e Compare June 8, 2022 03:25
@jstarry jstarry force-pushed the feat/reject-same-block-nonce-hash branch from 7f13e4e to b28f03a Compare June 8, 2022 03:27
@jstarry jstarry mentioned this pull request Jun 8, 2022
Closed
30 tasks
jackcmay
jackcmay previously approved these changes Jun 8, 2022
View reviewed changes
@jstarry jstarry changed the title Reject durable nonce txs that don't use advanceable nonce Reject durable nonce txs that don't use an advanceable nonce Jun 8, 2022
behzadnouri
behzadnouri reviewed Jun 8, 2022
View reviewed changes
runtime/src/bank.rs Outdated Show resolved Hide resolved
@mergify mergify bot dismissed jackcmay’s stale review June 8, 2022 16:34

Pull request has been modified.

behzadnouri
behzadnouri previously approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@behzadnouri behzadnouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Jun 8, 2022
@mergify mergify bot dismissed behzadnouri’s stale review June 8, 2022 19:44

Pull request has been modified.

@mergify mergify bot merged commit 6a7edc0 into solana-labs:master Jun 8, 2022
mergify bot pushed a commit that referenced this pull request Jun 8, 2022
@jstarry @mergify
Reject durable nonce txs that don't use an advanceable nonce (#25832)
4d1f739 
* Reject durable nonce txs that use the latest durable nonce hash

* feedback

(cherry picked from commit 6a7edc0)

# Conflicts:
#	runtime/src/bank.rs
#	sdk/src/feature_set.rs
@mergify mergify bot mentioned this pull request Jun 8, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 8, 2022
@jstarry @mergify
Reject durable nonce txs that don't use an advanceable nonce (#25832)
8048c99 
* Reject durable nonce txs that use the latest durable nonce hash

* feedback

(cherry picked from commit 6a7edc0)

# Conflicts:
#	sdk/src/feature_set.rs
@mergify mergify bot mentioned this pull request Jun 8, 2022
Merged
jstarry added a commit that referenced this pull request Jun 8, 2022
@jstarry
Reject durable nonce txs that don't use an advanceable nonce (#25832)
eb852ed
jstarry added a commit that referenced this pull request Jun 8, 2022
@jstarry
Reject durable nonce txs that don't use an advanceable nonce (#25832)
da2a5f8 
* Reject durable nonce txs that use the latest durable nonce hash

* feedback
mergify bot added a commit that referenced this pull request Jun 9, 2022
@mergify @jstarry
Reject durable nonce txs that don't use an advanceable nonce (backport …
d385261 
…#25832) (#25855)

* Reject durable nonce txs that don't use an advanceable nonce (#25832)

* resolve conflicts

Co-authored-by: Justin Starry <justin@solana.com>
mergify bot added a commit that referenced this pull request Jun 9, 2022
@mergify @jstarry
Reject durable nonce txs that don't use an advanceable nonce (#25832) (…
5762489 
…#25856)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback

Co-authored-by: Justin Starry <justin@solana.com>
@t-nelson
Copy link
Contributor

t-nelson commented Jun 9, 2022

these were still effectively rejected, but with an InstructionError, right?

@aeyakovenko aeyakovenko mentioned this pull request Jun 9, 2022
Closed
11 tasks
@jstarry
Copy link
Member Author

jstarry commented Jun 9, 2022

This PR will reject invalid durable nonce transactions from being added to a block. It doesn't impact how transactions are processed if they are included in a block. So no, it will not be an instruction error, it will be a transaction error that, if detected, will invalidate the full block.

jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 27, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
991d7c1 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 27, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
8706b0e 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 27, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
d48fde6 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 28, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
bc5bd27 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 28, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
0db9f73 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 28, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
710d6dc 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 28, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
e52550d 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 28, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
09450a3 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 28, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
52a94a0 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
e3ffd2f 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
d9b170b 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
@jstarry @jeffwashington
Reject durable nonce txs that don't use an advanceable nonce (solana-…
bcac757 
…labs#25832)

* Reject durable nonce txs that use the latest durable nonce hash

* feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behzadnouri behzadnouri behzadnouri left review comments

@jackcmay jackcmay jackcmay left review comments

@t-nelson t-nelson Awaiting requested review from t-nelson

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jstarry @t-nelson @behzadnouri @jackcmay