Make active stake consistent in split #33295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
rent-exempt-split
branch
2 times, most recently
from
5d54c37
to
e201022
Compare
Codecov Report
@@ Coverage Diff @@
## master #33295 +/- ##
========================================
Coverage 81.9% 82.0%
========================================
Files 795 796 +1
Lines 215226 215640 +414
========================================
+ Hits 176404 176838 +434
+ Misses 38822 38802 -20 |
t-nelson
requested changes
Sep 18, 2023
CriesofCarrots
force-pushed
the
rent-exempt-split
branch
from
3aa6f79
to
8938201
Compare
joncinque
previously approved these changes
Sep 19, 2023
…ate::Initialized case
CriesofCarrots
force-pushed
the
rent-exempt-split
branch
from
bffbf0e
to
e6a8808
Compare
CriesofCarrots
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
* Add feature gate * Add helper fn * Require split destination to be rent-exempt if it is active * Update cli to prefund split accounts * cli: require rent param with sign-only * Update tokens to prefund split accounts * Update split tests with sysvar accounts * Fix test_split_to_account_with_rent_exempt_reserve * Fix test_staked_split_destination_minimum_balance * Fix test_split_more_than_staked * Fix test_split_minimum_stake_delegation and remove misleading StakeState::Initialized case * Fix test_split_from_larger_sized_account * Add test for pre-/post-activation behavior splitting some or all of stake account * Assert active stake * Fix runtime test * Ignore stake-pool downstream * Review comments * Feature gate sysvar reads (cherry picked from commit bca41ed) # Conflicts: # cli/tests/stake.rs # programs/stake/src/stake_instruction.rs # programs/stake/src/stake_state.rs # runtime/tests/stake.rs # sdk/src/feature_set.rs
CriesofCarrots
added a commit
that referenced
this pull request
Sep 20, 2023
…3319) * Make active stake consistent in split (#33295) * Add feature gate * Add helper fn * Require split destination to be rent-exempt if it is active * Update cli to prefund split accounts * cli: require rent param with sign-only * Update tokens to prefund split accounts * Update split tests with sysvar accounts * Fix test_split_to_account_with_rent_exempt_reserve * Fix test_staked_split_destination_minimum_balance * Fix test_split_more_than_staked * Fix test_split_minimum_stake_delegation and remove misleading StakeState::Initialized case * Fix test_split_from_larger_sized_account * Add test for pre-/post-activation behavior splitting some or all of stake account * Assert active stake * Fix runtime test * Ignore stake-pool downstream * Review comments * Feature gate sysvar reads (cherry picked from commit bca41ed) # Conflicts: # cli/tests/stake.rs # programs/stake/src/stake_instruction.rs # programs/stake/src/stake_state.rs # runtime/tests/stake.rs # sdk/src/feature_set.rs * Fix conflicts --------- Co-authored-by: Tyera <tyera@solana.com>
|
This PR has significant impact on how stake authority can be used. E.g. when stake authority is given to 3rd party to operate on the stake accounts, that 3rd party now has pay for rent (which it has no way of claiming back) and cost of such stake management is quite high. Consider for example Marinade Native - having thousands of stake accounts and splitting and re-balancing them was possible specifically because the rent could have been taken from the existing stake account. Now the cost to split the account would be quite high. Staker funding the split account cannot get hold of the funds later - as opposed to being a withdrawer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Stake split still contains some brittle logic.
Summary of Changes
Update tests to assert that active stake is consistent across split
Add feature to make rent-exempt handling consistent