v1.17: Adds more info to panic message in AccountsHashVerifier (backport of #35353) #35358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 6aaaf85)
|
Justification for backporting: So far this issue has been difficult to debug, as it often depends on the state of the machine (and filesystem) when the panic occurs. Without this backport, then we are effectively saying that we are OK with v1.17 not aiding in debugging. And then likely we would not backport a fix either (because if we aren't willing to backport debug info, why would we suddenly be OK with a more invasive fix). |
brooksprumo
requested review from
sakridge,
willhickey,
steviez and
jeffwashington
|
Review requests:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #35358 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 806 806
Lines 218996 219092 +96
=========================================
+ Hits 178758 178831 +73
- Misses 40238 40261 +23 |
steviez
approved these changes
Feb 28, 2024
willhickey
approved these changes
Mar 1, 2024
|
@sakridge Can I get your review on this backport? |
sakridge
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #35353 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com