Adds more info to panic message in AccountsHashVerifier #35353
Conversation
brooksprumo
added
v1.17
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
| @@ -7479,6 +7484,13 @@ impl AccountsDb { | |||
| .cloned() | |||
| } | |||
|
|
|||
| /// Get all incremental accounts hashes | |||
There was a problem hiding this comment.
Not sure it requires any special "markup", but currently, we only plan to use this function (and the other new one) to get extra information before we panic, right? I guess it is a separate file AND crate, so these have to be pub
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #35353 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 834 834
Lines 224235 224248 +13
=========================================
- Hits 183390 183371 -19
- Misses 40845 40877 +32 |
(cherry picked from commit 6aaaf85)
(cherry picked from commit 6aaaf85)
Problem
There have been reports on Discord where a node panics shortly after starting up with fastboot. The panic in particular is in AccountsHashVerifier, when calculating the incremental accounts hash, and it says the node doesn't have the necessary accounts hash from the base slot (i.e. full snapshot).
So far this issue has been difficult to debug, as it often depends on the state of the machine (and filesystem) when the panic occurs. If we end up in this exceptional scenario, we could log more information that could help the debugging effort.
Related to #35350 and #35190.
Summary of Changes
Adds more information to the panic message, for debugging.