Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solarium 6.0 #752

Closed
mkalkbrenner opened this issue Feb 14, 2020 · 11 comments
Closed

Solarium 6.0 #752

mkalkbrenner opened this issue Feb 14, 2020 · 11 comments
Milestone

Comments

@mkalkbrenner
Copy link
Member

At the moment we have several PRs that will introduce great new features.

On the other hand we should consider to get rid of our own HTPP Adapters and introduce compatibility to various PSRs.

And we should consider to oficially drop support for Solr versions that reached EOL - or at least some of them.

We should discuss the targets of solarium 6.0 here.

But in order to quickly accept the pending PRs I just released 5.1.6 and created the 5.x maintenance branch. master is 6.x now :-)

@mkalkbrenner mkalkbrenner added this to the 6.0 milestone Feb 14, 2020
@mkalkbrenner
Copy link
Member Author

@wickedOne
@thomascorthals
@jsteggink
@thePanz
@timohund
@localheinz
@dmaicher

Your input (and contribution) will be appreciated :-)

BTW I created a milestone where we could assign issues and PRs.

My plan is to release 6.0.0-alpha.1 quickly based on the pending PRs

But we should have enough time to still deprecate some stuff in 5.1.x and to refactor some stuff in 6.x.

@wickedOne
Copy link
Collaborator

wickedOne commented Feb 14, 2020

i like where this is going :-)

my (personal) milestones:

probably some more will come to mind during the weekend B-)

@mkalkbrenner
Copy link
Member Author

Since https://github.com/solariumphp/solarium/releases/tag/5.0.0 we basically support the V2 API.

Using https://github.com/solariumphp/solarium/blob/master/src/QueryType/Server/Api/Query.php you can already use the Schema API (and any other Solr API) kind of "manually".

If we consider to drop the support for older Solr versions, we could migrate a lot of stuff from V1 to V2.

@thomascorthals
Copy link
Member

thomascorthals commented Feb 19, 2020

My personal milestones:

@dmaicher
Copy link
Contributor

I would be interested in contributing the support for PSR-18 😊

@dmaicher dmaicher mentioned this issue Feb 19, 2020
7 tasks
@mkalkbrenner
Copy link
Member Author

mkalkbrenner commented Feb 29, 2020

Getting Solr version from the server. This probably implies full support for api/node/system if doing it right.

I do that in search_api_solr already:

    try {
      $info = $this->getCoreInfo();
    }
    catch (\Exception $e) {
      try {
        $info = $this->getServerInfo();
      }
      catch (SearchApiSolrException $e) {
      }
    }

    // Get our solr version number.
    if (isset($info['lucene']['solr-spec-version'])) {
      return $info['lucene']['solr-spec-version'];
    }

    return '0.0.0';

These are two V1 API calls. First to CORE_OR_COLLECTION_NAME/admin/system and second to admin/info/system as fallback.

@dmaicher
Copy link
Contributor

dmaicher commented Apr 3, 2020

We also need to cleanup/remove some deprecated stuff on master: #771

@mkalkbrenner
Copy link
Member Author

@wickedOne
@thomascorthals
@jsteggink
@thePanz
@timohund
@localheinz
@dmaicher

As you might have noticed, a lot of integrations broke over the last months, namely travis, readthedocs, styleci and coveralls

So I spent some time to fix or replace them. As a result we now have a new set:

  • travis has been replaced by github actions
  • caveralls has been replaced by codecov
  • styleci webhook has been repaired
  • readthedocs webhook has been introduced

I think that our CI now works faster and more reliable than before.

@mkalkbrenner
Copy link
Member Author

mkalkbrenner commented Jun 5, 2020

As you might have noticed I released 6.0.0-alpha.1 today.
Thanks to your support we achieved a lot of our goals!

I know that we still consider some more things to change. But I'm of the opinion that we should involve more people now and let them adapt to solarium 6. And thanks to our enhanced integration tests and to the test results with Drupal I consider this release the best tested ever, even if it is an alpha ;-)
https://github.com/mkalkbrenner/search_api_solr/actions/runs/126048471

Again, @wickedOne @thomascorthals @jsteggink @thePanz @timohund @localheinz @dmaicher @basdenooijer thank you for your contributions and input of the last months and years!!!

@wickedOne
Copy link
Collaborator

yes, some great additions this release! i'll try and sneak in the analytics component by adding some integration tests somewhere during the next 2 weeks 😎

@mkalkbrenner
Copy link
Member Author

If no major issue will be reported I'll do the final 6.0.0 release next week.
@wickedOne For sure we must not stop further additions throughout the solarium 6 life cycle.
But I think it is important to do this release now to enable other frameworks to solve the event dispatching issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants