-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema API Commands for Solr 5+ #346
Conversation
Conflicts: library/Solarium/Core/Client/Adapter/Curl.php
Conflicts: library/Solarium/Core/Client/Adapter/Curl.php
Thanks a lot, this looks like it will be a great addition to the library! I'll try to look into it with a bit more detail soon, and help with any remaining issues. However, in general this is a great first PR! |
Hello, Thanks for your reply :) Besides, I did this for my own needs and I don't have enough time to allow There's also something I may have messed up : I added the schema query in How can I fix it ? Do I have to reformat it again, delete this PR and make This leads me to another question : do you really want to keep PHP 5.3+ Thank you, 2015-07-02 7:59 GMT+02:00 Bas de Nooijer notifications@github.com:
|
Hello again, I fixed the Solarium\Core\Client\Client class by removing short-array syntax, giving it back its compatibility with PHP 5.3. The new commit is d28931c. Ben |
@bpolaszek Thanks for working on this! :) @basdenooijer I'd like to help getting this to a mergeable state (tests/ formatting and so on). I don't know whether this would be by creating a different PR that contains these commits, with some additional ones on top? I think the branch will also need to be rebased against latest master. |
@shieldo that would be great! I think creating a PR based on this one is indeed the way to go |
Have opened #374. |
Closing this PR in favor of #374 |
https://cwiki.apache.org/confluence/display/solr/Schema+API
Add / replace / delete fields
Add / replace / delete dynamic fields
Add / replace / delete field types
Add / delete copy fields
Example usage:
You can also retrieve the Schema data when you don't attempt to modify it:
This is my first PR ever, sorry if the git repo isn't totally cleaned up :/
Besides, even if I have tested most of use cases, some more accurate tests might be done to ensure this is production-ready.