[WIP] add support for Schema API for Solr 5 #374
Conversation
|
Nice work! |
|
+1024! |
| @@ -91,7 +91,12 @@ class Client extends Configurable | |||
| const QUERY_UPDATE = 'update'; | |||
|
|
|||
| /** | |||
| * Querytype ping. | |||
| * Querytype schema | |||
There was a problem hiding this comment.
Missing a dot (.) in the end of comment, same as in line 99
|
Is this PR considered ready for review, or are there still some known issues? It would be a very nice feature to add! |
|
Sorry, not quite there yet - but this is the reminder I need to get it over the finishing line! |
|
Poke Is there something we can do to get this feature merged? :-) |
|
Poking might help! :) I'm definitely mindful of it. I'll keep this tab open to remind me. Would be really great to complete this. |
|
@shieldo I'm poking too! |
|
@guiwoda Yes, I was just thinking about this! I would need to get my head back in as it's been a few months. Keeping this tab open - I obviously failed at that. I've made a reminder to myself to pick this up at the weekend! |
|
Awesome. Ping me back then if you need a hand :) |
Picking up from PR #346 by @bpolaszek.
Work in progress - have improved coding standards, made some coding tweaks/ fixes, added a test for the schema query class. Forthcoming: test coverage for everything else.