Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty string assignment via falsy value #1

Open
volegg opened this issue Jun 9, 2016 · 2 comments
Open

Empty string assignment via falsy value #1

volegg opened this issue Jun 9, 2016 · 2 comments
Labels

Comments

@volegg
Copy link

volegg commented Jun 9, 2016

If we have boolean value in data provider all False value will be empty string ''. It is unexpected behaviour. Should be fixed something below (index.js):

var originValue = item[field];
tmpValue = originValue === undefined || originValue === null ? '' : originValue;
@solee0524
Copy link
Owner

@volegg
Thanks for your mention. I make a stupid mistake. I will fix it in next commit.
Thx again.

@solee0524
Copy link
Owner

Hi there,
It fixed on this commit (fix boolean false value to empty string).

@solee0524 solee0524 added the bug label Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants