Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow offsets to be relative to arbitrary value #7

Closed
solemnwarning opened this issue Nov 17, 2018 · 4 comments
Closed

Allow offsets to be relative to arbitrary value #7

solemnwarning opened this issue Nov 17, 2018 · 4 comments
Labels
feature A new feature
Milestone
0.3.90

Comments

@solemnwarning
Copy link
Owner

Make it so the offsets used in the UI can be adjusted by an arbitrary amount, for example to help finding things relative to a DLL base address, or to a point in the file.
@solemnwarning solemnwarning added the feature A new feature label Nov 17, 2018
@solemnwarning
Copy link
Owner Author

Rather than making this a file-wide offset adjustment, it might be better to have multiple regions of (non-overlapping) ranges specifiable - then executables (for example) can have the address spaces of different sections mapped appropriately, probably displayed in addition to the file offsets somehow.

@solemnwarning solemnwarning mentioned this issue Sep 30, 2020
Closed
@solemnwarning solemnwarning added this to the 0.4.0 milestone Oct 14, 2020
@alexforencich
Copy link

Supporting independent sections is really the way to go. Perhaps you need multiple views - "raw" file view, and sectioned view (for files that support multiple sections). Additionally, each section should be a completely independent address space. This is useful for any file type that can be sparse (intel hex) and/or supports defined, specific, relocatable sections (elf, etc.).

@solemnwarning
Copy link
Owner Author

This has been implemented on the segments branch and will probably be merged soon. Outstanding issues:

  • Selecting between segments in the virtual segments view produces nonsensical results.
  • Some operations (e.g. setting a mapping) take multiple undo operations.

solemnwarning added a commit that referenced this issue Apr 3, 2021
@solemnwarning
Implement new undo system.
76d637b 
* Don't hold undo AND redo functions for content modifications - just
  store one at a time which will create and return the inverse function
  when called (#52).

* Allow grouping multiple things into a single tranasction. Needed for
  finishing EXE parser plugin (#86) and virtual segments (#7).
solemnwarning added a commit that referenced this issue Apr 3, 2021
@solemnwarning
Implement new undo system.
e9057a6 
* Don't hold undo AND redo functions for content modifications - just
  store one at a time which will create and return the inverse function
  when called (#52).

* Allow grouping multiple things into a single tranasction. Needed for
  finishing EXE parser plugin (#86) and virtual segments (#7).
@solemnwarning
Copy link
Owner Author

Opened issues #125 and #126 to track outstanding bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A new feature
Projects
None yet
Milestone
0.3.90
Development

No branches or pull requests
2 participants
@alexforencich @solemnwarning