Composable flash loan implementation #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkiplet
commented
Feb 9, 2022
0xkiplet
commented
Feb 9, 2022
0xkiplet
commented
Feb 9, 2022
| }; | ||
|
|
||
| let flash_loan_amount_decimal = Decimal::from(flash_loan_amount); | ||
| let (origination_fee, host_fee) = reserve |
There was a problem hiding this comment.
I chose to carry over the same fee options that exist for the existing flash loans, but we could change this.
0xkiplet
commented
Feb 9, 2022
0xkiplet
commented
Feb 9, 2022
0xkiplet
commented
Feb 9, 2022
0xkiplet
commented
Feb 9, 2022
0xkiplet
commented
Feb 9, 2022
| @@ -40,5 +40,5 @@ crates=( | |||
|
|
|||
| set -x | |||
| for crate in "${crates[@]}"; do | |||
| sed -i'' -e "s#\(${crate} = \"\)\(=\?\).*\(\"\)#\1\2$solana_ver\3#g" "${tomls[@]}" | |||
| sed -E -i'' -e "s#(${crate} = \")(=?).*#\1\2${solana_ver}\"#" "${tomls[@]}" | |||
There was a problem hiding this comment.
I found this change upstream in solana-program-library and it allows this script to work on Macs.
0xkiplet
force-pushed
the
0xkiplet/instruction-flash-loans
branch
from
3177861
to
b6105df
Compare
0xkiplet
force-pushed
the
0xkiplet/instruction-flash-loans
branch
from
b6105df
to
7160c00
Compare
0xkiplet
changed the title
0xkiplet
commented
Feb 9, 2022
0xkiplet
commented
Feb 9, 2022
0xkiplet
force-pushed
the
0xkiplet/instruction-flash-loans
branch
2 times, most recently
from
af477f0
to
4e5719c
Compare
0xkiplet
force-pushed
the
0xkiplet/instruction-flash-loans
branch
2 times, most recently
from
2ae3a83
to
78028d5
Compare
0xkiplet
force-pushed
the
0xkiplet/instruction-flash-loans
branch
from
78028d5
to
beb1e47
Compare
0xkiplet
force-pushed
the
0xkiplet/instruction-flash-loans
branch
2 times, most recently
from
93f1a66
to
fd289bf
Compare
0xkiplet
force-pushed
the
0xkiplet/instruction-flash-loans
branch
from
fd289bf
to
a14e6b3
Compare
0xkiplet
force-pushed
the
0xkiplet/instruction-flash-loans
branch
from
c6a0bdf
to
aff68d4
Compare
DaSichuan
reviewed
Feb 17, 2022
DaSichuan
reviewed
Feb 17, 2022
DaSichuan
reviewed
Feb 17, 2022
DaSichuan
reviewed
Feb 17, 2022
0xkiplet
commented
Feb 17, 2022
| let token_program_id = next_account_info(account_info_iter)?; | ||
| let clock = &Clock::from_account_info(next_account_info(account_info_iter)?)?; | ||
|
|
||
| _refresh_reserve_interest(program_id, reserve_info, clock)?; |
There was a problem hiding this comment.
Note: Modified this to always refresh the reserve
0xkiplet
commented
Feb 17, 2022
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn end_to_end_with_flash_borrow() { |
There was a problem hiding this comment.
I added this end-to-end test which verifies that the reserve has been force refreshed during flash borrow.
0xkiplet
force-pushed
the
0xkiplet/instruction-flash-loans
branch
from
ceb8087
to
9d95e1a
Compare
0xkiplet
force-pushed
the
0xkiplet/instruction-flash-loans
branch
from
9d95e1a
to
74a8d17
Compare
0xkiplet
force-pushed
the
0xkiplet/instruction-flash-loans
branch
from
1bc509e
to
f8de57a
Compare
|
@0xkiplet When deploy? |
sadly not a priority at the moment ping me on discord to chat |
|
Just checking on the progress here. Thanks! |
Merged
|
Even though pull request is still open, it looks like the functionality was delivered |
|
@unordered-set true yeh will clean this up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A port of Hana's flash loan implementation into the Solend protocol. This is a proof of concept for adding this composable flash loan functionality.
For now only a single happy path test is written. More tests are needed.