Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download all traits from phenotype dialog box fixed #4533

Merged
merged 3 commits into from
May 15, 2023
Merged

download all traits from phenotype dialog box fixed #4533

merged 3 commits into from
May 15, 2023

Conversation

darekbienkowski
Copy link
Contributor

@darekbienkowski darekbienkowski commented May 11, 2023 •
edited
Loading

Description

Fixed selection of all traits from the dialog box.

functionality is here:

Manage/Accessions
-> Accession detail page
-> Traits Assayed ( panel )
-> Download Phenotypes ( button )
-> Additional Search Options

Screencast.from.05-11-2023.08.24.33.PM.webm

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@darekbienkowski darekbienkowski mentioned this pull request May 12, 2023
Closed
bellerbrock
bellerbrock approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@bellerbrock bellerbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

alockrow
alockrow approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@alockrow alockrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@lukasmueller lukasmueller merged commit 42b7b18 into master May 15, 2023
1 check passed
@lukasmueller lukasmueller deleted the topic/accession_download_all_traits branch May 15, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellerbrock bellerbrock bellerbrock approved these changes

@alockrow alockrow alockrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@darekbienkowski @bellerbrock @alockrow @lukasmueller