Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solid faker seed #1210

Merged

Conversation

christophsaile
Copy link

@christophsaile christophsaile commented Jul 15, 2024

Description:

This fix should ensure that repeated calls with the same seed produce consistent outputs.

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@christophsaile christophsaile linked an issue Jul 15, 2024 that may be closed by this pull request
9 tasks
@christophsaile christophsaile self-assigned this Jul 15, 2024
@christophsaile christophsaile requested a review from a team July 15, 2024 13:06
@christophsaile christophsaile merged commit 6c3b3f7 into main Jul 16, 2024
12 of 13 checks passed
@christophsaile christophsaile deleted the 1120-fix-solid-faker-generates-different-output branch July 16, 2024 08:03
karlbaumhauer pushed a commit that referenced this pull request Jul 16, 2024
# [@solid-design-system/placeholders-v1.6.1](placeholders/1.6.0...placeholders/1.6.1) (2024-07-16)

### Bug Fixes

* solid faker seed ([#1210](#1210)) [skip chromatic] ([6c3b3f7](6c3b3f7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: 🤔 solid-faker generates different output
2 participants