Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dataType on Representation into binary #122

Merged
merged 3 commits into from
Sep 3, 2020

Conversation

RubenVerborgh
Copy link
Member

@RubenVerborgh RubenVerborgh commented Sep 2, 2020

The dataType field would be highly redundant, since we also have the content type on the metadata.

What we really need to know, is whether we have a stream of strings or objects, which I propose to indicate with a binary field. Whatever subtype of non-binary it is, will be disclosed in the content type anyway.

@joachimvh
Copy link
Member

I think this might also be a point to consider how much added value dataType has. Currently it is equal to contentType === INTERNAL_QUADS (and actually also equal to data.readableObjectMode, which unfortunately can only be checked starting from Node 12).

@RubenVerborgh
Copy link
Member Author

I think this might also be a point to consider how much added value dataType has. Currently it is equal to contentType === INTERNAL_QUADS (and actually also equal to data.readableObjectMode, which unfortunately can only be checked starting from Node 12).

Exactly. But:

@joachimvh joachimvh merged commit ee3b847 into master Sep 3, 2020
@joachimvh joachimvh deleted the refactor/remove-datatype branch September 3, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☀️ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants